Skip to content

Commit 5b7486a

Browse files
Make sure to set defaults for ending cell execution
1 parent 13604bd commit 5b7486a

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

libs/vscode/notebooks/src/lib/controller/idl-notebook-controller.class.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ import { dirname, join } from 'path';
4343
import * as vscode from 'vscode';
4444

4545
import {
46+
DEFAULT_END_CELL_EXECUTION_ACTIONS,
4647
ICurrentCell,
4748
IEndCellExecutionActions,
4849
} from './idl-notebook-controller.interface';
@@ -327,7 +328,7 @@ export class IDLNotebookController {
327328
*/
328329
private async _endCellExecution(
329330
success: boolean,
330-
actions: Partial<IEndCellExecutionActions> = {}
331+
inActions: Partial<IEndCellExecutionActions> = {}
331332
) {
332333
/**
333334
* Get current cell
@@ -342,6 +343,9 @@ export class IDLNotebookController {
342343
return;
343344
}
344345

346+
/** Get default actions */
347+
const actions = { ...DEFAULT_END_CELL_EXECUTION_ACTIONS, ...inActions };
348+
345349
/**
346350
* Function to handle edge case of canceling execution right at this point
347351
*/

0 commit comments

Comments
 (0)