Tidy up some additional type errors

Author: znorman-harris

libs/envi/modeler/src/lib/helpers/build-node-json.ts

@@ -96,13 +96,17 @@ export function BuildNodeJSON(
       }
       base['envitask'] = envitask;
 
-      // get display name
-      const info = registry.getTaskDetail(node.task_name as string);
-
-      // set display name of task
-      if (info.structure.meta.readableName) {
-        base['display_name'] = info.structure.meta.readableName;
+      // check if we have a display name
+      if (registry.hasTask(node.task_name as string)) {
+        // get display name
+        const info = registry.getTaskDetail(node.task_name as string);
+
+        // set display name of task
+        if (info.structure.meta.readableName) {
+          base['display_name'] = info.structure.meta.readableName;
+        }
       }
+
       break;
     }
 

libs/vscode/server/src/lib/helpers/add-additional-search-paths.ts

@@ -15,8 +15,8 @@ import { existsSync } from 'fs';
  */
 export function AddAdditionalSearchPaths(
   paths: IFolderRecursion,
-  idlBin: string,
-) {
+  idlBin?: string,
+): boolean {
   // add in our IDL folder
   paths[GetExtensionPath('idl/vscode/notebooks')] = true;
 
@@ -25,6 +25,11 @@ export function AddAdditionalSearchPaths(
     paths[IDL_PACKAGE_DIR] = true;
   }
 
+  // return if we don't have a folder
+  if (!idlBin) {
+    return false;
+  }
+
   /** Load folders where custom content for ENVI lives */
   const enviPaths = LoadENVIPaths(idlBin);
 

libs/vscode/server/src/lib/helpers/merge-config.ts

@@ -4,6 +4,7 @@ import {
   IDL_PROBLEM_CODE_SHORTHAND_LOOKUP,
   IDL_PROBLEM_CODES,
   IDL_REVERSE_PROBLEM_CODE_ALIAS_LOOKUP,
+  IDLProblemCode,
 } from '@idl/types/problem-codes';
 import { DEFAULT_IDL_EXTENSION_CONFIG } from '@idl/vscode/extension-config';
 import { copy } from 'fast-copy';
@@ -14,10 +15,13 @@ import {
   WORKSPACE_FOLDER_CONFIGS,
 } from './track-workspace-config';
 
+// type for ignore problem codes
+type IgnoreProblemCodes = { [key in IDLProblemCode]?: boolean };
+
 /**
  * Track all problem codes that we want to filter out from being reported to the user
  */
-export const IGNORE_PROBLEM_CODES: { [key: number]: boolean } = {};
+export const IGNORE_PROBLEM_CODES: IgnoreProblemCodes = {};
 
 /**
  * Track cases where we exclude problem reporting
@@ -62,7 +66,7 @@ export function MergeConfig() {
   // empty problem codes in case we have new ones coming through
   const currentCodes = Object.keys(IGNORE_PROBLEM_CODES);
   for (let i = 0; i < currentCodes.length; i++) {
-    delete IGNORE_PROBLEM_CODES[currentCodes[i]];
+    delete IGNORE_PROBLEM_CODES[+currentCodes[i] as IDLProblemCode];
   }
 
   // empty folders
@@ -104,7 +108,7 @@ export function MergeConfig() {
             true;
         }
       } else {
-        IGNORE_PROBLEM_CODES[code] = true;
+        IGNORE_PROBLEM_CODES[code as IDLProblemCode] = true;
       }
     }