New property for variables to update them during post-processing

Author: znorman-harris

libs/parsing/index/src/lib/post-process/post-process-parsed.ts

@@ -3,6 +3,7 @@ import { GetSemanticTokens } from '@idl/parsing/semantic-tokens';
 import {
   IParsed,
   PopulateScopeDetailAndResetTokenCache,
+  ResetVariables,
 } from '@idl/parsing/syntax-tree';
 
 import { GetSyntaxProblems } from '../helpers/get-syntax-problems';
@@ -26,6 +27,11 @@ export function PostProcessParsed(
    */
   PopulateScopeDetailAndResetTokenCache(parsed, cancel);
 
+  /**
+   * Reset variables so we can update types
+   */
+  ResetVariables(parsed);
+
   /**
    * Populate types of local variables and validate them
    */

libs/parsing/syntax-tree/src/index.ts

@@ -59,6 +59,7 @@ export * from './lib/recursion-and-callbacks/tree-recurser-basic';
 export * from './lib/remove-scope-detail';
 export * from './lib/remove-scope-detail-and-reset-token-cache';
 export * from './lib/reset-token-cache';
+export * from './lib/reset-variables';
 export * from './lib/set-token-cache';
 export * from './lib/syntax-problem-with';
 export * from './lib/validator.class.interface';

libs/parsing/syntax-tree/src/lib/populators/populate-global.ts

@@ -203,6 +203,7 @@ export function PopulateGlobalLocalCompileOpts(
                 meta: {
                   display: 'self',
                   isDefined: true,
+                  canReset: false,
                   docs: IDL_TRANSLATION.docs.hover.params.self,
                   source: GLOBAL_TOKEN_SOURCE_LOOKUP.USER,
                   type: ParseIDLType(split[0]),
@@ -319,6 +320,7 @@ export function PopulateGlobalLocalCompileOpts(
                 meta: {
                   display: 'self',
                   isDefined: true,
+                  canReset: false,
                   docs: IDL_TRANSLATION.docs.hover.params.self,
                   source: GLOBAL_TOKEN_SOURCE_LOOKUP.USER,
                   type: ParseIDLType(split[0]),

libs/parsing/syntax-tree/src/lib/populators/populate-local.interface.ts

@@ -33,6 +33,17 @@ export const LOCAL_TOKEN_LOOKUP: ILocalTokenNameLookup = {
 export interface ILocalVariableTokenMetadata extends IBaseValueDetails {
   /** A flag indicating if our variable has been defined or not */
   isDefined: boolean;
+  /**
+   * For variables that we detect, can we reset them during our post-processing?
+   *
+   * This is needed because we have variables from arguments and keywords which can't reset as
+   * they are static, but we have variables inside code from things like `a = plot()` where, if
+   * the function "plot()" changes, we have to reset the variable and re-determine the type for
+   * said variable.
+   *
+   * We don't do this for args/keywords though because they are static.
+   */
+  canReset: boolean;
   /** Flag indicating if our variable represents a static class or not */
   isStaticClass?: boolean;
   /**

libs/parsing/syntax-tree/src/lib/reset-variables.ts

@@ -0,0 +1,41 @@
+import { IParsed } from './parsed.interface';
+import { LocalToken } from './populators/populate-local.interface';
+
+/** Resets array of tokens */
+function _ResetVariables(vars: LocalToken[]) {
+  for (let i = 0; i < vars.length; i++) {
+    if (vars[i].meta.canReset) {
+      vars[i].meta.isDefined = false;
+    }
+  }
+}
+
+/**
+ * Resets variables that can be reset so we can update types when we
+ * just post-process code and don't do a full parse.
+ *
+ * This is needed because some variables are dynamic and some are static (i.e.
+ * arguments and keywords)
+ */
+export function ResetVariables(parsed: IParsed): void {
+  /**
+   * Reset functions
+   */
+  const funcs = Object.keys(parsed.local.func);
+  for (let i = 0; i < funcs.length; i++) {
+    _ResetVariables(Object.values(parsed.local.func[funcs[i]]));
+  }
+
+  /**
+   * Reset functions
+   */
+  const pros = Object.keys(parsed.local.pro);
+  for (let i = 0; i < pros.length; i++) {
+    _ResetVariables(Object.values(parsed.local.pro[pros[i]]));
+  }
+
+  /**
+   * Reset main
+   */
+  _ResetVariables(Object.values(parsed.local.main));
+}