Skip to content

Commit c244d37

Browse files
Decorations code follows VSCode example, use whole lines for stack + err
1 parent e2f7445 commit c244d37

2 files changed

Lines changed: 19 additions & 7 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ For notebook cells, syntax errors are now highlighted and problems are reported
3434

3535
When you run a notebook cell, and IDL stops running, we now show the line in the cell that was stopped on to help track down problems.
3636

37+
Syntax error and notebook decorations now cover the whole line instead of just the text on the line to help make them pop more.
38+
3739
Improved the user experience for breakpoints when working with IDL. Some of the new behaviors include:
3840

3941
- Properly setting breakpoints when you add them to a file before IDL starts

libs/vscode/decorations/src/lib/idl-decorations-manager.interface.ts

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,13 @@ export interface IStackTraceLookup {
3939
*/
4040
export const STACK_TRACE_DECORATION =
4141
vscode.window.createTextEditorDecorationType({
42-
backgroundColor: 'rgba(163, 149, 0, 0.4)',
43-
gutterIconPath: GetExtensionPath(
44-
'extension/images/dark/debug-stackframe.svg'
45-
),
42+
isWholeLine: true,
43+
dark: {
44+
backgroundColor: 'rgba(163, 149, 0, 0.4)',
45+
gutterIconPath: GetExtensionPath(
46+
'extension/images/dark/debug-stackframe.svg'
47+
),
48+
},
4649
light: {
4750
backgroundColor: 'rgba(255, 235, 0, 0.2)',
4851
gutterIconPath: GetExtensionPath(
@@ -58,7 +61,10 @@ export const STACK_TRACE_DECORATION =
5861
*/
5962
export const SYNTAX_ERROR_DECORATION =
6063
vscode.window.createTextEditorDecorationType({
61-
backgroundColor: 'rgba(163, 0, 0, 0.4)',
64+
isWholeLine: true,
65+
dark: {
66+
backgroundColor: 'rgba(163, 0, 0, 0.4)',
67+
},
6268
light: {
6369
backgroundColor: 'rgba(255, 0, 0, 0.2)',
6470
},
@@ -71,13 +77,17 @@ export const SYNTAX_ERROR_DECORATION =
7177
*/
7278
export const CODE_COVERAGE_DECORATIONS = {
7379
NOT_EXECUTED: vscode.window.createTextEditorDecorationType({
74-
backgroundColor: 'rgba(163, 0, 0, 0.4)',
80+
dark: {
81+
backgroundColor: 'rgba(163, 0, 0, 0.4)',
82+
},
7583
light: {
7684
backgroundColor: 'rgba(255, 0, 0, 0.2)',
7785
},
7886
}),
7987
EXECUTED: vscode.window.createTextEditorDecorationType({
80-
backgroundColor: 'rgba(0, 122, 30, 0.4)',
88+
dark: {
89+
backgroundColor: 'rgba(0, 122, 30, 0.4)',
90+
},
8191
light: {
8292
backgroundColor: 'rgba(255, 235, 0, 0.2)',
8393
},

0 commit comments

Comments
 (0)