Skip to content

Commit ef002de

Browse files
Update config to remove vscode warning in settings JSON
1 parent 454a9ad commit ef002de

3 files changed

Lines changed: 13 additions & 6 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@ Changed the way that the language server sends work to the threads that parse co
2828

2929
For large files, this had a significant impact on perceived performance as the worker threads could get locked serializing and de-serializing objects (also leads to more memory usage). Now, large files like slicer3.pro which are included in the IDL installation, provide auto-complete and hover help in about ~0.5 seconds instead of 5+ seconds.
3030

31+
Fixed an issue where, from the JSON settings editor, a valid extension setting would be highlighted as being an incorrect value.
32+
3133
## 4.6.1 - September 2024
3234

3335
Added layer controls to the Notebook Map.

apps/package-json/src/contributes/config/questions-config.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,28 +42,32 @@ export function AddQuestionsConfig(nls: IPackageNLS) {
4242
properties: {
4343
forIDLDir: {
4444
type: 'boolean',
45-
default: false,
4645
description: TranslationFromConfiguration(
4746
IDL_EXTENSION_CONFIG_KEYS.dontAskForIDLDir,
4847
nls
4948
),
5049
},
5150
forIconChange: {
5251
type: 'boolean',
53-
default: false,
5452
description: TranslationFromConfiguration(
5553
IDL_EXTENSION_CONFIG_KEYS.dontAskForIconChange,
5654
nls
5755
),
5856
},
5957
forFormatterChange: {
6058
type: 'boolean',
61-
default: false,
6259
description: TranslationFromConfiguration(
6360
IDL_EXTENSION_CONFIG_KEYS.dontAskForFormatterChange,
6461
nls
6562
),
6663
},
64+
toOpenDocs: {
65+
type: 'boolean',
66+
description: TranslationFromConfiguration(
67+
IDL_EXTENSION_CONFIG_KEYS.dontAskToOpenDocs,
68+
nls
69+
),
70+
},
6771
// toInitConfig: {
6872
// type: 'boolean',
6973
// default: false,

package.json

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1139,18 +1139,19 @@
11391139
"properties": {
11401140
"forIDLDir": {
11411141
"type": "boolean",
1142-
"default": false,
11431142
"description": "%configuration.descriptions.dontAsk.forIDLDir%"
11441143
},
11451144
"forIconChange": {
11461145
"type": "boolean",
1147-
"default": false,
11481146
"description": "%configuration.descriptions.dontAsk.forIconChange%"
11491147
},
11501148
"forFormatterChange": {
11511149
"type": "boolean",
1152-
"default": false,
11531150
"description": "%configuration.descriptions.dontAsk.forFormatterChange%"
1151+
},
1152+
"toOpenDocs": {
1153+
"type": "boolean",
1154+
"description": "%configuration.descriptions.dontAsk.toOpenDocs%"
11541155
}
11551156
}
11561157
}

0 commit comments

Comments
 (0)