fix: error for parsing feature/usageLimit without value key

Author: javiercavlop

src/main/java/io/github/isagroup/services/parsing/AddOnParser.java

@@ -178,7 +178,13 @@ private static void setAddOnFeatures(String addOnName, Map<String, Object> addOn
 
         for (String addOnFeatureName : addOnFeaturesMap.keySet()) {
 
-            Map<String, Object> addOnFeatureMap = (Map<String, Object>) addOnFeaturesMap.get(addOnFeatureName);
+            Object featureObj = addOnFeaturesMap.get(addOnFeatureName);
+            if (!(featureObj instanceof Map)) {
+                throw new PricingParsingException("The feature " + addOnFeatureName
+                        + " of the add-on " + addOnName + " is not a valid map. Maybe 'value' attribute is missing to set the value of the feature");
+            }
+            @SuppressWarnings("unchecked")
+            Map<String, Object> addOnFeatureMap = (Map<String, Object>) featureObj;
 
             if (!globalFeaturesMap.containsKey(addOnFeatureName)) {
                 throw new FeatureNotFoundException(
@@ -232,9 +238,23 @@ private static void setAddOnUsageLimits(String addOnName, Map<String, Object> ad
         Map<String, Object> addOnUsageLimitsMap = null;
 
         if (areExtensions) {
-            addOnUsageLimitsMap = (Map<String, Object>) addOnMap.get("usageLimitsExtensions");
+            Object usageLimitsExtensionsObj = addOnMap.get("usageLimitsExtensions");
+            if (usageLimitsExtensionsObj instanceof Map<?, ?>) {
+                addOnUsageLimitsMap = (Map<String, Object>) usageLimitsExtensionsObj;
+            } else if (usageLimitsExtensionsObj != null) {
+                throw new PricingParsingException("The field \"usageLimitsExtensions\" should be a map. It is currently: "
+                        + usageLimitsExtensionsObj.getClass().getSimpleName() + ". "
+                        + "Maybe you forgot to add the 'value' attribute to the usage limit in the add-on definition.");
+            }
         } else {
-            addOnUsageLimitsMap = (Map<String, Object>) addOnMap.get("usageLimits");
+            Object usageLimitsObj = addOnMap.get("usageLimits");
+            if (usageLimitsObj instanceof Map<?, ?>) {
+                addOnUsageLimitsMap = (Map<String, Object>) usageLimitsObj;
+            } else if (usageLimitsObj != null) {
+                throw new PricingParsingException("The field \"usageLimits\" should be a map. It is currently: "
+                        + usageLimitsObj.getClass().getSimpleName() + ". "
+                        + "Maybe you forgot to add the 'value' attribute to the usage limit in the add-on definition.");
+            }
         }
         Map<String, UsageLimit> globalUsageLimitsMap = pricingManager.getUsageLimits();
         Map<String, UsageLimit> addOnUsageLimits = new LinkedHashMap<>();

src/main/java/io/github/isagroup/services/parsing/PlanParser.java

@@ -103,7 +103,13 @@ private static void setFeaturesToPlan(String planName, Map<String, Object> map,
 
         for (String planFeatureName : planFeaturesMap.keySet()) {
 
-            Map<String, Object> planFeatureMap = (Map<String, Object>) planFeaturesMap.get(planFeatureName);
+            Object planFeatureObj = planFeaturesMap.get(planFeatureName);
+            if (!(planFeatureObj instanceof Map)) {
+                throw new PricingParsingException("The feature " + planFeatureName
+                        + " of the plan " + planName + " is not a valid map. Maybe 'value' attribute is missing to set the value of the feature");
+            }
+            @SuppressWarnings("unchecked")
+            Map<String, Object> planFeatureMap = (Map<String, Object>) planFeatureObj;
 
             if (!plan.getFeatures().containsKey(planFeatureName)) {
                 throw new FeatureNotFoundException(
@@ -188,7 +194,13 @@ private static void setUsageLimitsToPlan(String planName, Map<String, Object> ma
 
         for (String planUsageLimitName : planUsageLimitsMap.keySet()) {
 
-            Map<String, Object> planUsageLimitMap = (Map<String, Object>) planUsageLimitsMap.get(planUsageLimitName);
+            Object planUsageLimitObj = planUsageLimitsMap.get(planUsageLimitName);
+            if (!(planUsageLimitObj instanceof Map)) {
+                throw new PricingParsingException("The usageLimit " + planUsageLimitName
+                    + " of the plan " + planName + " is not a valid map. Maybe 'value' attribute is missing to set the value of the usageLimit");
+            }
+            @SuppressWarnings("unchecked")
+            Map<String, Object> planUsageLimitMap = (Map<String, Object>) planUsageLimitObj;
 
             if (!plan.getUsageLimits().containsKey(planUsageLimitName)) {
                 throw new FeatureNotFoundException(