Return empty array in case of missing attributes

Author: melikpehlivanov

src/MyTested.AspNetCore.Mvc.Abstractions/Utilities/Reflection.cs

@@ -291,6 +291,12 @@ public static IEnumerable<object> GetCustomAttributes(object obj, bool shouldInh
         {
             var type = obj.GetType();
             var attributes = type.GetTypeInfo().GetCustomAttributes(shouldInherit);
+
+            if (!HasAnyAttributes(attributes, TypeAttributesCache))
+            {
+                return attributes;
+            }
+
             if (attributes.Length == TypeAttributesCache.Count)
             {
                 return TypeAttributesCache.Values;
@@ -309,6 +315,12 @@ public static IEnumerable<object> GetCustomAttributes(object obj, bool shouldInh
         public static IEnumerable<object> GetCustomAttributes(MethodInfo method, bool shouldInherit = ShouldInheritAttributes)
         {
             var attributes = method.GetCustomAttributes(shouldInherit);
+
+            if (!HasAnyAttributes(attributes, MethodAttributesCache))
+            {
+                return attributes;
+            }
+
             if (attributes.Length == MethodAttributesCache.Count)
             {
                 return MethodAttributesCache.Values;
@@ -757,6 +769,9 @@ private static void CacheAttributes(IEnumerable<object> attributes, ConcurrentDi
             }
         }
 
+        private static bool HasAnyAttributes(IReadOnlyCollection<object> attributes, ConcurrentDictionary<Type, object> result)
+            => attributes.Count != 0 || result.Any();
+
         private static string GetFriendlyTypeName(Type type, bool useFullName)
         {
             const string anonymousTypePrefix = "<>f__";