Added tests for the .ShouldReturn().ActionResult() assertion chain (#359)

Author: ivaylokenov

test/MyTested.AspNetCore.Mvc.Controllers.Test/BuildersTests/ActionsTests/ShouldReturnTests/ShouldReturnActionResultTests.cs

@@ -0,0 +1,55 @@
+namespace MyTested.AspNetCore.Mvc.Test.BuildersTests.ActionsTests.ShouldReturnTests
+{
+    using Exceptions;
+    using Setups;
+    using Setups.Controllers;
+    using Xunit;
+
+    public class ShouldReturnActionResultTests
+    {
+        [Fact]
+        public void ShouldReturnActionResultShouldNotThrowExceptionWhenResultIsIActionResultInterface()
+        {
+            MyController<MvcController>
+                .Instance()
+                .Calling(c => c.ActionResultInterface())
+                .ShouldReturn()
+                .ActionResult();
+        }
+
+        [Fact]
+        public void ShouldReturnActionResultShouldNotThrowExceptionWhenResultIsIActionResultBaseClass()
+        {
+            MyController<MvcController>
+                .Instance()
+                .Calling(c => c.ActionResultBaseClass())
+                .ShouldReturn()
+                .ActionResult();
+        }
+
+        [Fact]
+        public void ShouldReturnActionResultShouldNotThrowExceptionWhenResultIsActionResultOfT()
+        {
+            MyController<MvcController>
+                .Instance()
+                .Calling(c => c.ActionResultOfAnonymousType())
+                .ShouldReturn()
+                .ActionResult();
+        }
+
+        [Fact]
+        public void ShouldReturnActionResultShouldThrowExceptionWhenWhenResultIsNotActionResult()
+        {
+            Test.AssertException<InvocationResultAssertionException>(
+                () =>
+                {
+                    MyController<MvcController>
+                        .Instance()
+                        .Calling(c => c.AnonymousResult())
+                        .ShouldReturn()
+                        .ActionResult();
+                },
+                "When calling AnonymousResult action in MvcController expected result to be IActionResult or ActionResult<TValue>, but instead received AnonymousType<Int32, String, AnonymousType<Boolean>>.");
+        }
+    }
+}

test/MyTested.AspNetCore.Mvc.Controllers.Test/BuildersTests/ActionsTests/ShouldReturnTests/ShouldReturnBadRequestTests.cs

@@ -8,7 +8,7 @@
     public class ShouldReturnBadRequestTests
     {
         [Fact]
-        public void ShouldReturnBadRequestShouldNotThrowExceptionWhenResultIsHttpBadRequest()
+        public void ShouldReturnBadRequestShouldNotThrowExceptionWhenResultIsBadRequest()
         {
             MyController<MvcController>
                 .Instance()
@@ -28,7 +28,7 @@ public void ShouldReturnBadRequestShouldNotThrowExceptionWhenResultIsBadRequestE
         }
 
         [Fact]
-        public void ShouldReturnNotFoundShouldThrowExceptionWhenActionDoesNotReturnNotFound()
+        public void ShouldReturnBadRequestShouldThrowExceptionWhenActionDoesNotReturnBadRequest()
         {
             Test.AssertException<InvocationResultAssertionException>(
                 () =>

test/MyTested.AspNetCore.Mvc.Test.Setups/Controllers/MvcController.cs

@@ -505,7 +505,7 @@ public IActionResult SignOutWithAuthenticationProperties()
             return this.SignOut(TestObjectFactory.GetAuthenticationProperties());
         }
 
-        public FileResult FileWithVirtualPath()
+        public IActionResult FileWithVirtualPath()
         {
             return this.File("/Test", ContentType.ApplicationJson, "FileDownloadName");
         }
@@ -702,7 +702,7 @@ public IActionResult ActionWithAggregateException()
 
         public async Task EmptyActionWithExceptionAsync()
         {
-            await Task.Run(() => this.ThrowNewNullReferenceException());
+            await Task.Run(this.ThrowNewNullReferenceException);
         }
 
         public async Task<IActionResult> ActionWithExceptionAsync()
@@ -1247,6 +1247,16 @@ public IActionResult WithService(IHttpContextAccessor httpContextAccessor)
             return this.Ok();
         }
 
+        public IActionResult ActionResultInterface()
+        {
+            return this.Ok();
+        }
+
+        public ActionResult ActionResultBaseClass()
+        {
+            return this.Ok();
+        }
+
         public ActionResult<ResponseModel> ActionResultOfT(int id)
         {
             if (id == 0)