Added generic version of the ShouldPassFor (#181)

Author: ivaylokenov

src/MyTested.AspNetCore.Mvc.Abstractions/Builders/And/AndTestBuilder.cs

@@ -0,0 +1,21 @@
+namespace MyTested.AspNetCore.Mvc.Builders.And
+{
+    using Base;
+    using Contracts.And;
+    using Contracts.Base;
+    using Internal.TestContexts;
+
+    /// <summary>
+    /// AndAlso method for better readability when chaining should pass for tests.
+    /// </summary>
+    public class AndTestBuilder : BaseTestBuilderWithComponent, IAndTestBuilder
+    {
+        public AndTestBuilder(ComponentTestContext testContext)
+            : base(testContext)
+        {
+        }
+
+        /// <inheritdoc />
+        public IBaseTestBuilderWithComponent AndAlso() => this;
+    }
+}

src/MyTested.AspNetCore.Mvc.Abstractions/Builders/Base/BaseTestBuilder.cs

@@ -6,6 +6,8 @@
     using Licensing;
     using Microsoft.AspNetCore.Http;
     using ShouldPassFor;
+    using System;
+    using System.Reflection;
     using Utilities.Validators;
 
     /// <summary>

src/MyTested.AspNetCore.Mvc.Abstractions/Builders/Base/BaseTestBuilderWithComponent.cs

@@ -1,10 +1,14 @@
 namespace MyTested.AspNetCore.Mvc.Builders.Base
 {
     using System;
-    using System.Collections.Generic;
+    using Contracts.And;
     using Contracts.Base;
+    using Exceptions;
+    using Internal;
     using Internal.TestContexts;
+    using Utilities;
     using Utilities.Validators;
+    using And;
 
     /// <summary>
     /// Base class for all test builders with component.
@@ -22,7 +26,7 @@ protected BaseTestBuilderWithComponent(ComponentTestContext testContext)
         {
             this.TestContext = testContext;
         }
-        
+
         /// <summary>
         /// Gets the currently used <see cref="ComponentTestContext"/>.
         /// </summary>
@@ -40,5 +44,25 @@ private set
                 this.testContext = value;
             }
         }
+
+        /// <inheritdoc />
+        public IAndTestBuilder ShouldPassForThe<TComponent>(Action<TComponent> assertions)
+            where TComponent : class
+        {
+            assertions(TestHelper.TryGetShouldPassForValue<TComponent>(this.TestContext));
+            return new AndTestBuilder(this.TestContext);
+        }
+
+        /// <inheritdoc />
+        public IAndTestBuilder ShouldPassForThe<TComponent>(Func<TComponent, bool> predicate)
+            where TComponent : class
+        {
+            if (!predicate(TestHelper.TryGetShouldPassForValue<TComponent>(this.TestContext)))
+            {
+                throw new InvalidAssertionException($"Expected {typeof(TComponent).ToFriendlyTypeName()} to pass the given predicate but it failed.");
+            }
+
+            return new AndTestBuilder(this.TestContext);
+        }
     }
 }

src/MyTested.AspNetCore.Mvc.Abstractions/Builders/Contracts/And/IAndTestBuilder.cs

@@ -0,0 +1,16 @@
+namespace MyTested.AspNetCore.Mvc.Builders.Contracts.And
+{
+    using Base;
+
+    /// <summary>
+    /// Used for adding 'AndAlso' method to <see cref="IBaseTestBuilderWithComponent"/>.
+    /// </summary>
+    public interface IAndTestBuilder : IBaseTestBuilderWithComponent
+    {
+        /// <summary>
+        /// AndAlso method for better readability when chaining should pass for tests.
+        /// </summary>
+        /// <returns>The same <see cref="IBaseTestBuilderWithComponent"/>.</returns>
+        IBaseTestBuilderWithComponent AndAlso();
+    }
+}

src/MyTested.AspNetCore.Mvc.Abstractions/Builders/Contracts/Base/IBaseTestBuilderWithComponent.cs

@@ -1,9 +1,29 @@
 namespace MyTested.AspNetCore.Mvc.Builders.Contracts.Base
 {
+    using System;
+    using And;
+
     /// <summary>
     /// Base class for all test builders with component.
     /// </summary>
     public interface IBaseTestBuilderWithComponent : IBaseTestBuilder
     {
+        /// <summary>
+        /// Tests whether the provided component type passes the given assertions.
+        /// </summary>
+        /// <typeparam name="TComponent">Type of component to test.</typeparam>
+        /// <param name="assertions">Action containing assertions on the provided component.</param>
+        /// <returns>The same <see cref="IBaseTestBuilderWithComponent"/>.</returns>
+        IAndTestBuilder ShouldPassForThe<TComponent>(Action<TComponent> assertions)
+            where TComponent : class;
+
+        /// <summary>
+        /// Tests whether the provided component passes the given predicate.
+        /// </summary>
+        /// <typeparam name="TComponent">Type of component to test.</typeparam>
+        /// <param name="predicate">Predicate testing the provided component.</param>
+        /// <returns>The same <see cref="IBaseTestBuilderWithComponent"/>.</returns>
+        IAndTestBuilder ShouldPassForThe<TComponent>(Func<TComponent, bool> predicate)
+            where TComponent : class;
     }
 }

src/MyTested.AspNetCore.Mvc.Abstractions/Builders/Contracts/Base/IBaseTestBuilderWithComponentBuilder.cs

@@ -1,6 +1,6 @@
 namespace MyTested.AspNetCore.Mvc.Builders.Contracts.Base
 {
-    public interface IBaseTestBuilderWithComponentBuilder<TBuilder> : IBaseTestBuilder
+    public interface IBaseTestBuilderWithComponentBuilder<TBuilder> : IBaseTestBuilderWithComponent
         where TBuilder : IBaseTestBuilder
     {
     }

src/MyTested.AspNetCore.Mvc.Abstractions/Internal/Application/TestApplication.cs

@@ -29,7 +29,7 @@
     public static class TestApplication
     {
         private const string TestFrameworkName = "MyTested.AspNetCore.Mvc";
-        private const string ReleaseDate = "2016-06-01";
+        private const string ReleaseDate = "2016-09-01";
 
         private static readonly RequestDelegate NullHandler;
 
@@ -227,6 +227,12 @@ internal static void LoadPlugins()
                     {
                         TestHelper.HttpFeatureRegistrationPlugins.Add(httpFeatureRegistrationPlugin);
                     }
+
+                    var shouldPassForPlugin = plugin as IShouldPassForPlugin;
+                    if (shouldPassForPlugin != null)
+                    {
+                        TestHelper.ShouldPassForPlugins.Add(shouldPassForPlugin);
+                    }
                 });
         }
 

src/MyTested.AspNetCore.Mvc.Abstractions/Internal/TestHelper.cs

@@ -7,13 +7,18 @@
     using Microsoft.AspNetCore.Http.Features;
     using Plugins;
     using Services;
+    using TestContexts;
+    using Utilities;
 
     public static class TestHelper
     {
         public static Action GlobalTestCleanup { get; set; }
 
         public static ISet<IHttpFeatureRegistrationPlugin> HttpFeatureRegistrationPlugins { get; }
             = new HashSet<IHttpFeatureRegistrationPlugin>();
+
+        public static ISet<IShouldPassForPlugin> ShouldPassForPlugins { get; }
+            = new HashSet<IShouldPassForPlugin>();
 
         public static MockedHttpContext CreateMockedHttpContext()
         {
@@ -44,6 +49,21 @@ public static void SetHttpContextToAccessor(HttpContext httpContext)
             }
         }
 
+        public static TComponent TryGetShouldPassForValue<TComponent>(ComponentTestContext testContext)
+            where TComponent : class
+        {
+            foreach (var shouldPassForPlugin in ShouldPassForPlugins)
+            {
+                var result = shouldPassForPlugin.TryGetValue(typeof(TComponent), testContext) as TComponent;
+                if (result != null)
+                {
+                    return result;
+                }
+            }
+
+            throw new InvalidOperationException($"{typeof(TComponent).ToFriendlyTypeName()} could not be resolved for the 'ShouldPassForThe<TComponent>' method call.");
+        }
+
         public static void ExecuteTestCleanup() => GlobalTestCleanup?.Invoke();
     }
 }

src/MyTested.AspNetCore.Mvc.Abstractions/Plugins/AbstractionsTestPlugin.cs

@@ -2,14 +2,35 @@
 {
     using System;
     using Internal.Contracts;
+    using Internal.TestContexts;
     using Microsoft.Extensions.DependencyInjection;
+    using Utilities;
+    using Microsoft.AspNetCore.Http;
 
-    public class AbstractionsTestPlugin : BaseTestPlugin, IServiceRegistrationPlugin, IInitializationPlugin
+    public class AbstractionsTestPlugin : BaseTestPlugin, IServiceRegistrationPlugin, IInitializationPlugin, IShouldPassForPlugin
     {
+        private readonly Type baseHttpContextType = typeof(HttpContext);
+        private readonly Type baseHttpRequestType = typeof(HttpRequest);
+
         public Action<IServiceCollection> ServiceRegistrationDelegate =>
             serviceCollection => serviceCollection.AddCoreTesting();
 
         // this call prepares all application conventions and fills the controller action descriptor cache
         public Action<IServiceProvider> InitializationDelegate => serviceProvider => serviceProvider.GetService<IControllerActionDescriptorCache>();
+
+        public object TryGetValue(Type type, ComponentTestContext testContext)
+        {
+            if (Reflection.AreAssignable(baseHttpContextType, type))
+            {
+                return testContext.HttpContext;
+            }
+
+            if (Reflection.AreAssignable(baseHttpRequestType, type))
+            {
+                return testContext.HttpRequest;
+            }
+
+            return null;
+        }
     }
 }

src/MyTested.AspNetCore.Mvc.Abstractions/Plugins/IShouldPassForPlugin.cs

@@ -0,0 +1,10 @@
+namespace MyTested.AspNetCore.Mvc.Plugins
+{
+    using System;
+    using Internal.TestContexts;
+
+    public interface IShouldPassForPlugin
+    {
+        object TryGetValue(Type type, ComponentTestContext testContext);
+    }
+}