Fixed bug in pipeline testing where the HttpContext setup was not passed from the route to the controller (#282)

Author: ivaylokenov

src/MyTested.AspNetCore.Mvc.Abstractions/Internal/TestContexts/HttpTestContext.cs

@@ -11,27 +11,28 @@
 
     public abstract class HttpTestContext
     {
-        private HttpContextMock httpContextMock;
         private RouteData routeData;
 
         protected HttpTestContext()
         {
             TestHelper.ExecuteTestCleanup();
-            this.httpContextMock = TestHelper.CreateHttpContextMock();
+            this.HttpContextMock = TestHelper.CreateHttpContextMock();
         }
 
         public HttpContext HttpContext
         {
-            get => this.httpContextMock;
+            get => this.HttpContextMock;
 
             set
             {
                 CommonValidator.CheckForNullReference(value, nameof(this.HttpContext));
-                this.httpContextMock = HttpContextMock.From(value);
-                TestHelper.SetHttpContextToAccessor(this.httpContextMock);
+                this.HttpContextMock = HttpContextMock.From(value);
+                TestHelper.SetHttpContextToAccessor(this.HttpContextMock);
             }
         }
 
+        public HttpContextMock HttpContextMock { get; private set; }
+
         public HttpRequest HttpRequest => this.HttpContext.Request;
 
         public HttpResponse HttpResponse => this.HttpContext.Response;
@@ -64,7 +65,5 @@ public virtual RouteData RouteData
         public ISession Session => this.HttpContext.Session;
 
         public abstract string ExceptionMessagePrefix { get; }
-
-        public HttpContextMock HttpContextMock => this.httpContextMock;
     }
 }

src/MyTested.AspNetCore.Mvc.Pipeline/ControllerRouteTestBuilderPipelineExtensions.cs

@@ -39,10 +39,13 @@ public static IActionResultTestBuilder<MethodResult> Which<TController>(
         {
             var actualBuilder = (ControllerRouteTestBuilder<TController>)builder;
 
+            var routeContext = actualBuilder.RouteContext;
             var actionCall = actualBuilder.ActionCallExpression;
 
             var whichControllerInstanceBuilder = new WhichControllerInstanceBuilder<TController>(new ControllerTestContext
             {
+                HttpContext = routeContext.HttpContext,
+                RouteData = routeContext.RouteData,
                 ComponentConstructionDelegate = () => null,
                 MethodCall = actionCall
             });

src/MyTested.AspNetCore.Mvc.Routing/Builders/Routing/ShouldMapTestBuilder.cs

@@ -43,7 +43,7 @@ protected ShouldMapTestBuilder(
             : this(testContext)
             => this.actionCallExpression = actionCallExpression;
 
-        private RouteContext RouteContext => this.TestContext.RouteContext;
+        public RouteContext RouteContext => this.TestContext.RouteContext;
 
         /// <inheritdoc />
         public IAndResolvedRouteTestBuilder ToAction(string actionName)

src/MyTested.AspNetCore.Mvc.Routing/Internal/TestContexts/RouteTestContext.cs

@@ -8,10 +8,7 @@ public class RouteTestContext : HttpTestContext
     {
         private RouteContext routeContext;
 
-        public RouteTestContext()
-        {
-            this.SetAuthentication();
-        }
+        public RouteTestContext() => this.SetAuthentication();
 
         public IRouter Router { get; internal set; }