Removed controller type validation for .NET 4.5.1 (#168)

Author: ivaylokenov

samples/MusicStore/MusicStore.Test/TestStartup.cs

@@ -27,6 +27,7 @@ public void ConfigureTestServices(IServiceCollection services)
             services.ReplaceSingleton<SignInManager<ApplicationUser>, MockedSignInManager>();
 
             // temporary workaround while DependencyContext issues are fixed for .NET 4.5.1
+            // controller type validation is also removed for .NET 4.5.1
 #if NET451
             var mvc = services.AddMvc();
             var applicationParts = mvc.PartManager.ApplicationParts;
@@ -35,11 +36,15 @@ public void ConfigureTestServices(IServiceCollection services)
 
             TestHelper.HttpFeatureRegistrationPlugins.Add(new SessionTestPlugin());
 
-            services.ReplaceDbContext();
-            services.ReplaceMemoryCache();
-            services.ReplaceSession();
-            services.ReplaceOptions();
-            services.ReplaceTempDataProvider();
+            services
+                .AddCoreTesting()
+                .AddControllersTesting()
+                .AddRoutingTesting()
+                .ReplaceDbContext()
+                .ReplaceMemoryCache()
+                .ReplaceSession()
+                .ReplaceOptions()
+                .ReplaceTempDataProvider();
 #endif
         }
     }

src/MyTested.AspNetCore.Mvc.Abstractions/Internal/Application/TestApplication.cs

@@ -166,10 +166,10 @@ public static TestConfiguration TestConfiguration
             TestConfiguration.ApplicationName
                 ?? TestAssemblyName
                 ?? PlatformServices.Default.Application.ApplicationName;
-        
+
         public static void TryInitialize()
         {
-            lock(Sync)
+            lock (Sync)
             {
                 if (!initialiazed && TestConfiguration.AutomaticStartup)
                 {
@@ -231,7 +231,7 @@ internal static void LoadPlugins()
         internal static Type TryFindDefaultStartupType()
         {
             var applicationAssembly = Assembly.Load(new AssemblyName(testAssemblyName));
-            
+
             var startupName = TestConfiguration.FullStartupName ?? $"{Environment.EnvironmentName}Startup";
 
             // check root of the test project
@@ -312,7 +312,7 @@ private static IServiceCollection GetInitialServiceCollection()
             serviceCollection.AddTransient<IStartupFilter, AutoRequestServicesStartupFilter>();
 
             serviceCollection.AddSingleton<ObjectPoolProvider, DefaultObjectPoolProvider>();
-            
+
             return serviceCollection;
         }
 
@@ -362,7 +362,7 @@ private static void PrepareServices(IServiceCollection serviceCollection, Startu
             }
 
             AdditionalServices?.Invoke(serviceCollection);
-            
+
             TryReplaceKnownServices(serviceCollection);
             PrepareRoutingServices(serviceCollection);
 
@@ -409,7 +409,7 @@ private static void PrepareRoutingServices(IServiceCollection serviceCollection)
         private static void PrepareApplicationAndRouting(StartupMethods startupMethods)
         {
             var applicationBuilder = new MockedApplicationBuilder(serviceProvider);
-            
+
             startupMethods?.ConfigureDelegate?.Invoke(applicationBuilder);
 
             AdditionalApplicationConfiguration?.Invoke(applicationBuilder);
@@ -438,7 +438,7 @@ private static void PrepareApplicationAndRouting(StartupMethods startupMethods)
 
             router = routeBuilder.Build();
         }
-        
+
         private static void TryLockedInitialization()
         {
             if (!initialiazed)

src/MyTested.AspNetCore.Mvc.Controllers/Builders/Controllers/ControllerBuilder.cs

@@ -38,7 +38,9 @@ public ControllerBuilder(ControllerTestContext testContext)
 
             this.EnabledValidation = TestApplication.TestConfiguration.ModelStateValidation;
 
+#if NETSTANDARD1_6
             this.ValidateControllerType();
+#endif
         }
 
         private TController Controller