Fixed failing unit tests after the merge (#353)

ivaylokenov · ivaylokenov · commit 72137561ba0c · 2019-12-12T22:03:27.000+02:00
diff --git a/src/MyTested.AspNetCore.Mvc.Abstractions/Builders/CaughtExceptions/ExceptionTestBuilder.cs b/src/MyTested.AspNetCore.Mvc.Abstractions/Builders/CaughtExceptions/ExceptionTestBuilder.cs
@@ -29,7 +29,7 @@ public IAndExceptionTestBuilder OfType(Type exceptionType)
             if (Reflection.AreDifferentTypes(exceptionType, actualExceptionType))
             {
                 var (expectedExceptionName, actualExceptionName) =
-                    (expectedExceptionType, actualExceptionType).GetTypeComparisonNames();
+                    (exceptionType, actualExceptionType).GetTypeComparisonNames();
 
                 throw new InvalidExceptionAssertionException(string.Format(
                     "{0} {1}, but instead received {2}.",
diff --git a/src/MyTested.AspNetCore.Mvc.Abstractions/Internal/Application/TestApplicationServices.cs b/src/MyTested.AspNetCore.Mvc.Abstractions/Internal/Application/TestApplicationServices.cs
@@ -8,7 +8,6 @@
     using Services;
     using System;
     using System.Collections.Generic;
-    using System.IO;
     using System.Linq;
     using System.Reflection;
     using Utilities.Extensions;
diff --git a/src/MyTested.AspNetCore.Mvc.Abstractions/Utilities/Validators/DictionaryValidator.cs b/src/MyTested.AspNetCore.Mvc.Abstractions/Utilities/Validators/DictionaryValidator.cs
@@ -46,10 +46,8 @@ public static void ValidateStringKeyAndValue(
         public static void ValidateValueOfType<TValue>(
             string name,
             IDictionary<string, object> dictionary,
-            Action<string, string, string> failedValidationAction)
-        {
-            ValidateValueOfType<TValue>(name, dictionary.Values, failedValidationAction);
-        }
+            Action<string, string, string> failedValidationAction) 
+            => ValidateValueOfType<TValue>(name, dictionary.Values, failedValidationAction);
 
         public static void ValidateValueOfType(
             string name,
@@ -67,21 +65,22 @@ public static void ValidateValueOfType(
            string name,
            IDictionary<object, object> dictionary,
            Action<string, string, string> failedValidationAction,
-           Type valueType)
-            => ValidateValueOfType(name, dictionary.Values, failedValidationAction, valueType);
+           Type expectedType)
+            => ValidateValueOfType(name, dictionary.Values, failedValidationAction, expectedType);
         
         public static void ValidateStringKeyAndValueOfType(
             string name,
             IDictionary<string, object> dictionary,
             string key,
             Action<string, string, string> failedValidationAction,
-            Type valueType)
+            Type expectedType)
         {
             var entryExists = dictionary.ContainsKey(key);
-            var actualValue = entryExists ? dictionary[key] : null;
 
+            var actualValue = entryExists ? dictionary[key] : null;
             var actualType = actualValue?.GetType();
-            if (!entryExists || Reflection.AreDifferentTypes(valueType, actualType))
+
+            if (!entryExists || Reflection.AreDifferentTypes(expectedType, actualType))
             {
                 var (expectedTypeName, actualTypeName) = (expectedType, actualType).GetTypeComparisonNames();
 
@@ -148,15 +147,15 @@ private static void ValidateValueOfType(
           string name,
           ICollection<object> values,
           Action<string, string, string> failedValidationAction,
-          Type valueType)
+          Type expectedType)
         {
-            var entryOfSameType = values.FirstOrDefault(arg => arg.GetType() == valueType);
+            var entryOfSameType = values.FirstOrDefault(arg => arg.GetType() == expectedType);
 
             if (entryOfSameType == null)
             {
                 failedValidationAction(
                     name,
-                    $"to have at least one entry of {valueType.ToFriendlyTypeName()} type",
+                    $"to have at least one entry of {expectedType.ToFriendlyTypeName()} type",
                     "none was found");
             }
         }
diff --git a/src/MyTested.AspNetCore.Mvc.Caching/Builders/Data/MemoryCache/MemoryCacheTestBuilder.cs b/src/MyTested.AspNetCore.Mvc.Caching/Builders/Data/MemoryCache/MemoryCacheTestBuilder.cs
@@ -69,12 +69,12 @@ public IAndMemoryCacheTestBuilder ContainingEntryOfType<TValue>()
             => this.ContainingEntryOfType(typeof(TValue));
 
         /// <inheritdoc />
-        public IAndMemoryCacheTestBuilder ContainingEntryOfType(object key, Type valueType)
+        public IAndMemoryCacheTestBuilder ContainingEntryOfType(object key, Type expectedType)
         {
             var value = this.GetValue(key);
             var actualType = value.GetType();
 
-            if (Reflection.AreDifferentTypes(valueType, actualType))
+            if (Reflection.AreDifferentTypes(expectedType, actualType))
             {
                 var (expectedTypeName, actualTypeName) = (expectedType, actualType).GetTypeComparisonNames();
 
diff --git a/src/MyTested.AspNetCore.Mvc.ViewComponents.Results/ViewTestBuilderViewComponentsExtensions.cs b/src/MyTested.AspNetCore.Mvc.ViewComponents.Results/ViewTestBuilderViewComponentsExtensions.cs
@@ -103,7 +103,8 @@ public static IAndViewTestBuilder WithViewEngineOfType<TViewEngine>(
         /// <param name="viewEngineType"></param>
         /// <returns>The same <see cref="IAndViewTestBuilder"/>.</returns>
         public static IAndViewTestBuilder WithViewEngineOfType(
-            this IViewTestBuilder viewTestBuilder,Type viewEngineType)
+            this IViewTestBuilder viewTestBuilder, 
+            Type viewEngineType)
         {
             var actualBuilder = GetActualBuilder(viewTestBuilder);
 
@@ -113,7 +114,7 @@ public static IAndViewTestBuilder WithViewEngineOfType(
                 || Reflection.AreDifferentTypes(viewEngineType, actualViewEngineType))
             {
                 var (expectedViewEngineTypeName, actualViewEngineTypeName) = 
-                    (expectedViewEngineType, actualViewEngineType).GetTypeComparisonNames();
+                    (viewEngineType, actualViewEngineType).GetTypeComparisonNames();
 
                 throw ViewViewComponentResultAssertionException.ForViewEngineType(
                     actualBuilder.TestContext.ExceptionMessagePrefix,
diff --git a/test/MyTested.AspNetCore.Mvc.Controllers.Test/PluginsTests/ControllersTestPluginTest.cs b/test/MyTested.AspNetCore.Mvc.Controllers.Test/PluginsTests/ControllersTestPluginTest.cs
@@ -1,7 +1,7 @@
 ﻿namespace MyTested.AspNetCore.Mvc.Test.PluginsTests
 {
     using System;
-    using Microsoft.AspNetCore.Mvc.Internal;
+    using Microsoft.AspNetCore.Mvc.Controllers;
     using Microsoft.Extensions.DependencyInjection;
     using Microsoft.Extensions.Options;
     using Plugins;
@@ -36,10 +36,7 @@ public void ShouldInvokeMethodOfTypeVoidWithValidServiceCollectionForDefaultRegi
 
             testPlugin.DefaultServiceRegistrationDelegate(serviceCollection);
 
-            var methodReturnType = testPlugin.DefaultServiceRegistrationDelegate.Method.ReturnType.Name;
-
-            Assert.True(methodReturnType == "Void");
-            Assert.Contains(serviceCollection, s => s.ServiceType == typeof(MiddlewareFilterBuilder));
+            Assert.Contains(serviceCollection, s => s.ServiceType == typeof(IControllerFactory));
         }
 
         [Fact]
@@ -50,9 +47,6 @@ public void ShouldInvokeMethodOfTypeVoidWithValidServiceCollection()
 
             testPlugin.ServiceRegistrationDelegate(serviceCollection);
 
-            var methodReturnType = testPlugin.ServiceRegistrationDelegate.Method.ReturnType.Name;
-           
-            Assert.True(methodReturnType == "Void");
             Assert.Contains(serviceCollection, s => s.ServiceType == typeof(IOptions<>));
         }
     }
diff --git a/test/MyTested.AspNetCore.Mvc.Controllers.Views.Test/PluginTests/ViewActionResultTestPluginTest.cs b/test/MyTested.AspNetCore.Mvc.Controllers.Views.Test/PluginTests/ViewActionResultTestPluginTest.cs
@@ -1,7 +1,7 @@
 ﻿namespace MyTested.AspNetCore.Mvc.Test.PluginTests
 { 
     using System;
-    using Microsoft.AspNetCore.Mvc.Formatters.Json.Internal;
+    using Microsoft.AspNetCore.Mvc.Controllers;
     using Microsoft.Extensions.DependencyInjection;
     using Plugins;
     using Xunit;
@@ -34,10 +34,7 @@ public void ShouldInvokeMethodOfTypeVoidWithValidServiceCollection()
 
             testPlugin.DefaultServiceRegistrationDelegate(serviceCollection);
 
-            var methodReturnType = testPlugin.DefaultServiceRegistrationDelegate.Method.ReturnType.Name;
-
-            Assert.True(methodReturnType == "Void");
-            Assert.Contains(serviceCollection, s => s.ServiceType == typeof(JsonResultExecutor));
+            Assert.Contains(serviceCollection, s => s.ServiceType == typeof(IControllerFactory));
         }
     }
 }
diff --git a/test/MyTested.AspNetCore.Mvc.EntityFrameworkCore.Test/BuildersTests/ControllersTests/ControllerBuilderTests.cs b/test/MyTested.AspNetCore.Mvc.EntityFrameworkCore.Test/BuildersTests/ControllersTests/ControllerBuilderTests.cs
@@ -490,26 +490,28 @@ public void WithoutDataDeletingWholeDatabaseReturnsCorrectData()
         [Fact]
         public void WithoutDataThrowsExceptionWhenNullIsProvided()
         {
-            Test.AssertException<ArgumentNullException>(() =>
-            {
-                MyApplication
-                .StartsFrom<TestStartup>()
-                .WithServices(services => services.AddDbContext<CustomDbContext>());
-
-                var model = new CustomModel
+            Test.AssertException<ArgumentNullException>(
+                () =>
                 {
-                    Id = 1,
-                    Name = "Test"
-                };
-
-                MyController<DbContextController>
-                    .Instance()
-                    .WithData(model)
-                    .WithoutData(default(List<object>))
-                    .Calling(c => c.Get(model.Id))
-                    .ShouldReturn()
-                    .NotFound();
-            }, "Value cannot be null.\r\nParameter name: entities");
+                    MyApplication
+                    .StartsFrom<TestStartup>()
+                    .WithServices(services => services.AddDbContext<CustomDbContext>());
+
+                    var model = new CustomModel
+                    {
+                        Id = 1,
+                        Name = "Test"
+                    };
+
+                    MyController<DbContextController>
+                        .Instance()
+                        .WithData(model)
+                        .WithoutData(default(List<object>))
+                        .Calling(c => c.Get(model.Id))
+                        .ShouldReturn()
+                        .NotFound();
+                }, 
+                "Value cannot be null. (Parameter 'entities')");
         }
 
         [Fact]
@@ -581,7 +583,7 @@ public void WithoutDataWithProvidedOnlyPartialDataForDeletionReturnsCorrectResul
                 .ShouldReturn()
                 .Ok(ok => ok
                     .WithModelOfType<List<CustomModel>>()
-                    .Passing(mdls => mdls.Count == 1));
+                    .Passing(model => model.Count == 1));
         }
 
         [Fact]
diff --git a/test/MyTested.AspNetCore.Mvc.Http.Test/PluginsTests/HttpTestPluginTest.cs b/test/MyTested.AspNetCore.Mvc.Http.Test/PluginsTests/HttpTestPluginTest.cs
@@ -1,7 +1,8 @@
-﻿namespace MyTested.AspNetCore.Mvc.Test.PluginsTests
+﻿using Microsoft.AspNetCore.Mvc.Controllers;
+
+namespace MyTested.AspNetCore.Mvc.Test.PluginsTests
 {  
     using System;
-    using Microsoft.AspNetCore.Mvc.Formatters.Json.Internal;
     using Microsoft.Extensions.DependencyInjection;
     using Microsoft.Extensions.Options;
     using Plugins;
@@ -36,10 +37,7 @@ public void ShouldInvokeMethodOfTypeVoidWithValidServiceCollectionForDefaultRegi
 
             testPlugin.DefaultServiceRegistrationDelegate(serviceCollection);
 
-            var methodReturnType = testPlugin.DefaultServiceRegistrationDelegate.Method.ReturnType.Name;
-           
-            Assert.True(methodReturnType == "Void");
-            Assert.Contains(serviceCollection, s => s.ServiceType == typeof(JsonResultExecutor));
+            Assert.Contains(serviceCollection, s => s.ServiceType == typeof(IControllerFactory));
         }
 
         [Fact]
@@ -50,11 +48,7 @@ public void ShouldInvokeMethodOfTypeVoidWithValidServiceCollection()
 
             testPlugin.ServiceRegistrationDelegate(serviceCollection);
 
-            var methodReturnType = testPlugin.ServiceRegistrationDelegate.Method.ReturnType.Name;
-
-            Assert.True(methodReturnType == "Void");
             Assert.Contains(serviceCollection, s => s.ServiceType == typeof(IOptions<>));
-
         }
     }
 }
diff --git a/test/MyTested.AspNetCore.Mvc.Routing.Test/PluginsTests/RoutingTestPluginTest.cs b/test/MyTested.AspNetCore.Mvc.Routing.Test/PluginsTests/RoutingTestPluginTest.cs
@@ -1,9 +1,9 @@
 ﻿namespace MyTested.AspNetCore.Mvc.Test.PluginsTests
 {
     using System;
-    using Microsoft.AspNetCore.Mvc.Formatters.Json.Internal;
+    using Internal.Contracts;
+    using Microsoft.AspNetCore.Mvc.Controllers;
     using Microsoft.Extensions.DependencyInjection;
-    using MyTested.AspNetCore.Mvc.Internal.Contracts;
     using Plugins;
     using Xunit;
 
@@ -36,10 +36,7 @@ public void ShouldInvokeMethodOfTypeVoidWithValidServiceCollectionForDefaultRegi
 
             testPlugin.DefaultServiceRegistrationDelegate(serviceCollection);
 
-            var methodReturnType = testPlugin.DefaultServiceRegistrationDelegate.Method.ReturnType.Name;
-
-            Assert.True(methodReturnType == "Void");
-            Assert.Contains(serviceCollection, s => s.ServiceType == typeof(JsonResultExecutor));
+            Assert.Contains(serviceCollection, s => s.ServiceType == typeof(IControllerFactory));
         }
 
         [Fact]
@@ -50,9 +47,6 @@ public void ShouldInvokeMethodOfTypeVoidWithValidServiceCollection()
 
             testPlugin.RoutingServiceRegistrationDelegate(serviceCollection);
 
-            var methodReturnType = testPlugin.RoutingServiceRegistrationDelegate.Method.ReturnType.Name;
-
-            Assert.True(methodReturnType == "Void");
             Assert.Contains(serviceCollection, s => s.ServiceType == typeof(IRoutingServices));
         }
     }
diff --git a/test/MyTested.AspNetCore.Mvc.TempData.Test/PluginsTests/TempDataTestPluginTest.cs b/test/MyTested.AspNetCore.Mvc.TempData.Test/PluginsTests/TempDataTestPluginTest.cs
@@ -1,7 +1,7 @@
 ﻿namespace MyTested.AspNetCore.Mvc.Test.PluginsTests
 {  
     using System;
-    using Microsoft.AspNetCore.Mvc.Formatters.Json.Internal;
+    using Microsoft.AspNetCore.Mvc.Controllers;
     using Microsoft.AspNetCore.Mvc.ViewFeatures;
     using Microsoft.Extensions.DependencyInjection;
     using Plugins;
@@ -36,10 +36,7 @@ public void ShouldInvokeMethodOfTypeVoidWithValidServiceCollectionForDefaultRegi
 
             testPlugin.DefaultServiceRegistrationDelegate(serviceCollection);
 
-            var methodReturnType = testPlugin.DefaultServiceRegistrationDelegate.Method.ReturnType.Name;
-
-            Assert.True(methodReturnType == "Void");
-            Assert.Contains(serviceCollection, s => s.ServiceType == typeof(JsonResultExecutor));
+            Assert.Contains(serviceCollection, s => s.ServiceType == typeof(IControllerFactory));
         }
 
         [Fact]
@@ -50,9 +47,6 @@ public void ShouldInvokeMethodOfTypeVoidWithValidServiceCollection()
 
             testPlugin.ServiceRegistrationDelegate(serviceCollection);
 
-            var methodReturnType = testPlugin.ServiceRegistrationDelegate.Method.ReturnType.Name;
-
-            Assert.True(methodReturnType == "Void");
             Assert.Contains(serviceCollection, s => s.ServiceType == typeof(ITempDataProvider));
         }
     }
diff --git a/test/MyTested.AspNetCore.Mvc.Universe.Test/MyTested.AspNetCore.Mvc.Universe.Test.csproj b/test/MyTested.AspNetCore.Mvc.Universe.Test/MyTested.AspNetCore.Mvc.Universe.Test.csproj
@@ -32,7 +32,7 @@
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
     <PackageReference Include="xunit" Version="2.4.1" />
-    <PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="2.2.6" />
+    <PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="3.1.0" />
   </ItemGroup>
 
 </Project>
diff --git a/test/MyTested.AspNetCore.Mvc.Universe.Test/ServicesTests.cs b/test/MyTested.AspNetCore.Mvc.Universe.Test/ServicesTests.cs
@@ -198,19 +198,16 @@ public void AddMvcUniverseTestingShouldAddStringInputFormatter()
             builtInOptions.Value.InputFormatters.RemoveType<StringInputFormatter>();
 
             Assert.NotNull(builtInOptions);
-            Assert.True(builtInOptions.Value.InputFormatters.Count == 2);
+            Assert.True(builtInOptions.Value.InputFormatters.Count == 1);
             Assert.DoesNotContain(typeof(StringInputFormatter), builtInOptions.Value.InputFormatters.Select(f => f.GetType()));
 
             MyApplication.StartsFrom<TestStartup>()
-                .WithServices(services =>
-                {
-                    services.AddMvcUniverseTesting();
-                });
+                .WithServices(services => services.AddMvcUniverseTesting());
 
             builtInOptions = TestServiceProvider.GetService<IOptions<MvcOptions>>();
 
             Assert.NotNull(builtInOptions);
-            Assert.True(builtInOptions.Value.InputFormatters.Count == 3);
+            Assert.True(builtInOptions.Value.InputFormatters.Count == 2);
             Assert.Contains(typeof(StringInputFormatter), builtInOptions.Value.InputFormatters.Select(f => f.GetType()));
         }
 
@@ -233,7 +230,7 @@ public void AddMvcUniverseTestingWithStringInputFormatterShouldNotOverrideIt()
             var builtInOptions = TestServiceProvider.GetService<IOptions<MvcOptions>>();
 
             Assert.NotNull(builtInOptions);
-            Assert.True(builtInOptions.Value.InputFormatters.Count == 3);
+            Assert.True(builtInOptions.Value.InputFormatters.Count == 2);
             Assert.Contains(typeof(StringInputFormatter), builtInOptions.Value.InputFormatters.Select(f => f.GetType()));
             Assert.Same(inputFormatter, builtInOptions.Value.InputFormatters.FirstOrDefault(f => f.GetType() == typeof(StringInputFormatter)));
         }
@@ -409,7 +406,7 @@ public void AddMvcUniverseTestingShouldAddRoutingTestingServicesAndDisableEndPoi
 
             var mvcOptions = TestServiceProvider.GetService<IOptions<MvcOptions>>();
 
-            Assert.False(mvcOptions.Value.EnableEndpointRouting);
+            Assert.True(mvcOptions.Value.EnableEndpointRouting);
         }
 
         [Fact]
diff --git a/test/MyTested.AspNetCore.Mvc.ViewComponents.Results.Test/BuildersTests/ViewComponentResultTests/ViewTestBuilderTests.cs b/test/MyTested.AspNetCore.Mvc.ViewComponents.Results.Test/BuildersTests/ViewComponentResultTests/ViewTestBuilderTests.cs
diff --git a/test/MyTested.AspNetCore.Mvc.ViewComponents.Test/BuildersTests/ViewComponentResultTests/ViewTestBuilderTests.cs b/test/MyTested.AspNetCore.Mvc.ViewComponents.Test/BuildersTests/ViewComponentResultTests/ViewTestBuilderTests.cs
diff --git a/test/MyTested.AspNetCore.Mvc.ViewComponents.Test/PluginsTests/ViewComponentsTestPluginTest.cs b/test/MyTested.AspNetCore.Mvc.ViewComponents.Test/PluginsTests/ViewComponentsTestPluginTest.cs
diff --git a/test/MyTested.AspNetCore.Mvc.ViewData.Test/PluginsTests/ViewDataTestPluginTests.cs b/test/MyTested.AspNetCore.Mvc.ViewData.Test/PluginsTests/ViewDataTestPluginTests.cs
diff --git a/test/MyTested.AspNetCore.Mvc.ViewFeatures.Test/PluginsTests/ViewFeaturesTestPluginTest.cs b/test/MyTested.AspNetCore.Mvc.ViewFeatures.Test/PluginsTests/ViewFeaturesTestPluginTest.cs

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public IAndExceptionTestBuilder OfType(Type exceptionType)`
`29`	`29`	`if (Reflection.AreDifferentTypes(exceptionType, actualExceptionType))`
`30`	`30`	`{`
`31`	`31`	`var (expectedExceptionName, actualExceptionName) =`
`32`		`- (expectedExceptionType, actualExceptionType).GetTypeComparisonNames();`
	`32`	`+ (exceptionType, actualExceptionType).GetTypeComparisonNames();`
`33`	`33`
`34`	`34`	`throw new InvalidExceptionAssertionException(string.Format(`
`35`	`35`	`"{0} {1}, but instead received {2}.",`
Original file line number	Diff line number	Diff line change
`@@ -69,12 +69,12 @@ public IAndMemoryCacheTestBuilder ContainingEntryOfType<TValue>()`
`69`	`69`	`=> this.ContainingEntryOfType(typeof(TValue));`
`70`	`70`
`71`	`71`	`/// <inheritdoc />`
`72`		`- public IAndMemoryCacheTestBuilder ContainingEntryOfType(object key, Type valueType)`
	`72`	`+ public IAndMemoryCacheTestBuilder ContainingEntryOfType(object key, Type expectedType)`
`73`	`73`	`{`
`74`	`74`	`var value = this.GetValue(key);`
`75`	`75`	`var actualType = value.GetType();`
`76`	`76`
`77`		`- if (Reflection.AreDifferentTypes(valueType, actualType))`
	`77`	`+ if (Reflection.AreDifferentTypes(expectedType, actualType))`
`78`	`78`	`{`
`79`	`79`	`var (expectedTypeName, actualTypeName) = (expectedType, actualType).GetTypeComparisonNames();`
`80`	`80`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`namespace MyTested.AspNetCore.Mvc.Test.PluginsTests`
`2`	`2`	`{`
`3`	`3`	`using System;`
`4`		`- using Microsoft.AspNetCore.Mvc.Internal;`
	`4`	`+ using Microsoft.AspNetCore.Mvc.Controllers;`
`5`	`5`	`using Microsoft.Extensions.DependencyInjection;`
`6`	`6`	`using Microsoft.Extensions.Options;`
`7`	`7`	`using Plugins;`
`@@ -36,10 +36,7 @@ public void ShouldInvokeMethodOfTypeVoidWithValidServiceCollectionForDefaultRegi`
`36`	`36`
`37`	`37`	`testPlugin.DefaultServiceRegistrationDelegate(serviceCollection);`
`38`	`38`
`39`		`- var methodReturnType = testPlugin.DefaultServiceRegistrationDelegate.Method.ReturnType.Name;`
`40`		`-`
`41`		`- Assert.True(methodReturnType == "Void");`
`42`		`- Assert.Contains(serviceCollection, s => s.ServiceType == typeof(MiddlewareFilterBuilder));`
	`39`	`+ Assert.Contains(serviceCollection, s => s.ServiceType == typeof(IControllerFactory));`
`43`	`40`	`}`
`44`	`41`
`45`	`42`	`[Fact]`
`@@ -50,9 +47,6 @@ public void ShouldInvokeMethodOfTypeVoidWithValidServiceCollection()`
`50`	`47`
`51`	`48`	`testPlugin.ServiceRegistrationDelegate(serviceCollection);`
`52`	`49`
`53`		`- var methodReturnType = testPlugin.ServiceRegistrationDelegate.Method.ReturnType.Name;`
`54`		`-`
`55`		`- Assert.True(methodReturnType == "Void");`
`56`	`50`	`Assert.Contains(serviceCollection, s => s.ServiceType == typeof(IOptions<>));`
`57`	`51`	`}`
`58`	`52`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,8 @@`
`1`		`-namespace MyTested.AspNetCore.Mvc.Test.PluginsTests`
	`1`	`+using Microsoft.AspNetCore.Mvc.Controllers;`
	`2`	`+`
	`3`	`+namespace MyTested.AspNetCore.Mvc.Test.PluginsTests`
`2`	`4`	`{`
`3`	`5`	`using System;`
`4`		`- using Microsoft.AspNetCore.Mvc.Formatters.Json.Internal;`
`5`	`6`	`using Microsoft.Extensions.DependencyInjection;`
`6`	`7`	`using Microsoft.Extensions.Options;`
`7`	`8`	`using Plugins;`
`@@ -36,10 +37,7 @@ public void ShouldInvokeMethodOfTypeVoidWithValidServiceCollectionForDefaultRegi`
`36`	`37`
`37`	`38`	`testPlugin.DefaultServiceRegistrationDelegate(serviceCollection);`
`38`	`39`
`39`		`- var methodReturnType = testPlugin.DefaultServiceRegistrationDelegate.Method.ReturnType.Name;`
`40`		`-`
`41`		`- Assert.True(methodReturnType == "Void");`
`42`		`- Assert.Contains(serviceCollection, s => s.ServiceType == typeof(JsonResultExecutor));`
	`40`	`+ Assert.Contains(serviceCollection, s => s.ServiceType == typeof(IControllerFactory));`
`43`	`41`	`}`
`44`	`42`
`45`	`43`	`[Fact]`
`@@ -50,11 +48,7 @@ public void ShouldInvokeMethodOfTypeVoidWithValidServiceCollection()`
`50`	`48`
`51`	`49`	`testPlugin.ServiceRegistrationDelegate(serviceCollection);`
`52`	`50`
`53`		`- var methodReturnType = testPlugin.ServiceRegistrationDelegate.Method.ReturnType.Name;`
`54`		`-`
`55`		`- Assert.True(methodReturnType == "Void");`
`56`	`51`	`Assert.Contains(serviceCollection, s => s.ServiceType == typeof(IOptions<>));`
`57`		`-`
`58`	`52`	`}`
`59`	`53`	`}`
`60`	`54`	`}`