Added missing tests for some action results (#359)

Author: ivaylokenov

test/MyTested.AspNetCore.Mvc.Controllers.ActionResults.Test/BuildersTests/ActionResultsTests/ConflictTests/ConflictTestBuilderTests.cs

@@ -8,6 +8,31 @@
 
     public class ConflictTestBuilderTests
     {
+        [Fact]
+        public void ConflictShouldNotThrowExceptionWithCorrectActionResult()
+        {
+            MyController<MvcController>
+                .Instance()
+                .Calling(c => c.ConflictAction())
+                .ShouldReturn()
+                .Conflict();
+        }
+
+        [Fact]
+        public void ConflictShouldThrowExceptionWithIncorrectActionResult()
+        {
+            Test.AssertException<InvocationResultAssertionException>(
+                () =>
+                {
+                    MyController<MvcController>
+                        .Instance()
+                        .Calling(c => c.OkResultAction())
+                        .ShouldReturn()
+                        .Conflict();
+                },
+                "When calling OkResultAction action in MvcController expected result to be ConflictResult, but instead received OkResult.");
+        }
+
         [Fact]
         public void WithStatusCodeShouldNotThrowExceptionWithCorrectStatusCode()
         {

test/MyTested.AspNetCore.Mvc.Controllers.ActionResults.Test/BuildersTests/ActionResultsTests/SignInTests/SignInTestBuilderTests.cs

@@ -8,6 +8,31 @@
 
     public class SignInTestBuilderTests
     {
+        [Fact]
+        public void SignInShouldNotThrowExceptionWithCorrectActionResult()
+        {
+            MyController<MvcController>
+                .Instance()
+                .Calling(c => c.SignInWithAuthenticationPropertiesAndScheme())
+                .ShouldReturn()
+                .SignIn();
+        }
+
+        [Fact]
+        public void ConflictShouldThrowExceptionWithIncorrectActionResult()
+        {
+            Test.AssertException<InvocationResultAssertionException>(
+                () =>
+                {
+                    MyController<MvcController>
+                        .Instance()
+                        .Calling(c => c.OkResultAction())
+                        .ShouldReturn()
+                        .SignIn();
+                },
+                "When calling OkResultAction action in MvcController expected result to be SignInResult, but instead received OkResult.");
+        }
+
         [Fact]
         public void ShouldReturnSignInShouldNotThrowExceptionIfResultIsSignInWithCorrectAuthenticationScheme()
         {

test/MyTested.AspNetCore.Mvc.Controllers.ActionResults.Test/BuildersTests/ActionResultsTests/SignOutTests/SignOutTestBuilderTests.cs

@@ -9,6 +9,31 @@
 
     public class SignOutTestBuilderTests
     {
+        [Fact]
+        public void SignInShouldNotThrowExceptionWithCorrectActionResult()
+        {
+            MyController<MvcController>
+                .Instance()
+                .Calling(c => c.SignOutWithAuthenticationProperties())
+                .ShouldReturn()
+                .SignOut();
+        }
+
+        [Fact]
+        public void ConflictShouldThrowExceptionWithIncorrectActionResult()
+        {
+            Test.AssertException<InvocationResultAssertionException>(
+                () =>
+                {
+                    MyController<MvcController>
+                        .Instance()
+                        .Calling(c => c.OkResultAction())
+                        .ShouldReturn()
+                        .SignOut();
+                },
+                "When calling OkResultAction action in MvcController expected result to be SignOutResult, but instead received OkResult.");
+        }
+
         [Fact]
         public void ShouldReturnSignOutShouldNotThrowExceptionIfResultIsSignOutWithCorrectAuthenticationScheme()
         {

test/MyTested.AspNetCore.Mvc.Controllers.ActionResults.Test/BuildersTests/ActionResultsTests/UnprocessableEntityTests/UnprocessableEntityTestBuilderTests.cs

@@ -8,6 +8,31 @@
 
     public class UnprocessableEntityTestBuilderTests
     {
+        [Fact]
+        public void UnprocessableEntityShouldNotThrowExceptionWithCorrectActionResult()
+        {
+            MyController<MvcController>
+                .Instance()
+                .Calling(c => c.UnprocessableEntityAction())
+                .ShouldReturn()
+                .UnprocessableEntity();
+        }
+
+        [Fact]
+        public void UnprocessableEntityShouldThrowExceptionWithIncorrectActionResult()
+        {
+            Test.AssertException<InvocationResultAssertionException>(
+                () =>
+                {
+                    MyController<MvcController>
+                        .Instance()
+                        .Calling(c => c.OkResultAction())
+                        .ShouldReturn()
+                        .UnprocessableEntity();
+                },
+                "When calling OkResultAction action in MvcController expected result to be UnprocessableEntityResult, but instead received OkResult.");
+        }
+
         [Fact]
         public void WithStatusCodeShouldNotThrowExceptionWithCorrectStatusCode()
         {
@@ -43,11 +68,7 @@ public void WithStatusCodeShouldThrowExceptionWithIncorrectStatusCode()
                         .UnprocessableEntity(unprocessableEntity => unprocessableEntity
                             .WithStatusCode(415));
                 },
-#if NETCOREAPP
                 "When calling UnprocessableEntityAction action in MvcController expected unprocessable entity result to have 415 (UnsupportedMediaType) status code, but instead received 422 (UnprocessableEntity).");
-#else
-                "When calling UnprocessableEntityAction action in MvcController expected unprocessable entity result to have 415 (UnsupportedMediaType) status code, but instead received 422 (422).");
-#endif
         }
 
         [Fact]
@@ -63,11 +84,7 @@ public void WithStatusCodeAsEnumShouldThrowExceptionWithIncorrectStatusCode()
                         .UnprocessableEntity(unprocessableEntity => unprocessableEntity
                             .WithStatusCode(HttpStatusCode.UnsupportedMediaType));
                 },
-#if NETCOREAPP
                 "When calling UnprocessableEntityAction action in MvcController expected unprocessable entity result to have 415 (UnsupportedMediaType) status code, but instead received 422 (UnprocessableEntity).");
-#else
-                "When calling UnprocessableEntityAction action in MvcController expected unprocessable entity result to have 415 (UnsupportedMediaType) status code, but instead received 422 (422).");
-#endif
         }
 
         [Fact]
@@ -107,7 +124,7 @@ public void PassingShouldThrowAnExceptionOnAnIncorrectAssertion()
                         .UnprocessableEntity(unprocessableEntity => unprocessableEntity
                             .Passing(ue => ue.ContentTypes?.Count == 0));
                 },
-                $"When calling FullUnprocessableEntityAction action in MvcController expected the UnprocessableEntityObjectResult to pass the given predicate, but it failed.");
+                "When calling FullUnprocessableEntityAction action in MvcController expected the UnprocessableEntityObjectResult to pass the given predicate, but it failed.");
         }
 
         [Fact]