Added unit tests for ViewComponent testing (#66)

Author: ivaylokenov

samples/MusicStore/MusicStore.Test/Controllers/HomeControllerTest.cs

@@ -30,10 +30,7 @@ public void IndexShouldReturnTopSellingAlbumsAndSaveThenIntoCache()
                 .ShouldReturn()
                 .View()
                 .WithModelOfType<List<Album>>()
-                .Passing(albums =>
-                {
-                    Assert.Equal(6, albums.Count);
-                });
+                .Passing(albums => Assert.Equal(6, albums.Count));
         }
 
         [Fact]

samples/MusicStore/MusicStore.Test/TestStartup.cs

@@ -37,6 +37,7 @@ public void ConfigureTestServices(IServiceCollection services)
             TestHelper.HttpFeatureRegistrationPlugins.Add(new SessionTestPlugin());
 
             TestHelper.ShouldPassForPlugins.Add(new AbstractionsTestPlugin());
+            TestHelper.ShouldPassForPlugins.Add(new HttpTestPlugin());
             TestHelper.ShouldPassForPlugins.Add(new ControllersTestPlugin());
 
             services

src/MyTested.AspNetCore.Mvc.Abstractions/Builders/Contracts/Invocations/IBaseShouldReturnTestBuilder.cs

@@ -27,8 +27,8 @@ public interface IBaseShouldReturnTestBuilder<TInvocationResult, TBuilder>
         /// Tests whether the result is of the provided type.
         /// </summary>
         /// <typeparam name="TResult">Expected response type.</typeparam>
-        /// <returns>Test builder of <see cref="IModelDetailsTestBuilder{TInvocationResult}"/> type.</returns>
-        IAndModelDetailsTestBuilder<TInvocationResult> ResultOfType<TResult>();
+        /// <returns>Test builder of <see cref="IModelDetailsTestBuilder{TResult}"/> type.</returns>
+        IAndModelDetailsTestBuilder<TResult> ResultOfType<TResult>();
 
         /// <summary>
         /// Tests whether the result is of the provided type.
@@ -42,8 +42,7 @@ public interface IBaseShouldReturnTestBuilder<TInvocationResult, TBuilder>
         /// </summary>
         /// <typeparam name="TResult">Expected response type.</typeparam>
         /// <param name="model">Expected return object.</param>
-        /// <returns>Test builder of <see cref="IModelDetailsTestBuilder{TInvocationResult}"/> type.</returns>
-        IAndModelDetailsTestBuilder<TInvocationResult> Result<TResult>(TResult model);
-
+        /// <returns>Test builder of <see cref="IModelDetailsTestBuilder{TResult}"/> type.</returns>
+        IAndModelDetailsTestBuilder<TResult> Result<TResult>(TResult model);
     }
 }

src/MyTested.AspNetCore.Mvc.Abstractions/Builders/Models/ModelDetailsTestBuilder.cs

@@ -38,9 +38,8 @@ public IAndTestBuilder Passing(Func<TModel, bool> predicate)
             if (!predicate(this.Model))
             {
                 throw new ResponseModelAssertionException(string.Format(
-                    "When calling {0} action in {1} expected response model {2} to pass the given predicate, but it failed.",
-                    this.TestContext.MethodName,
-                    this.TestContext.Component.GetName(),
+                    "{0} response model {1} to pass the given predicate, but it failed.",
+                    this.TestContext.ExceptionMessagePrefix,
                     typeof(TModel).ToFriendlyTypeName()));
             }
 

src/MyTested.AspNetCore.Mvc.Abstractions/Internal/TestHelper.cs

@@ -10,6 +10,8 @@
     using Services;
     using TestContexts;
     using Utilities;
+    using Microsoft.AspNetCore.Mvc;
+    using Microsoft.AspNetCore.Mvc.Infrastructure;
 
     public static class TestHelper
     {
@@ -50,6 +52,15 @@ public static void SetHttpContextToAccessor(HttpContext httpContext)
             }
         }
 
+        public static void SetActionContextToAccessor(ActionContext actionContext)
+        {
+            var actionContextAccessor = TestServiceProvider.GetService<IActionContextAccessor>();
+            if (actionContextAccessor != null)
+            {
+                actionContextAccessor.ActionContext = actionContext;
+            }
+        }
+
         /// <summary>
         /// Tries to create instance of the provided type. Returns null if not successful.
         /// </summary>

src/MyTested.AspNetCore.Mvc.Abstractions/Utilities/Validators/InvocationResultValidator.cs

@@ -91,10 +91,12 @@ public static void ValidateInvocationResult<TResult>(ComponentTestContext testCo
             testContext.Model = model;
         }
 
-        public static TResult GetInvocationResult<TResult>(ComponentTestContext testContext)
+        public static TResult GetInvocationResult<TResult>(
+            ComponentTestContext testContext,
+            bool canBeAssignable = false)
             where TResult : class
         {
-            ValidateInvocationResultType<TResult>(testContext);
+            ValidateInvocationResultType<TResult>(testContext, canBeAssignable);
             return testContext.MethodResult as TResult;
         }
 

src/MyTested.AspNetCore.Mvc.Controllers/Builders/Actions/ShouldReturn/ShouldReturnResult.cs

@@ -18,17 +18,17 @@ public IAndModelDetailsTestBuilder<TActionResult> ResultOfType(Type returnType)
         }
 
         /// <inheritdoc />
-        public IAndModelDetailsTestBuilder<TActionResult> ResultOfType<TResult>()
+        public IAndModelDetailsTestBuilder<TResult> ResultOfType<TResult>()
         {
             InvocationResultValidator.ValidateInvocationResultType<TResult>(this.TestContext, true);
-            return new ModelDetailsTestBuilder<TActionResult>(this.TestContext);
+            return new ModelDetailsTestBuilder<TResult>(this.TestContext);
         }
 
         /// <inheritdoc />
-        public IAndModelDetailsTestBuilder<TActionResult> Result<TResult>(TResult model)
+        public IAndModelDetailsTestBuilder<TResult> Result<TResult>(TResult model)
         {
             InvocationResultValidator.ValidateInvocationResult(this.TestContext, model);
-            return new ModelDetailsTestBuilder<TActionResult>(this.TestContext);
+            return new ModelDetailsTestBuilder<TResult>(this.TestContext);
         }
     }
 }

src/MyTested.AspNetCore.Mvc.Controllers/Internal/Controllers/ControllerContextMock.cs

@@ -36,7 +36,7 @@ private void PrepareControllerContext(ActionContext actionContext)
             this.RouteData = actionContext.RouteData;
             this.ValueProviderFactories = this.ValueProviderFactories ?? new List<IValueProviderFactory>();
 
-            ControllerTestHelper.SetActionContextToAccessor(this);
+            TestHelper.SetActionContextToAccessor(this);
         }
     }
 }

src/MyTested.AspNetCore.Mvc.Controllers/Internal/Controllers/ControllerPropertyHelper.cs

@@ -9,8 +9,8 @@ public class ControllerPropertyHelper : PropertyHelper
         private static readonly ConcurrentDictionary<Type, ControllerPropertyHelper> ControllerPropertiesCache =
             new ConcurrentDictionary<Type, ControllerPropertyHelper>();
 
-        private Func<object, ControllerContext> controllerContextGetter;
-        private Func<object, ActionContext> actionContextGetter;
+        private Func<object, ControllerContext> controllerContextGetter; // DO I NEED THESE???
+        private Func<object, ActionContext> actionContextGetter; // DO I NEED THESE?
 
         public ControllerPropertyHelper(Type controllerType)
             : base (controllerType)