Fixed half of the failing unit tests after upgrading to 1.0.0

Author: ivaylokenov

src/MyTested.AspNetCore.Mvc.Core/Internal/Routes/ModelBindingActionInvoker.cs

@@ -6,15 +6,16 @@
     using Contracts;
     using Microsoft.AspNetCore.Mvc;
     using Microsoft.AspNetCore.Mvc.Controllers;
-    using Microsoft.AspNetCore.Mvc.Filters;
-    using Microsoft.AspNetCore.Mvc.Formatters;
     using Microsoft.AspNetCore.Mvc.Internal;
     using Microsoft.AspNetCore.Mvc.ModelBinding;
-    using Microsoft.AspNetCore.Mvc.ModelBinding.Validation;
     using Microsoft.Extensions.Logging;
 
     public class ModelBindingActionInvoker : ControllerActionInvoker, IModelBindingActionInvoker
     {
+        private readonly IControllerFactory controllerFactory;
+        private readonly IControllerArgumentBinder controllerArgumentBinder;
+        private readonly ControllerContext controllerContext;
+
         public ModelBindingActionInvoker(
             ControllerActionInvokerCache cache,
             IControllerFactory controllerFactory,
@@ -27,12 +28,22 @@ public ModelBindingActionInvoker(
                 : base(cache, controllerFactory, controllerArgumentBinder, logger, diagnosticSource, actionContext, valueProviderFactories, maxModelValidationErrors)
         {
             this.BoundActionArguments = new Dictionary<string, object>();
+
+            this.controllerFactory = controllerFactory;
+            this.controllerArgumentBinder = controllerArgumentBinder;
+
+            this.controllerContext = new ControllerContext(actionContext);
+            this.controllerContext.ModelState.MaxAllowedErrors = maxModelValidationErrors;
+            this.controllerContext.ValueProviderFactories = new List<IValueProviderFactory>(valueProviderFactories);
         }
 
         public IDictionary<string, object> BoundActionArguments { get; private set; }
 
         public override Task InvokeAsync()
         {
+            var controller = this.controllerFactory.CreateController(this.controllerContext);
+            this.controllerArgumentBinder.BindArgumentsAsync(controllerContext, controller, this.BoundActionArguments);
+
             return TaskCache.CompletedTask;
         }
     }

src/MyTested.AspNetCore.Mvc.EntityFrameworkCore/Internal/ScopedInMemoryOptionsExtension.cs

@@ -10,7 +10,7 @@ public class ScopedInMemoryOptionsExtension : InMemoryOptionsExtension
         public override void ApplyServices(IServiceCollection services)
         {
             services
-                .ReplaceLifetime<IInMemoryStore>(ServiceLifetime.Scoped)
+                .ReplaceLifetime<IInMemoryStoreSource>(ServiceLifetime.Scoped)
                 .ReplaceLifetime<InMemoryValueGeneratorCache>(ServiceLifetime.Scoped);
         }
     }

test/MyTested.AspNetCore.Mvc.Core.Test/BuildersTests/ActionResultsTests/BadRequestTests/BadRequestTestBuilderTests.cs

@@ -446,7 +446,7 @@ public void ContainingOutputFormattersShouldNotThrowExceptionWithCorrectParamete
                 .Calling(c => c.FullHttpBadRequestAction())
                 .ShouldReturn()
                 .BadRequest()
-                .ContainingOutputFormatters(new CustomOutputFormatter());
+                .ContainingOutputFormatters(TestObjectFactory.GetOutputFormatter(), new CustomOutputFormatter());
         }
 
         [Fact]
@@ -462,11 +462,11 @@ public void ContainingOutputFormattersShouldThrowExceptionWithIncorrectValue()
                         .BadRequest()
                         .ContainingOutputFormatters(new List<IOutputFormatter>
                         {
-                            TestObjectFactory.GetOutputFormatter(),
-                            new CustomOutputFormatter()
+                            new CustomOutputFormatter(),
+                            new StringOutputFormatter()
                         });
                 },
-                "When calling FullHttpBadRequestAction action in MvcController expected bad request result output formatters to contain formatter of HttpNotAcceptableOutputFormatter type, but none was found.");
+                "When calling FullHttpBadRequestAction action in MvcController expected bad request result output formatters to contain formatter of StringOutputFormatter type, but none was found.");
         }
 
         [Fact]
@@ -482,7 +482,6 @@ public void ContainingOutputFormattersShouldThrowExceptionWithIncorrectCount()
                         .BadRequest()
                         .ContainingOutputFormatters(new List<IOutputFormatter>
                         {
-                            TestObjectFactory.GetOutputFormatter(),
                             new CustomOutputFormatter()
                         });
                 },
@@ -520,7 +519,7 @@ public void AndAlsoShouldWorkCorrectly()
                 .BadRequest()
                 .WithStatusCode(201)
                 .AndAlso()
-                .ContainingOutputFormatters(TestObjectFactory.GetOutputFormatter());
+                .ContainingOutputFormatters(TestObjectFactory.GetOutputFormatter(), new CustomOutputFormatter());
         }
 
         [Fact]

test/MyTested.AspNetCore.Mvc.Test/Setups/Routes/RouteController.cs

@@ -11,7 +11,7 @@ public IActionResult Index()
             return this.View();
         }
 
-        [HttpGet("[action]/{id}")]
+        [HttpGet("[action]")]
         public IActionResult Action(int id)
         {
             return this.View();