Merge pull request #309 - Added Unit Tests for the ViewData and the ViewBag Builders

Added Unit Tests for the ViewData and the ViewBag Builders

Author: ivaylokenov

test/MyTested.AspNetCore.Mvc.ViewData.Test/BuildersTests/ActionsTests/ShouldHaveTests/ShouldHaveViewBagTests.cs

@@ -131,5 +131,47 @@ public void ViewBagWithBuilderShouldWorkCorrectly()
                 .ShouldReturn()
                 .Ok();
         }
+
+        [Fact]
+        public void ViewBagWithBuilderShouldContainMultipleEntries()
+        {
+            MyController<MvcController>
+                .Instance()
+                .Calling(c => c.AddViewBagAction())
+                .ShouldHave()
+                .ViewBag(viewBag => viewBag
+                    .ContainingEntries(new { Test = "BagValue", Another = "AnotherValue" }))
+                .AndAlso()
+                .ShouldReturn()
+                .Ok();
+        }
+
+        [Fact]
+        public void ViewBagWithBuilderShouldContainEntryWithKey()
+        {
+            MyController<MvcController>
+                .Instance()
+                .Calling(c => c.AddViewBagAction())
+                .ShouldHave()
+                .ViewBag(viewBag => viewBag
+                    .ContainingEntryWithKey("Another"))
+                .AndAlso()
+                .ShouldReturn()
+                .Ok();
+        }
+
+        [Fact]
+        public void ViewBagWithBuilderShouldContainEntryOfTypeString()
+        {
+            MyController<MvcController>
+                .Instance()
+                .Calling(c => c.AddViewBagAction())
+                .ShouldHave()
+                .ViewBag(viewBag => viewBag
+                    .ContainingEntryOfType<string>())
+                .AndAlso()
+                .ShouldReturn()
+                .Ok();
+        }
     }
 }

test/MyTested.AspNetCore.Mvc.ViewData.Test/BuildersTests/ActionsTests/ShouldHaveTests/ShouldHaveViewDataTests.cs

@@ -131,5 +131,47 @@ public void ViewDataWithBuilderShouldWorkCorrectly()
                 .ShouldReturn()
                 .Ok();
         }
+
+        [Fact]
+        public void ViewDataWithBuilderShouldContainMultipleEntries()
+        {
+            MyController<MvcController>
+                .Instance()
+                .Calling(c => c.AddViewDataAction())
+                .ShouldHave()
+                .ViewData(viewData => viewData
+                    .ContainingEntries(new { Test = "DataValue", Another = "AnotherValue" }))
+                .AndAlso()
+                .ShouldReturn()
+                .Ok();
+        }
+
+        [Fact]
+        public void ViewDataWithBuilderShouldContainEntryWithKey()
+        {
+            MyController<MvcController>
+                .Instance()
+                .Calling(c => c.AddViewDataAction())
+                .ShouldHave()
+                .ViewData(viewData => viewData
+                    .ContainingEntryWithKey("Another"))
+                .AndAlso()
+                .ShouldReturn()
+                .Ok();
+        }
+
+        [Fact]
+        public void ViewDataWithBuilderShouldContainEntryOfTypeString()
+        {
+            MyController<MvcController>
+                .Instance()
+                .Calling(c => c.AddViewDataAction())
+                .ShouldHave()
+                .ViewData(viewData => viewData
+                    .ContainingEntryOfType<string>())
+                .AndAlso()
+                .ShouldReturn()
+                .Ok();
+        }
     }
 }

test/MyTested.AspNetCore.Mvc.ViewData.Test/InternalTests/ComponentTestContextViewDataExtensionsTests.cs

@@ -0,0 +1,53 @@
+namespace MyTested.AspNetCore.Mvc.Test.InternalTests
+{
+    using Microsoft.AspNetCore.Http;
+    using Microsoft.Extensions.DependencyInjection.Extensions;
+    using Setups;
+    using Setups.Controllers;
+    using Setups.ViewComponents;
+    using System;
+    using Xunit;
+
+    public class ComponentTestContextViewDataExtensionsTests
+    {
+        [Fact]
+        public void GetViewDataShouldThrowInvalidOperationExceptionWithPocoViewComponent()
+        {
+            Test.AssertException<InvalidOperationException>(
+                () =>
+                {
+                    MyViewComponent<PocoViewComponent>
+                        .Instance()
+                        .InvokedWith(c => c.Invoke())
+                        .ShouldHave()
+                        .NoViewData()
+                        .AndAlso()
+                        .ShouldReturn()
+                        .View();
+                }, 
+                "ViewDataDictionary could not be found on the provided PocoViewComponent. The property should be specified manually by providing component instance or using the specified helper methods.");
+        }
+
+        [Fact]
+        public void GetViewDataShouldHaveNoViewDataForPocoController()
+        {
+            MyApplication
+                .StartsFrom<DefaultStartup>()
+                .WithServices(services =>
+                {
+                    services.TryAddSingleton<IHttpContextAccessor, HttpContextAccessor>();
+                });
+
+            MyController<FullPocoController>
+                .Instance()
+                .Calling(c => c.OkResultAction())
+                .ShouldHave()
+                .NoViewData()
+                .AndAlso()
+                .ShouldReturn()
+                .Ok();
+
+            MyApplication.StartsFrom<DefaultStartup>();
+        }
+    }
+}

test/MyTested.AspNetCore.Mvc.ViewData.Test/InternalTests/ViewDataPropertyHelperTests.cs

@@ -4,10 +4,11 @@
     using Internal.Services;
     using Microsoft.AspNetCore.Http;
     using Microsoft.AspNetCore.Mvc;
-    using Setups.Controllers;
-    using Xunit;
     using Microsoft.Extensions.DependencyInjection.Extensions;
     using Setups;
+    using Setups.Controllers;
+    using System;
+    using Xunit;
 
     public class ViewDataPropertyHelperTests
     {
@@ -58,5 +59,31 @@ public void GetPropertiesShouldNotThrowExceptionForPocoController()
 
             MyApplication.StartsFrom<DefaultStartup>();
         }
+
+        [Fact]
+        public void ViewDataGetterShouldThrowNullReferenceExceptionWithNull()
+        {
+            MyApplication.StartsFrom<DefaultStartup>();
+
+            var helper = ViewDataPropertyHelper.GetViewDataProperties<MvcController>();
+
+            Assert.Throws<NullReferenceException>(() => helper.ViewDataGetter(null));
+        }
+
+        [Fact]
+        public void ViewDataGetterShouldThrowInvalidOperationExceptionForPrivatePocoController()
+        {
+            MyApplication.StartsFrom<DefaultStartup>();
+
+            var helper = ViewDataPropertyHelper.GetViewDataProperties<PrivatePocoController>();
+            var controller = new PrivatePocoController(TestServiceProvider.Global);
+
+            Test.AssertException<InvalidOperationException>(
+                () =>
+                {
+                    helper.ViewDataGetter(controller);
+                }, 
+                "ViewDataDictionary could not be found on the provided PrivatePocoController. The property should be specified manually by providing component instance or using the specified helper methods.");
+        }
     }
 }

test/MyTested.AspNetCore.Mvc.ViewData.Test/PluginsTests/ViewDataTestPluginTests.cs

@@ -0,0 +1,42 @@
+namespace MyTested.AspNetCore.Mvc.Test.PluginsTests
+{
+    using Microsoft.Extensions.DependencyInjection;
+    using Plugins;
+    using System;
+    using Xunit;
+
+    public class ViewDataTestPluginTests
+    {
+        [Fact]
+        public void ShouldHavePriorityWithDefaultValue()
+        {
+            var testPlugin = new ViewDataTestPlugin();
+
+            Assert.IsAssignableFrom<IDefaultRegistrationPlugin>(testPlugin);
+            Assert.NotNull(testPlugin);
+            Assert.Equal(-1000, testPlugin.Priority);
+        }
+
+        [Fact]
+        public void ShouldThrowArgumentNullExceptionWithInvalidServiceCollection()
+        {
+            var testPlugin = new ViewDataTestPlugin();
+
+            Assert.Throws<ArgumentNullException>(() => testPlugin.DefaultServiceRegistrationDelegate(null));
+        }
+
+        [Fact]
+        public void ShouldInvokeMethodOfTypeVoidWithValidServiceCollection()
+        {
+            var testPlugin = new ViewDataTestPlugin();
+            var serviceCollection = new ServiceCollection();
+
+            testPlugin.DefaultServiceRegistrationDelegate(serviceCollection);
+
+            var methodReturnType = testPlugin.DefaultServiceRegistrationDelegate.Method.ReturnType.Name;
+
+            Assert.True(methodReturnType == "Void");
+            Assert.True(serviceCollection.Count == 126);
+        }
+    }
+}