maximumLineLenght - rewrite allowFunctionSignature handling

`iterateNodesByType` is now used instead of the recursive `searchBodyForDecl`

`FunctionExpression` is checked as well as (previously checked)
`FunctionDeclaration` and `MethodDefiniton`

closes #2032

Author: himdel

lib/rules/maximum-line-length.js

@@ -127,35 +127,23 @@ module.exports.prototype = {
         }
 
         if (this._allowFunctionSignature) {
-            var functionDeclarationLocs = [];
-            var searchBodyForDecl = function searchBodyForDecl(node) {
-                node.body.forEach(function(bodyNode) {
-                    if (bodyNode.type === 'FunctionDeclaration') {
-                        // get the loc for the `function Identifier` portion
-                        functionDeclarationLocs.push(bodyNode.id.loc);
-                        // get the locs for the params
-                        bodyNode.params.forEach(function(param) { functionDeclarationLocs.push(param.loc); });
-                        return;
-
-                    } else if (bodyNode.type === 'ClassDeclaration') {
-                        searchBodyForDecl(bodyNode.body);
-                        return;
-
-                    } else if (bodyNode.type === 'MethodDefinition') {
-                        // get the loc for method name
-                        functionDeclarationLocs.push(bodyNode.key.loc);
-                        // get the locs for the params
-                        bodyNode.value.params.forEach(function(param) { functionDeclarationLocs.push(param.loc); });
-                        return;
-                    }
-                });
-            };
-            searchBodyForDecl(file.getTree());
-
-            functionDeclarationLocs.forEach(function(loc) {
-                for (var i = loc.start.line; i <= loc.end.line; i++) {
-                    lines[i - 1] = '';
+            file.iterateNodesByType('FunctionDeclaration', function(node) {
+                removeLoc(node.id);
+                node.params.forEach(removeLoc);
+            });
+
+            file.iterateNodesByType('MethodDefinition', function(node) {
+                removeLoc(node.key);
+                // node.value is a FunctionExpression, params are handled there
+            });
+
+            file.iterateNodesByType('FunctionExpression', function(node) {
+                // need to remove the first line, because we can't be sure there's any id or params
+                lines[node.loc.start.line - 1] = '';
+                if (node.id) {
+                    removeLoc(node.id);
                 }
+                node.params.forEach(removeLoc);
             });
         }