disallowSpacesInGenerator: improve logic and fix bug for shortland

* Actually check shortland generators, but only for the `afterStar` option,
  omit check for `beforeStar` since it doesn't makes since to check it

* Remove check for getter & setters, since they can't be generators

* Increase coverage

Author: markelog

lib/rules/disallow-spaces-in-generator.js

@@ -89,14 +89,11 @@ module.exports.prototype = {
             }
 
             var parent = node.parentNode;
-
-            // Ignore syntactic sugar for getters and setters.
-            if (parent.type === 'Property' && (parent.kind === 'get' || parent.kind === 'set')) {
-                return;
-            }
+            var shortland = false;
 
             // shorthand or constructor methods
             if (parent.method || parent.type === 'MethodDefinition') {
+                shortland = true;
                 node = parent.key;
             }
 
@@ -106,7 +103,7 @@ module.exports.prototype = {
                 currentToken = file.getNextToken(currentToken);
             }
 
-            if (beforeStar) {
+            if (beforeStar && !shortland) {
                 // currentToken assigned outside of function
                 errors.assert.noWhitespaceBetween({
                     token: currentToken,
@@ -116,13 +113,22 @@ module.exports.prototype = {
             }
 
             if (afterStar) {
-                // currentToken reassigned for star token
-                currentToken = file.getNextToken(currentToken);
-                errors.assert.noWhitespaceBetween({
-                    token: currentToken,
-                    nextToken: file.getNextToken(currentToken),
-                    message: 'Illegal space after star'
-                });
+                if (shortland) {
+                    errors.assert.noWhitespaceBetween({
+                        token: file.getPrevToken(currentToken),
+                        nextToken: currentToken,
+                        message: 'Illegal space after star'
+                    });
+                } else {
+
+                    // currentToken reassigned for star token
+                    currentToken = file.getNextToken(currentToken);
+                    errors.assert.noWhitespaceBetween({
+                        token: currentToken,
+                        nextToken: file.getNextToken(currentToken),
+                        message: 'Illegal space after star'
+                    });
+                }
             }
         });
     }

test/specs/rules/disallow-spaces-in-generator.js

@@ -67,16 +67,20 @@ describe('rules/disallow-spaces-in-generator', function() {
             output: 'var x = function*asdf(){}'
         });
 
+        it('should not report shortland method (since it doesn\' makes sense)', function() {
+            expect(checker.checkString('({ * foo() {} });')).to.have.no.errors();
+        });
+
         it('should not report illegal space error', function() {
             expect(checker.checkString('var x = function* (){}')).to.have.no.errors();
         });
 
-        it('should not report illegal space error with named function expression', function() {
-            expect(checker.checkString('var x = function* asdf(){}')).to.have.no.errors();
+        it('should bail out if this is not a generator', function() {
+            expect(checker.checkString('var x = function (){}')).to.have.no.errors();
         });
 
-        it('should not report illegal space error with function delcaration', function() {
-            expect(checker.checkString('function* asdf(){}')).to.have.no.errors();
+        it('should not report illegal space error with named function expression', function() {
+            expect(checker.checkString('var x = function* asdf(){}')).to.have.no.errors();
         });
 
         it('should not report illegal space error with async function', function() {
@@ -158,6 +162,14 @@ describe('rules/disallow-spaces-in-generator', function() {
             output: 'var x = function*asdf(){}'
         });
 
+        reportAndFix({
+            name: 'should report illegal space after the star for the shortland',
+            rules: rules,
+            errors: 1,
+            input: '({ * foo() {} });',
+            output: '({ *foo() {} });'
+        });
+
         it('should not report illegal space error', function() {
             expect(checker.checkString('var x = function *(){}')).to.have.no.errors();
         });