disallowAllowSpacesInsideParentheses: reintroduce archaic "all" config option

Fixes #1027

Author: mikesherov

lib/rules/disallow-spaces-inside-parentheses.js

@@ -3,7 +3,7 @@
  *
  * Type: `Object` or `Boolean`
  *
- * Values: `true` or Object with either `"only"` with array of tokens or `"all"` with `true` value
+ * Values: `true` or Object with either `"only"` with array of tokens
  *
  * #### Example
  *
@@ -45,7 +45,12 @@ module.exports.prototype = {
         var isObject = typeof option === 'object';
 
         var error = 'disallowSpacesInsideParentheses option requires' +
-            ' true or object value with "all" or "only" properties ';
+            ' true or object value with "only" properties ';
+
+        // backcompat for 1.10: {all: true} #1027
+        if (isObject && option.all === true) {
+            option = true;
+        }
 
         if (typeof option === 'boolean') {
             assert(option === true, error);

test/rules/disallow-spaces-inside-parentheses.js

@@ -21,6 +21,12 @@ describe('rules/disallow-spaces-inside-parentheses', function() {
                 checker.configure({ disallowSpacesInsideParentheses: {} });
             });
         });
+
+        it('should throw when all is specified but not true', function() {
+            assert.throws(function() {
+                checker.configure({ disallowSpacesInsideParentheses: { all: ['invalid'] } });
+            });
+        });
     });
 
     describe('true', function() {
@@ -64,6 +70,18 @@ describe('rules/disallow-spaces-inside-parentheses', function() {
         });
     });
 
+    describe('"all" option', function() {
+        beforeEach(function() {
+            checker.configure({ disallowSpacesInsideParentheses: { all: true } });
+        });
+
+        it('should report illegal space after opening round bracket', function() {
+            assert(checker.checkString('( 1 + 2) * 3').getErrorCount() === 1);
+            assert(checker.checkString('if ( 1 + 2)\n    3').getErrorCount() === 1);
+            assert(checker.checkString('function my( a, b) {  }').getErrorCount() === 1);
+        });
+    });
+
     describe('es6', function() {
         beforeEach(function() {
             checker.configure({