Configuration: do not try to load presets with function values

Fixes #1947
Closes gh-1950

Author: markelog

lib/config/configuration.js

@@ -886,6 +886,10 @@ Configuration.prototype.getRegisteredRules = function() {
 Configuration.prototype.registerPreset = function(presetName, presetConfig) {
     assert(_.isPlainObject(presetConfig), 'Preset should be an object');
 
+    for (var key in presetConfig) {
+        assert(typeof presetConfig[key] !== 'function', 'Preset should be an JSON object');
+    }
+
     this._presets[presetName] = presetConfig;
 };
 

test/specs/config/configuration.js

@@ -242,6 +242,14 @@ describe('config/configuration', function() {
                 configuration.registerPreset.bind(configuration, 'test', undefined)
             ).to.throw('Preset should be an object');
         });
+
+        it('should throw if preset if it is not JSON', function() {
+            expect(
+                configuration.registerPreset.bind(configuration, 'test', {
+                    'test': function() {}
+                })
+            ).to.throw('Preset should be an JSON object');
+        });
     });
 
     describe('getFix', function() {

test/specs/config/node-configuration.js

@@ -228,26 +228,6 @@ describe('modules/config/node-configuration', function() {
             expect(configuration.getPresetName()).to.equal('external');
         });
 
-        it('should try to load preset from node', function() {
-            configuration.registerDefaultRules();
-            configuration.load({
-                preset: 'path'
-            });
-
-            expect(configuration.getPresetName()).to.equal('path');
-            expect(configuration.getUnsupportedRuleNames().indexOf('resolve')).to.be.above(-1);
-        });
-
-        it('should try to load preset from node_modules', function() {
-            configuration.registerDefaultRules();
-            configuration.load({
-                preset: 'sinon'
-            });
-
-            expect(configuration.getPresetName()).to.equal('sinon');
-            expect(configuration.getUnsupportedRuleNames().indexOf('spy')).to.be.above(-1);
-        });
-
         it('should load preset from preset', function() {
             configuration.load({
                 preset: path.resolve('./test/data/configs/modules/node_modules/jscs-t-test/index.json')
@@ -384,16 +364,6 @@ describe('modules/config/node-configuration', function() {
                 })).to.throw('Preset "not-exist" does not exist');
         });
 
-        it('should try to load preset from node_modules', function() {
-            configuration.registerDefaultRules();
-            configuration.load({
-                preset: 'sinon'
-            });
-
-            expect(configuration.getPresetName()).to.equal('sinon');
-            expect(configuration.getUnsupportedRuleNames().indexOf('spy')).to.be.above(-1);
-        });
-
         it('should accept `additionalRules` to register rule instances', function() {
             var rule = {
                 getOptionName: function() {