implement fileExtensions option

Author: joelrbrandt

README.md

@@ -129,6 +129,26 @@ Values: Array of file matching patterns
 "excludeFiles": ["node_modules/**"]
 ```
 
+### fileExtensions
+
+Changes the set of file extensions that will be processed.
+
+Type: `Array` or `String` or `"*"`
+
+Values: A single file extension or an Array of file extensions, beginning with a `.`. The matching is case _insensitive_. If `"*"` is provided, all files regardless of extension will match.
+
+#### Example
+
+```js
+"fileExtensions": [".js", ".jsx"]
+```
+
+#### Default
+
+```js
+"fileExtensions": [".js"]
+```
+
 ## Rules
 
 ### requireCurlyBraces

lib/checker.js

@@ -6,6 +6,7 @@ var path = require('path');
 
 var additionalRules = require('./options/additional-rules');
 var excludeFiles = require('./options/exclude-files');
+var fileExtensions = require('./options/file-extensions');
 
 /**
  * Starts Code Style checking process.
@@ -26,6 +27,7 @@ utils.inherits(Checker, StringChecker);
 Checker.prototype.configure = function(config) {
     var cwd = config.configPath ? path.dirname(config.configPath) : process.cwd();
 
+    fileExtensions(config, this);
     excludeFiles(config, this, cwd);
     additionalRules(config, this, cwd);
 
@@ -40,7 +42,7 @@ Checker.prototype.configure = function(config) {
  */
 Checker.prototype.checkFile = function(path) {
     var _this = this;
-    if (this._shouldProcess(path) && path.match(/\.js$/)) {
+    if (this._shouldProcess(path)) {
         return vowFs.read(path, 'utf8').then(function(data) {
             return _this.checkString(data, path);
         });
@@ -117,13 +119,20 @@ Checker.prototype.checkPath = function(path) {
 };
 
 /**
- * Returns true if specified path is not in exluded list.
+ * Returns true if specified path is not in exluded list and if
+ * the file extension matches a file extension to process.
  *
  * @returns {Boolean}
  */
 Checker.prototype._shouldProcess = function(testPath) {
     testPath = path.resolve(testPath);
 
+    var extension = path.extname(testPath).toLowerCase();
+    if (this._fileExtensions.indexOf(extension) < 0 &&
+        this._fileExtensions.indexOf('*') < 0) {
+        return false;
+    }
+
     return this._excludes.every(function(exclude) {
         return !exclude.match(testPath);
     });

lib/options/file-extensions.js

@@ -0,0 +1,16 @@
+var DEFAULT_FILE_EXTENSIONS = ['.js'];
+
+module.exports = function(config, instance) {
+    if (typeof config.fileExtensions === 'string') {
+        instance._fileExtensions = [config.fileExtensions.toLowerCase()];
+    } else if (Array.isArray(config.fileExtensions)) {
+        instance._fileExtensions = config.fileExtensions.map(
+            function(s) {
+                return s.toLowerCase();
+            }
+        );
+    } else {
+        instance._fileExtensions = DEFAULT_FILE_EXTENSIONS;
+    }
+    delete config.fileExtensions;
+};

test/data/configs/fileExtensions/file-extensions-2.jS

@@ -0,0 +1 @@
+with (x) { y++; }

test/data/configs/fileExtensions/file-extensions.js

@@ -0,0 +1 @@
+with (x) { y++; }

test/data/configs/fileExtensions/file-extensions.jsx

@@ -0,0 +1 @@
+with (x) { y++; }

test/options/file-extensions.js

@@ -0,0 +1,111 @@
+var Checker = require('../../lib/checker');
+var assert = require('assert');
+
+describe('options/file-extensions', function() {
+    var checker;
+
+    beforeEach(function() {
+        checker = new Checker();
+        checker.registerDefaultRules();
+    });
+
+    describe('default config', function() {
+
+        beforeEach(function() {
+            checker.configure({
+                disallowKeywords: ['with']
+            });
+        });
+
+        it('should not report any errors for non-matching extensions with default config', function() {
+            assert(checker.checkFile('./test/data/configs/fileExtensions/file-extensions.jsx') === null);
+        });
+
+        it('should report errors for matching extensions with default config', function() {
+            // errors
+            assert(checker.checkFile('./test/data/configs/fileExtensions/file-extensions.js') !== null);
+        });
+
+        it('should report errors for matching extensions (case insensitive) with default config', function() {
+            // errors
+            assert(checker.checkFile('./test/data/configs/fileExtensions/file-extensions-2.jS') !== null);
+        });
+
+    });
+
+    describe('custom config', function() {
+
+        it('should not report any errors for non-matching extensions with custom config', function() {
+            checker.configure({
+                fileExtensions: ['.jsx'],
+                disallowKeywords: ['with']
+            });
+
+            assert(checker.checkFile('./test/data/configs/fileExtensions/file-extensions.js') === null);
+        });
+
+        it('should report errors for matching extensions with custom config', function() {
+            checker.configure({
+                fileExtensions: ['.jsx'],
+                disallowKeywords: ['with']
+            });
+
+            // errors
+            assert(checker.checkFile('./test/data/configs/fileExtensions/file-extensions.jsx') !== null);
+        });
+
+        it('should report errors for matching extensions (case insensitive) with custom config', function() {
+            checker.configure({
+                fileExtensions: ['.JS'],
+                disallowKeywords: ['with']
+            });
+
+            // errors
+            assert(checker.checkFile('./test/data/configs/fileExtensions/file-extensions-2.jS') !== null);
+        });
+
+        it('should report errors for matching extensions (case insensitive) with string value', function() {
+            checker.configure({
+                fileExtensions: '.JS',
+                disallowKeywords: ['with']
+            });
+
+            // errors
+            assert(checker.checkFile('./test/data/configs/fileExtensions/file-extensions-2.jS') !== null);
+        });
+
+        it('should report errors for matching extensions with custom config with multiple extensions', function() {
+            checker.configure({
+                fileExtensions: ['.js', '.jsx'],
+                disallowKeywords: ['with']
+            });
+
+            // errors
+            assert(checker.checkFile('./test/data/configs/fileExtensions/file-extensions.js') !== null);
+            assert(checker.checkFile('./test/data/configs/fileExtensions/file-extensions.jsx') !== null);
+        });
+
+        it('should report errors for matching extensions with Array *', function() {
+            checker.configure({
+                fileExtensions: ['*'],
+                disallowKeywords: ['with']
+            });
+
+            // errors
+            assert(checker.checkFile('./test/data/configs/fileExtensions/file-extensions.js') !== null);
+            assert(checker.checkFile('./test/data/configs/fileExtensions/file-extensions.jsx') !== null);
+        });
+
+        it('should report errors for matching extensions with string *', function() {
+            checker.configure({
+                fileExtensions: '*',
+                disallowKeywords: ['with']
+            });
+
+            // errors
+            assert(checker.checkFile('./test/data/configs/fileExtensions/file-extensions.js') !== null);
+            assert(checker.checkFile('./test/data/configs/fileExtensions/file-extensions.jsx') !== null);
+        });
+    });
+
+});