Preset: add "requireSpaceBetweenArguments" rule to all presets

markelog · Joel Kemp · commit 990e9bc8710c · 2015-02-05T13:03:31.000-05:00
Also corrects link to yandex code-style Fixes #940 Closes gh-996
diff --git a/lib/config/configuration.js b/lib/config/configuration.js
@@ -676,7 +676,7 @@ Configuration.prototype.registerDefaultPresets = function() {
     // https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript
     this.registerPreset('wikimedia', require('../../presets/wikimedia.json'));
 
-    // https://github.com/yandex/codestyle/blob/master/js.md
+    // https://github.com/yandex/codestyle/blob/master/javascript.md
     this.registerPreset('yandex', require('../../presets/yandex.json'));
 };
 
diff --git a/presets/airbnb.json b/presets/airbnb.json
@@ -40,6 +40,7 @@
     "requireCapitalizedConstructors": true,
     "requireDotNotation": true,
     "requireSpacesInForStatement": true,
+    "requireSpaceBetweenArguments": true,
     "requireCurlyBraces": [
         "do"
     ],
diff --git a/presets/crockford.json b/presets/crockford.json
@@ -31,6 +31,7 @@
     "disallowSpacesInFunctionDeclaration": {
         "beforeOpeningRoundBrace": true
     },
+    "requireSpaceBetweenArguments": true,
     "requireMultipleVarDecl": "onevar",
     "requireBlocksOnNewline": true,
     "disallowEmptyBlocks": true,
diff --git a/presets/jquery.json b/presets/jquery.json
@@ -15,6 +15,7 @@
     "requireCamelCaseOrUpperCaseIdentifiers": true,
     "requireDotNotation": "except_snake_case",
     "requireSpacesInForStatement": true,
+    "requireSpaceBetweenArguments": true,
     "maximumLineLength": {
         "value": 100,
         "tabSize": 4,
diff --git a/presets/mdcs.json b/presets/mdcs.json
@@ -15,6 +15,7 @@
     "validateIndentation": "\t",
 
     "requireSpaceAfterPrefixUnaryOperators": ["++", "--"],
+    "requireSpaceBetweenArguments": true,
     "requireSpaceBeforePostfixUnaryOperators": ["++", "--"],
     "requireSpaceBeforeBinaryOperators": [ "+", "-", "/", "*", "=", "==", "===", "!=", "!==", ">", ">=", "<", "<=" ],
     "requireSpaceAfterBinaryOperators": [ "+", "-", "/", "*", "=", "==", "===", "!=", "!==", ">", ">=", "<", "<=" ],
diff --git a/presets/wikimedia.json b/presets/wikimedia.json
@@ -32,6 +32,7 @@
     "requireSpaceBeforeObjectValues": true,
     "requireCommaBeforeLineBreak": true,
     "requireSpacesInForStatement": true,
+    "requireSpaceBetweenArguments": true,
     "disallowSpaceAfterPrefixUnaryOperators": true,
     "disallowSpaceBeforePostfixUnaryOperators": true,
     "disallowSpaceBeforeBinaryOperators": [
diff --git a/presets/yandex.json b/presets/yandex.json
@@ -38,6 +38,7 @@
     "disallowEmptyBlocks": true,
 
     "requireParenthesesAroundIIFE": true,
+    "requireSpaceBetweenArguments": true,
     "requireSpacesInFunctionDeclaration": {
         "beforeOpeningCurlyBrace": true
     },
diff --git a/test/data/options/preset/airbnb.js b/test/data/options/preset/airbnb.js
@@ -47,7 +47,8 @@
 
         // disallowEmptyBlocks
         return function() {
-          console.log('bar');
+          // requireSpaceBetweenArguments
+          console.log('bar', 'foo');
         }
       },
 
diff --git a/test/data/options/preset/crockford.js b/test/data/options/preset/crockford.js
@@ -82,6 +82,7 @@ APP = (function () {
         remove: function (key) {
             var at = keys.indexOf(key);
             if (at >= 0) {
+                // requireSpaceBetweenArguments
                 keys.splice(at, 1);
                 values.splice(at, 1);
             }
diff --git a/test/data/options/preset/google.js b/test/data/options/preset/google.js
@@ -27,6 +27,8 @@ var anonymousFunction = function() {};
 // requireSpaceAfterBinaryOperators
 // requireSpacesInConditionalExpression
 if (opts.insight === false) {
+
+  // requireSpaceBetweenArguments
   insight.config.set('optOut', true);
 } else if (opts.insight) {
   insight.config.set('optOut', false);
diff --git a/test/data/options/preset/grunt.js b/test/data/options/preset/grunt.js
@@ -57,3 +57,6 @@ grunt.tasks = function(tasks, options, done) {
     }
   });
 };
+
+// requireSpaceBetweenArguments
+console.log(1, 2);
diff --git a/test/data/options/preset/jquery.js b/test/data/options/preset/jquery.js
@@ -113,6 +113,8 @@ var each = function( obj, callback, args ) {
   if ( args ) {
     if ( isArray ) {
       for ( ; i < length; i++ ) {
+
+        // requireSpaceBetweenArguments
         value = callback.apply( obj[ i ], args );
         // requireSpaceAfterBinaryOperators
         if ( value === false ) {
diff --git a/test/data/options/preset/mdcs.js b/test/data/options/preset/mdcs.js
@@ -47,6 +47,9 @@ if ( i < l ) {
 
 }
 
+// requireSpaceBetweenArguments
+test(1, 2);
+
 //"requireSpaceAfterKeywords": ["for", "switch"]
 //"requireSpaceBeforeBlockStatements": true
 //"requireSpaceAfterPrefixUnaryOperators": ["++", "--"],
diff --git a/test/data/options/preset/wikimedia.js b/test/data/options/preset/wikimedia.js
@@ -84,6 +84,7 @@
 		}
 
 		for ( key in item ) {
+			// requireSpaceBetweenArguments
 			if ( hasOwn.call( item, key ) ) {
 				ret[ key ] = new APP.Example( item[ key ] );
 			}
diff --git a/test/data/options/preset/yandex.js b/test/data/options/preset/yandex.js
@@ -150,3 +150,6 @@ doAsync(function () {
  * @param {Number} [column]
  */
 var add = function (message, line, column) {};
+
+// requireSpaceBetweenArguments
+console.log(1, 2);

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,8 @@`
`47`	`47`
`48`	`48`	`// disallowEmptyBlocks`
`49`	`49`	`return function() {`
`50`		`- console.log('bar');`
	`50`	`+ // requireSpaceBetweenArguments`
	`51`	`+ console.log('bar', 'foo');`
`51`	`52`	`}`
`52`	`53`	`},`
`53`	`54`
Original file line number	Diff line number	Diff line change
`@@ -82,6 +82,7 @@ APP = (function () {`
`82`	`82`	`remove: function (key) {`
`83`	`83`	`var at = keys.indexOf(key);`
`84`	`84`	`if (at >= 0) {`
	`85`	`+ // requireSpaceBetweenArguments`
`85`	`86`	`keys.splice(at, 1);`
`86`	`87`	`values.splice(at, 1);`
`87`	`88`	`}`