Relative path resolving fix. Fixes #829

Author: mdevils

lib/config/configuration.js

@@ -49,12 +49,9 @@ Configuration.prototype.load = function(config) {
 
     var overrides = this._overrides;
     var currentConfig = {};
-    Object.keys(config).forEach(function(key) {
-        currentConfig[key] = config[key];
-    });
-    Object.keys(overrides).forEach(function(key) {
-        currentConfig[key] = overrides[key];
-    });
+
+    copyConfiguration(config, currentConfig);
+    copyConfiguration(overrides, currentConfig);
 
     var ruleSettings = this._processConfig(currentConfig);
     var processedSettings = {};
@@ -630,3 +627,12 @@ Configuration.prototype.registerDefaultPresets = function() {
 };
 
 module.exports = Configuration;
+
+function copyConfiguration(source, dest) {
+    Object.keys(source).forEach(function(key) {
+        dest[key] = source[key];
+    });
+    if (source.configPath) {
+        dest.configPath = source.configPath;
+    }
+}

test/cli.js

@@ -2,7 +2,6 @@ var hooker = require('hooker');
 var sinon = require('sinon');
 var glob = require('glob');
 var assert = require('assert');
-var Vow = require('vow');
 var hasAnsi = require('has-ansi');
 var rewire = require('rewire');
 
@@ -41,7 +40,13 @@ describe('modules/cli', function() {
 
     function assertNoCliErrors(vow) {
         return vow.promise.always(function() {
-            assert(console.log.getCall(0).args[0] === 'No code style errors found.');
+            var stdout = process.stdout.write.getCall(0) ? process.stdout.write.getCall(0).args[0] : '';
+            var stderr = process.stderr.write.getCall(0) ? process.stderr.write.getCall(0).args[0] : '';
+            assert.equal(
+                stdout,
+                'No code style errors found.\n',
+                stderr
+            );
             rAfter();
         });
     }
@@ -578,7 +583,7 @@ describe('modules/cli', function() {
 
         it('should accept a relative path to a filter module', function() {
             return assertNoCliErrors(cli({
-                errorFilter: './test/data/error-filter.js',
+                errorFilter: '../error-filter.js',
                 args: ['test/data/cli/error.js'],
                 config: 'test/data/cli/cli.json'
             }));
@@ -627,4 +632,13 @@ describe('modules/cli', function() {
             }));
         });
     });
+
+    describe('additionalRules', function() {
+        it('should correctly handle additionalRules paths', function() {
+            return assertNoCliErrors(cli({
+                args: ['test/data/cli/success.js'],
+                config: 'test/data/configs/additionalRules/.jscsrc'
+            }));
+        });
+    });
 });

test/data/cli/errorFilter.json

@@ -1,4 +1,4 @@
 {
-  "errorFilter": "./test/data/error-filter.js",
+  "errorFilter": "../error-filter.js",
   "disallowKeywords": ["with"]
 }

test/data/configs/additionalRules/.jscs.json

@@ -0,0 +1,6 @@
+{
+    "successRule": true,
+    "additionalRules": [
+        "./success-rule.js"
+    ]
+}

test/data/configs/additionalRules/.jscsrc

@@ -0,0 +1,12 @@
+module.exports = function() {};
+
+module.exports.prototype = {
+
+    configure: function() {},
+
+    getOptionName: function() {
+        return 'successRule';
+    },
+
+    check: function(file, errors) {}
+};