Hotfix: Fix binary rules for "," and "=" operators

Fixes #376

Author: markelog

lib/rules/disallow-space-after-binary-operators.js

@@ -43,7 +43,7 @@ module.exports.prototype = {
         if (operators[','] || operators['=']) {
             file.iterateTokensByType('Punctuator', function(token, i, tokens) {
                 var operator = token.value;
-                if (operator !== ',' && operator !== '=') {
+                if (operator !== ',' && operator !== '=' || !operators[operator]) {
                     return;
                 }
 

lib/rules/disallow-space-before-binary-operators.js

@@ -42,7 +42,7 @@ module.exports.prototype = {
         if (operators[','] || operators['=']) {
             file.iterateTokensByType('Punctuator', function(token, i, tokens) {
                 var operator = token.value;
-                if (operator !== ',' && operator !== '=') {
+                if (operator !== ',' && operator !== '=' || !operators[operator]) {
                     return;
                 }
 

lib/rules/require-space-after-binary-operators.js

@@ -43,7 +43,7 @@ module.exports.prototype = {
         if (operators[','] || operators['=']) {
             file.iterateTokensByType('Punctuator', function(token, i, tokens) {
                 var operator = token.value;
-                if (operator !== ',' && operator !== '=') {
+                if (operator !== ',' && operator !== '=' || !operators[operator]) {
                     return;
                 }
 

lib/rules/require-space-before-binary-operators.js

@@ -42,7 +42,7 @@ module.exports.prototype = {
         if (operators[','] || operators['=']) {
             file.iterateTokensByType('Punctuator', function(token, i, tokens) {
                 var operator = token.value;
-                if (operator !== ',' && operator !== '=') {
+                if (operator !== ',' && operator !== '=' || !operators[operator]) {
                     return;
                 }
 

test/rules/disallow-space-after-binary-operators.js

@@ -49,5 +49,9 @@ describe('rules/disallow-space-after-binary-operators', function() {
         checker.configure({ disallowSpaceAfterBinaryOperators: ['='] });
         assert(checker.checkString('a=b').isEmpty());
     });
+    it('should not report assignment operator for "a = b" without option', function() {
+        checker.configure({ disallowSpaceAfterBinaryOperators: [','] });
+        assert(checker.checkString('a = b').isEmpty());
+    });
 
 });

test/rules/disallow-space-before-binary-operators.js

@@ -49,4 +49,8 @@ describe('rules/disallow-space-before-binary-operators', function() {
         checker.configure({ disallowSpaceBeforeBinaryOperators: ['='] });
         assert(checker.checkString('a=b').isEmpty());
     });
+    it('should not report assignment operator for "a = b" without option', function() {
+        checker.configure({ disallowSpaceBeforeBinaryOperators: [','] });
+        assert(checker.checkString('a = b').isEmpty());
+    });
 });

test/rules/require-space-after-binary-operators.js

@@ -53,5 +53,9 @@ describe('rules/require-space-after-binary-operators', function() {
         checker.configure({ requireSpaceAfterBinaryOperators: ['='] });
         assert(checker.checkString('a=b').getErrorCount() === 1);
     });
+    it('should not report assignment operator for "a = b" without option', function() {
+        checker.configure({ requireSpaceAfterBinaryOperators: [','] });
+        assert(checker.checkString('a=b').isEmpty());
+    });
 
 });

test/rules/require-space-before-binary-operators.js

@@ -53,5 +53,9 @@ describe('rules/require-space-before-binary-operators', function() {
         checker.configure({ requireSpaceBeforeBinaryOperators: ['='] });
         assert(checker.checkString('a=b').getErrorCount() === 1);
     });
+    it('should not report assignment operator for "a = b" without option', function() {
+        checker.configure({ requireSpaceBeforeBinaryOperators: [','] });
+        assert(checker.checkString('a= b').isEmpty());
+    });
 
 });