Remove dev-dependency on CSharpGuidelinesAnalyzer

Author: bkoelman

.github/CONTRIBUTING.md

@@ -56,7 +56,7 @@ Please follow these steps to have your contribution considered by the maintainer
 - Follow all instructions in the template. Don't forget to add tests and update documentation.
 - After you submit your pull request, verify that all status checks are passing. In release builds, all compiler warnings are treated as errors, so you should address them before push.
 
-We use [CSharpGuidelines](https://csharpcodingguidelines.com/) as our coding standard. Coding style is validated during PR build, where we inject an extra settings layer that promotes various IDE suggestions to warning level. This ensures a high-quality codebase without interfering too much while editing code.
+Coding style is validated during PR build, where we inject an extra settings layer that promotes various IDE suggestions to warning level. This ensures a high-quality codebase without interfering too much while editing code.
 You can run the following [PowerShell scripts](https://github.com/PowerShell/PowerShell/releases) locally:
 - `pwsh ./inspectcode.ps1`: Scans the code for style violations and opens the result in your web browser.
 - `pwsh ./cleanupcode.ps1 [branch-name-or-commit-hash]`: Reformats the codebase to match with our configured style, optionally only changed files since the specified branch (usually master).

CSharpGuidelinesAnalyzer.config

@@ -1,29 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <RuleSet Name="Coding Guidelines" Description=" " ToolsVersion="17.0">
-  <Rules AnalyzerId="CSharpGuidelinesAnalyzer" RuleNamespace="CSharpGuidelinesAnalyzer">
-    <Rule Id="AV1008" Action="Warning" />
-    <Rule Id="AV1135" Action="None" />
-    <Rule Id="AV1500" Action="None" />
-    <Rule Id="AV1505" Action="Warning" />
-    <Rule Id="AV1506" Action="Warning" />
-    <Rule Id="AV1507" Action="Warning" />
-    <Rule Id="AV1536" Action="None" />
-    <Rule Id="AV1537" Action="None" />
-    <Rule Id="AV1551" Action="None" />
-    <Rule Id="AV1564" Action="None" />
-    <Rule Id="AV1568" Action="Warning" />
-    <Rule Id="AV1580" Action="None" />
-    <Rule Id="AV1704" Action="None" />
-    <Rule Id="AV1710" Action="None" />
-    <Rule Id="AV1711" Action="None" />
-    <Rule Id="AV1738" Action="Warning" />
-    <Rule Id="AV1739" Action="Warning" />
-    <Rule Id="AV1745" Action="Warning" />
-    <Rule Id="AV2220" Action="Warning" />
-    <Rule Id="AV2230" Action="Info" />
-    <Rule Id="AV2305" Action="None" />
-    <Rule Id="AV2318" Action="Warning" />
-  </Rules>
   <Rules AnalyzerId="Microsoft.CodeAnalysis.NetAnalyzers" RuleNamespace="Microsoft.CodeAnalysis.NetAnalyzers">
     <Rule Id="CA1027" Action="Warning" />
     <Rule Id="CA1033" Action="Warning" />

CodingGuidelines.ruleset

@@ -64,7 +64,5 @@
 
   <ItemGroup>
     <PackageReference Include="JetBrains.Annotations" Version="2025.2.*" PrivateAssets="All" />
-    <PackageReference Include="CSharpGuidelinesAnalyzer" Version="3.8.*" PrivateAssets="All" />
-    <AdditionalFiles Include="$(MSBuildThisFileDirectory)CSharpGuidelinesAnalyzer.config" Visible="False" />
   </ItemGroup>
 </Project>

Directory.Build.props

@@ -8,7 +8,6 @@
   <!-- Workaround for compiler regression at https://github.com/dotnet/roslyn/issues/80756 -->
   <Target Name="DisableSlowAnalyzers" Condition="'$(Configuration)' == 'Debug'" BeforeTargets="CoreCompile">
     <ItemGroup>
-      <Analyzer Remove="@(Analyzer)" Condition="'%(Filename)' == 'CSharpGuidelinesAnalyzer'" />
       <Analyzer Remove="@(Analyzer)" Condition="'%(Filename)' == 'Microsoft.CodeAnalysis.CSharp.CodeStyle'" />
       <Analyzer Remove="@(Analyzer)" Condition="'%(Filename)' == 'Microsoft.CodeAnalysis.NetAnalyzers'" />
       <Analyzer Remove="@(Analyzer)" Condition="'%(Filename)' == 'Microsoft.CodeAnalysis.CSharp.NetAnalyzers'" />

Directory.Build.targets

@@ -12,7 +12,6 @@
     <File Path=".github/workflows/build.yml" />
     <File Path=".gitignore" />
     <File Path="CodingGuidelines.ruleset" />
-    <File Path="CSharpGuidelinesAnalyzer.config" />
     <File Path="Directory.Build.props" />
     <File Path="package-versions.props" />
     <File Path="tests.runsettings" />

JsonApiDotNetCore.slnx

@@ -1,5 +1,3 @@
-#pragma warning disable AV1008 // Class should not be static
-
 namespace JsonApiDotNetCoreExample;
 
 internal static partial class AppLog

src/Examples/JsonApiDotNetCoreExample/AppLog.cs

@@ -2,7 +2,6 @@
 using JetBrains.Annotations;
 using SysNotNull = System.Diagnostics.CodeAnalysis.NotNullAttribute;
 
-#pragma warning disable AV1008 // Class should not be static
 #pragma warning disable format
 
 namespace JsonApiDotNetCore;

src/JsonApiDotNetCore.Annotations/ArgumentGuard.cs

@@ -2,8 +2,6 @@
 using System.Globalization;
 using JetBrains.Annotations;
 
-#pragma warning disable AV1008 // Class should not be static
-
 namespace JsonApiDotNetCore.Resources;
 
 /// <summary>

src/JsonApiDotNetCore.Annotations/Resources/RuntimeTypeConverter.cs

@@ -4,10 +4,6 @@
 
 // Adapted from https://github.com/PrismLibrary/Prism/blob/9.0.537/src/Prism.Core/Mvvm/BindableBase.cs for JsonApiDotNetCore.
 
-#pragma warning disable AV1553 // Do not use optional parameters with default value null for strings, collections or tasks
-#pragma warning disable AV1554 // Method contains optional parameter in type hierarchy
-#pragma warning disable AV1562 // Do not declare a parameter as ref or out
-
 namespace JsonApiDotNetCore.OpenApi.Client.NSwag;
 
 /// <summary>