Reverted changes in JsonApiObjects and PeopleMessageFormatter

Author: niteshsinghal85

src/Examples/OpenApiNSwagClientExample/PeopleMessageFormatter.cs

@@ -38,7 +38,7 @@ private static void WritePerson(DataInPersonResponse person, ICollection<Resourc
     {
         ICollection<TodoItemIdentifierInResponse> assignedTodoItems = person.Relationships?.AssignedTodoItems?.Data ?? [];
 
-        builder.AppendLine($"  Person {person.Id}: {person.Attributes?.DisplayName ?? string.Empty} with {assignedTodoItems.Count} assigned todo-items:");
+        builder.AppendLine($"  Person {person.Id}: {person.Attributes?.DisplayName} with {assignedTodoItems.Count} assigned todo-items:");
         WriteRelatedTodoItems(assignedTodoItems, includes, builder);
     }
 
@@ -50,7 +50,7 @@ private static void WriteRelatedTodoItems(IEnumerable<TodoItemIdentifierInRespon
             DataInTodoItemResponse includedTodoItem = includes.OfType<DataInTodoItemResponse>().Single(include => include.Id == todoItemIdentifier.Id);
             ICollection<TagIdentifierInResponse> tags = includedTodoItem.Relationships?.Tags?.Data ?? [];
 
-            builder.AppendLine($"    TodoItem {includedTodoItem.Id}: {includedTodoItem.Attributes?.Description ?? string.Empty} with {tags.Count} tags:");
+            builder.AppendLine($"    TodoItem {includedTodoItem.Id}: {includedTodoItem.Attributes?.Description} with {tags.Count} tags:");
             WriteRelatedTags(tags, includes, builder);
         }
     }
@@ -60,7 +60,7 @@ private static void WriteRelatedTags(IEnumerable<TagIdentifierInResponse> tagIde
         foreach (TagIdentifierInResponse tagIdentifier in tagIdentifiers)
         {
             DataInTagResponse includedTag = includes.OfType<DataInTagResponse>().Single(include => include.Id == tagIdentifier.Id);
-            builder.AppendLine($"      Tag {includedTag.Id}: {includedTag.Attributes?.Name ?? string.Empty}");
+            builder.AppendLine($"      Tag {includedTag.Id}: {includedTag.Attributes?.Name}");
         }
     }
 }

src/JsonApiDotNetCore.OpenApi.Swashbuckle/JsonApiObjects/AtomicOperations/AddToRelationshipOperation.cs

@@ -12,13 +12,13 @@ internal sealed class AddToRelationshipOperation<TResource> : AtomicOperation
 {
     [Required]
     [JsonPropertyName("op")]
-    public required string Op { get; set; }
+    public string Op { get; set; } = null!;
 
     [Required]
     [JsonPropertyName("ref")]
-    public required object Ref { get; set; }
+    public object Ref { get; set; } = null!;
 
     [Required]
     [JsonPropertyName("data")]
-    public required ICollection<IdentifierInRequest<TResource>> Data { get; set; }
+    public ICollection<IdentifierInRequest<TResource>> Data { get; set; } = null!;
 }

src/JsonApiDotNetCore.OpenApi.Swashbuckle/JsonApiObjects/AtomicOperations/AtomicOperation.cs

@@ -7,5 +7,5 @@ namespace JsonApiDotNetCore.OpenApi.Swashbuckle.JsonApiObjects.AtomicOperations;
 internal abstract class AtomicOperation : IHasMeta
 {
     [JsonPropertyName("meta")]
-    public required Meta Meta { get; set; }
+    public Meta Meta { get; set; } = null!;
 }

src/JsonApiDotNetCore.OpenApi.Swashbuckle/JsonApiObjects/AtomicOperations/AtomicResult.cs

@@ -8,8 +8,8 @@ namespace JsonApiDotNetCore.OpenApi.Swashbuckle.JsonApiObjects.AtomicOperations;
 internal sealed class AtomicResult : IHasMeta
 {
     [JsonPropertyName("data")]
-    public required ResourceInResponse Data { get; set; }
+    public ResourceInResponse Data { get; set; } = null!;
 
     [JsonPropertyName("meta")]
-    public required Meta Meta { get; set; }
+    public Meta Meta { get; set; } = null!;
 }

src/JsonApiDotNetCore.OpenApi.Swashbuckle/JsonApiObjects/AtomicOperations/CreateOperation.cs

@@ -12,9 +12,9 @@ internal sealed class CreateOperation<TResource> : AtomicOperation
 {
     [Required]
     [JsonPropertyName("op")]
-    public required string Op { get; set; }
+    public string Op { get; set; } = null!;
 
     [Required]
     [JsonPropertyName("data")]
-    public required DataInCreateRequest<TResource> Data { get; set; }
+    public DataInCreateRequest<TResource> Data { get; set; } = null!;
 }

src/JsonApiDotNetCore.OpenApi.Swashbuckle/JsonApiObjects/AtomicOperations/DeleteOperation.cs

@@ -12,9 +12,9 @@ internal sealed class DeleteOperation<TResource> : AtomicOperation
 {
     [Required]
     [JsonPropertyName("op")]
-    public required string Op { get; set; }
+    public string Op { get; set; } = null!;
 
     [Required]
     [JsonPropertyName("ref")]
-    public required IdentifierInRequest<TResource> Ref { get; set; }
+    public IdentifierInRequest<TResource> Ref { get; set; } = null!;
 }

src/JsonApiDotNetCore.OpenApi.Swashbuckle/JsonApiObjects/AtomicOperations/RemoveFromRelationshipOperation.cs

@@ -12,13 +12,13 @@ internal sealed class RemoveFromRelationshipOperation<TResource> : AtomicOperati
 {
     [Required]
     [JsonPropertyName("op")]
-    public required string Op { get; set; }
+    public string Op { get; set; } = null!;
 
     [Required]
     [JsonPropertyName("ref")]
-    public required object Ref { get; set; }
+    public object Ref { get; set; } = null!;
 
     [Required]
     [JsonPropertyName("data")]
-    public required ICollection<IdentifierInRequest<TResource>> Data { get; set; }
+    public ICollection<IdentifierInRequest<TResource>> Data { get; set; } = null!;
 }

src/JsonApiDotNetCore.OpenApi.Swashbuckle/JsonApiObjects/AtomicOperations/UpdateOperation.cs

@@ -12,12 +12,12 @@ internal sealed class UpdateOperation<TResource> : AtomicOperation
 {
     [Required]
     [JsonPropertyName("op")]
-    public required string Op { get; set; }
+    public string Op { get; set; } = null!;
 
     [JsonPropertyName("ref")]
-    public required IdentifierInRequest<TResource> Ref { get; set; }
+    public IdentifierInRequest<TResource> Ref { get; set; } = null!;
 
     [Required]
     [JsonPropertyName("data")]
-    public required DataInUpdateRequest<TResource> Data { get; set; }
+    public DataInUpdateRequest<TResource> Data { get; set; } = null!;
 }

src/JsonApiDotNetCore.OpenApi.Swashbuckle/JsonApiObjects/AtomicOperations/UpdateToManyRelationshipOperation.cs

@@ -12,13 +12,13 @@ internal sealed class UpdateToManyRelationshipOperation<TResource> : AtomicOpera
 {
     [Required]
     [JsonPropertyName("op")]
-    public required string Op { get; set; }
+    public string Op { get; set; } = null!;
 
     [Required]
     [JsonPropertyName("ref")]
-    public required object Ref { get; set; }
+    public object Ref { get; set; } = null!;
 
     [Required]
     [JsonPropertyName("data")]
-    public required ICollection<IdentifierInRequest<TResource>> Data { get; set; }
+    public ICollection<IdentifierInRequest<TResource>> Data { get; set; } = null!;
 }

src/JsonApiDotNetCore.OpenApi.Swashbuckle/JsonApiObjects/AtomicOperations/UpdateToOneRelationshipOperation.cs

@@ -12,11 +12,11 @@ internal sealed class UpdateToOneRelationshipOperation<TResource> : AtomicOperat
 {
     [Required]
     [JsonPropertyName("op")]
-    public required string Op { get; set; }
+    public string Op { get; set; } = null!;
 
     [Required]
     [JsonPropertyName("ref")]
-    public required object Ref { get; set; }
+    public object Ref { get; set; } = null!;
 
     [Required]
     [JsonPropertyName("data")]