fix warnings

Author: mrmarcosmagalhaes

test/JsonApiDotNetCoreTests/IntegrationTests/Meta/MetaFakers.cs

@@ -37,7 +37,7 @@ internal sealed class MetaFakers
         .CustomInstantiator(faker => new Dictionary<string, object?>
         {
             ["source"] = faker.PickRandom("ui", "api", "import"),
-            ["confidence"] = faker.Random.Double(0.1, 1.0)
+            ["confidence"] = faker.Random.Double(0.1)
         }));
 
     private readonly Lazy<Faker<Dictionary<string, object?>>> _lazyRelationshipIdentifierMetaFaker = new(() => new Faker<Dictionary<string, object?>>()

test/JsonApiDotNetCoreTests/IntegrationTests/Meta/OperationsRequestMetaTests.cs

@@ -156,7 +156,7 @@ public async Task Accepts_meta_in_relationship_of_atomic_add_resource_operation(
         Dictionary<string, object?> documentMeta = _fakers.DocumentMeta.GenerateOne();
         Dictionary<string, object?> resourceMeta = _fakers.ResourceMeta.GenerateOne();
         Dictionary<string, object?> relationshipMeta = _fakers.RelationshipMeta.GenerateOne();
-        var identifierMeta = _fakers.RelationshipIdentifierMeta.GenerateOne();
+        Dictionary<string, object?> identifierMeta = _fakers.RelationshipIdentifierMeta.GenerateOne();
 
         string newTicketDescription = _fakers.SupportTicket.GenerateOne().Description;
         ProductFamily existingFamily = _fakers.ProductFamily.GenerateOne();
@@ -308,6 +308,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
         operation.Data.Should().NotBeNull();
 
         operation.Data.SingleValue.Should().NotBeNull();
+
         operation.Data.SingleValue.Relationships.Should().ContainKey("productFamily").WhoseValue.With(value =>
         {
             value.Should().NotBeNull();
@@ -557,7 +558,7 @@ public async Task Accepts_meta_in_remove_from_relationship_operation()
 
         Dictionary<string, object?> documentMeta = _fakers.DocumentMeta.GenerateOne();
         Dictionary<string, object?> relationshipMeta = _fakers.RelationshipMeta.GenerateOne();
-        var identifierMeta = _fakers.RelationshipIdentifierMeta.GenerateOne();
+        Dictionary<string, object?> identifierMeta = _fakers.RelationshipIdentifierMeta.GenerateOne();
 
         ProductFamily existingFamily = _fakers.ProductFamily.GenerateOne();
         SupportTicket existingTicket1 = _fakers.SupportTicket.GenerateOne();

test/JsonApiDotNetCoreTests/IntegrationTests/Meta/RequestMetaTests.cs

@@ -46,7 +46,7 @@ public async Task Accepts_meta_in_update_resource_request_with_to_one_relationsh
         Dictionary<string, object?> documentMeta = _fakers.DocumentMeta.GenerateOne();
         Dictionary<string, object?> resourceMeta = _fakers.ResourceMeta.GenerateOne();
         Dictionary<string, object?> relationshipMeta = _fakers.RelationshipMeta.GenerateOne();
-        var identifierMeta = _fakers.RelationshipIdentifierMeta.GenerateOne();
+        Dictionary<string, object?> identifierMeta = _fakers.RelationshipIdentifierMeta.GenerateOne();
 
         SupportTicket existingTicket = _fakers.SupportTicket.GenerateOne();
         ProductFamily existingFamily = _fakers.ProductFamily.GenerateOne();
@@ -202,7 +202,7 @@ public async Task Accepts_meta_in_post_resource_request_with_to_one_relationship
         Dictionary<string, object?> documentMeta = _fakers.DocumentMeta.GenerateOne();
         Dictionary<string, object?> resourceMeta = _fakers.ResourceMeta.GenerateOne();
         Dictionary<string, object?> relationshipMeta = _fakers.RelationshipMeta.GenerateOne();
-        var identifierMeta = _fakers.RelationshipIdentifierMeta.GenerateOne();
+        Dictionary<string, object?> identifierMeta = _fakers.RelationshipIdentifierMeta.GenerateOne();
 
         string newTicketDescription = _fakers.SupportTicket.GenerateOne().Description;
         ProductFamily existingFamily = _fakers.ProductFamily.GenerateOne();
@@ -256,6 +256,7 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
         store.Document.Data.SingleValue.Meta.Should().BeEquivalentToJson(resourceMeta);
 
         store.Document.Data.SingleValue.Relationships.Should().NotBeNull();
+
         store.Document.Data.SingleValue.Relationships.Should().ContainKey("productFamily").WhoseValue.With(value =>
         {
             value.Should().NotBeNull();
@@ -434,13 +435,13 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
                 {
                     type = "supportTickets",
                     id = existingTicket1.StringId,
-                    meta = identifierMeta1,
+                    meta = identifierMeta1
                 },
                 new
                 {
                     type = "supportTickets",
                     id = existingTicket2.StringId,
-                    meta = identifierMeta2,
+                    meta = identifierMeta2
                 },
             },
             meta = documentMeta
@@ -495,13 +496,13 @@ await _testContext.RunOnDatabaseAsync(async dbContext =>
                 {
                     type = "supportTickets",
                     id = existingTicket1.StringId,
-                    meta = identifierMeta1,
+                    meta = identifierMeta1
                 },
                 new
                 {
                     type = "supportTickets",
                     id = existingTicket2.StringId,
-                    meta = identifierMeta2,
+                    meta = identifierMeta2
                 },
             },
             meta = documentMeta