Fixed R# warning: use string.Empty

Author: bkoelman

src/JsonApiDotNetCore/Middleware/JsonApiMiddleware.cs

@@ -98,7 +98,7 @@ public async Task InvokeAsync(HttpContext httpContext, IJsonApiRequest request)
         if (CodeTimingSessionManager.IsEnabled && _logger.IsEnabled(LogLevel.Information))
         {
             string timingResults = CodeTimingSessionManager.Current.GetResults();
-            string requestMethod = httpContext.Request.Method.Replace(Environment.NewLine, "");
+            string requestMethod = httpContext.Request.Method.Replace(Environment.NewLine, string.Empty);
             string requestUrl = httpContext.Request.GetEncodedUrl();
             LogMeasurement(requestMethod, requestUrl, Environment.NewLine, timingResults);
         }

src/JsonApiDotNetCore/Queries/Expressions/SortExpression.cs

@@ -48,7 +48,7 @@ public override string ToString()
 
     public override string ToFullString()
     {
-        return $"{string.Join(',', Elements.Select(child => child.ToFullString()))}{(IsAutoGenerated ? " (auto-generated)" : "")}";
+        return $"{string.Join(',', Elements.Select(child => child.ToFullString()))}{(IsAutoGenerated ? " (auto-generated)" : string.Empty)}";
     }
 
     public override bool Equals(object? obj)

src/JsonApiDotNetCore/Serialization/Request/JsonApiReader.cs

@@ -42,7 +42,7 @@ public JsonApiReader(IJsonApiOptions options, IDocumentAdapter documentAdapter,
 
         if (_logger.IsEnabled(LogLevel.Trace))
         {
-            string requestMethod = httpRequest.Method.Replace(Environment.NewLine, "");
+            string requestMethod = httpRequest.Method.Replace(Environment.NewLine, string.Empty);
             string requestUrl = httpRequest.GetEncodedUrl();
             LogRequest(requestMethod, requestUrl, requestBody);
         }

src/JsonApiDotNetCore/Serialization/Response/JsonApiWriter.cs

@@ -65,7 +65,7 @@ public async Task WriteAsync(object? model, HttpContext httpContext)
 
         if (_logger.IsEnabled(LogLevel.Trace))
         {
-            string requestMethod = httpContext.Request.Method.Replace(Environment.NewLine, "");
+            string requestMethod = httpContext.Request.Method.Replace(Environment.NewLine, string.Empty);
             string requestUrl = httpContext.Request.GetEncodedUrl();
             LogResponse(requestMethod, requestUrl, responseBody, httpContext.Response.StatusCode);
         }

test/JsonApiDotNetCoreTests/IntegrationTests/QueryStrings/Sorting/SortTests.cs

@@ -312,10 +312,10 @@ public async Task Can_sort_on_multiple_fields_in_multiple_scopes()
         blogs[0].Posts[1].Caption = "A";
         blogs[0].Posts[2].Caption = "A";
         blogs[0].Posts[3].Caption = "C";
-        blogs[0].Posts[0].Url = "";
+        blogs[0].Posts[0].Url = string.Empty;
         blogs[0].Posts[1].Url = "www.some2.com";
         blogs[0].Posts[2].Url = "www.some1.com";
-        blogs[0].Posts[3].Url = "";
+        blogs[0].Posts[3].Url = string.Empty;
 
         blogs[0].Posts[0].Comments = _fakers.Comment.GenerateSet(3);
         blogs[0].Posts[0].Comments.ElementAt(0).CreatedAt = 1.January(2015).AsUtc();

test/JsonApiDotNetCoreTests/UnitTests/QueryStringParameters/PaginationParseTests.cs

@@ -182,7 +182,7 @@ public void Reader_Read_Pagination_Succeeds(string? pageNumber, string? pageSize
         ResourceFieldChainExpression?[] scopeTrees = constraints.Select(expressionInScope => expressionInScope.Scope).ToArray();
 
         scopeTrees.Should().HaveSameCount(scopeTreesExpectedArray);
-        scopeTrees.Select(tree => tree?.ToString() ?? "").Should().BeEquivalentTo(scopeTreesExpectedArray, options => options.WithStrictOrdering());
+        scopeTrees.Select(tree => tree?.ToString() ?? string.Empty).Should().BeEquivalentTo(scopeTreesExpectedArray, options => options.WithStrictOrdering());
 
         string[] valueTreesExpectedArray = valueTreesExpected.Split("|");
         QueryExpression[] valueTrees = constraints.Select(expressionInScope => expressionInScope.Expression).ToArray();

test/TestBuildingBlocks/XUnitLoggerProvider.cs

@@ -145,7 +145,7 @@ private static string GetLogLevelString(LogLevel logLevel)
                 LogLevel.Warning => "WARN",
                 LogLevel.Error => "FAIL",
                 LogLevel.Critical => "CRIT",
-                LogLevel.None => "",
+                LogLevel.None => string.Empty,
                 _ => throw new ArgumentOutOfRangeException(nameof(logLevel))
             };
         }