handle out-of-range generation access

Author: kmaehashi

atwiki/core.py

@@ -56,7 +56,10 @@ def get_list(self, tag=None):
 
   def get_source(self, page_id, generation=0):
     soup = self._request(self._uri.backup_source(page_id, generation))
-    return soup.find('pre', attrs={'class': 'cmd_backup'}).text.replace('\r', '')
+    pre = soup.find('pre', attrs={'class': 'cmd_backup'})
+    if not pre:
+      raise IndexError('page {0}: generation {1} out of range'.format(page_id, generation))
+    return pre.text.replace('\r', '')
 
   def search(self, keyword, is_and=True):
     soup = self._request(self._uri.search(keyword, is_and))

atwiki/test/test_core.py

@@ -33,6 +33,9 @@ def test_get_source_special(self):
     self.assertEqual(self._api.get_source(15, 0),
                      '"テスト1"<br>&\n"テスト2"<br>&')
 
+  def test_get_source_invalid(self):
+    self.assertRaises(IndexError, self._api.get_source, 15, -1)
+
   def test_search(self):
     results = list(self._api.search('SearchKeyword01 SearchKeyword02'))
     self.assertEqual(len(results), 1)