Merge pull request #19 from lambdaclass/account_inclusion_verifier

Proof of Account verifier

Author: gabrielbosio

.github/workflows/build-go.yml

@@ -30,6 +30,8 @@ jobs:
         run: make build_merkle_tree_linux
       - name: Build Mina bindings
         run: make build_mina_linux
+      - name: Build Mina Account bindings
+        run: make build_mina_account_linux
       - name: Build operator
         run: go build operator/cmd/main.go
       - name: Build aggregator

Makefile

@@ -644,6 +644,27 @@ test_mina_go_bindings_linux: build_mina_linux
 	@echo "Testing Mina Go bindings..."
 	go test ./operator/mina/... -v
 
+__MINA_ACCOUNT_FFI__: ##
+build_mina_account_macos:
+	@cd operator/mina_account/lib && cargo build --release
+	@cp operator/mina_account/lib/target/release/libmina_account_verifier_ffi.dylib operator/mina_account/lib/libmina_account_verifier.dylib
+
+build_mina_account_linux:
+	@cd operator/mina_account/lib && cargo build --release
+	@cp operator/mina_account/lib/target/release/libmina_account_verifier_ffi.so operator/mina_account/lib/libmina_account_verifier.so
+
+test_mina_account_rust_ffi:
+	@echo "Testing Mina Account Rust FFI source code..."
+	@cd operator/mina_account/lib && cargo t --release
+
+test_mina_account_go_bindings_macos: build_mina_account_macos
+	@echo "Testing Mina Account Go bindings..."
+	go test ./operator/mina_account/... -v
+
+test_mina_account_go_bindings_linux: build_mina_linux
+	@echo "Testing Mina Account Go bindings..."
+	go test ./operator/mina_account/... -v
+
 __BUILD_ALL_FFI__:
 
 build_all_ffi: ## Build all FFIs
@@ -657,6 +678,8 @@ build_all_ffi_macos: ## Build all FFIs for macOS
 	@$(MAKE) build_merkle_tree_macos
 	@$(MAKE) build_halo2_ipa_macos
 	@$(MAKE) build_halo2_kzg_macos
+	@$(MAKE) build_mina_macos
+	@$(MAKE) build_mina_account_macos
 	@echo "All macOS FFIs built successfully."
 
 build_all_ffi_linux: ## Build all FFIs for Linux
@@ -666,6 +689,8 @@ build_all_ffi_linux: ## Build all FFIs for Linux
 	@$(MAKE) build_merkle_tree_linux
 	@$(MAKE) build_halo2_ipa_linux
 	@$(MAKE) build_halo2_kzg_linux
+	@$(MAKE) build_mina_linux
+	@$(MAKE) build_mina_account_linux
 	@echo "All Linux FFIs built successfully."
 
 

aggregator/cmd/main.go

@@ -7,7 +7,9 @@ import (
 	"os"
 
 	"github.com/urfave/cli/v2"
-	"github.com/yetanotherco/aligned_layer/aggregator/internal/pkg"
+  // TODO(xqft): used lambdaclass below as a temporary solution, can't
+  // import the internal package when in presence of a replace directive.
+  "github.com/lambdaclass/aligned_layer/aggregator/internal/pkg"
 	"github.com/yetanotherco/aligned_layer/core/config"
 )
 

batcher/aligned-batcher/src/mina/mod.rs

@@ -60,7 +60,8 @@ pub fn check_state(pub_inputs: &[u8], offset: &mut usize) -> Result<(), String>
 pub fn check_pub_inputs(pub_inputs: &[u8]) -> Result<(), String> {
     let mut offset = 0;
 
-    check_hash(pub_inputs, &mut offset)?; // candidate hash
+    check_hash(pub_inputs, &mut offset)?; // candidate ledger hash
+    check_hash(pub_inputs, &mut offset)?; // candidate state hash
     check_hash(pub_inputs, &mut offset)?; // tip hash
 
     check_state(pub_inputs, &mut offset)?; // candidate state

batcher/aligned-batcher/src/zk_utils/mod.rs

@@ -98,5 +98,14 @@ fn verify_internal(verification_data: &VerificationData) -> bool {
             // verifier. These checks are fast and if they aren't successful then the Pickles proof
             // isn't valid.
         }
+        ProvingSystemId::MinaAccount => {
+            verification_data
+                .pub_input
+                .as_ref()
+                .expect("Public input is required");
+            true
+            // TODO(xqft): add basic integrity checks (e.g. length of merkle proof being multiple of 32
+            // bytes, etc)
+        }
     }
 }

batcher/aligned-sdk/src/core/types.rs

@@ -20,6 +20,7 @@ pub enum ProvingSystemId {
     Halo2IPA,
     Risc0,
     Mina,
+    MinaAccount,
 }
 
 #[derive(Debug, Serialize, Deserialize, Clone)]

batcher/aligned/src/main.rs

@@ -228,6 +228,8 @@ pub enum ProvingSystemArg {
     Risc0,
     #[clap(name = "Mina")]
     Mina,
+    #[clap(name = "MinaAccount")]
+    MinaAccount,
 }
 
 const ANVIL_PRIVATE_KEY: &str = "2a871d0798f97d79848a013d4936a73bf4cc922c825d33c1cf7073dff6d409c6"; // Anvil address 9
@@ -243,6 +245,7 @@ impl From<ProvingSystemArg> for ProvingSystemId {
             ProvingSystemArg::Halo2IPA => ProvingSystemId::Halo2IPA,
             ProvingSystemArg::Risc0 => ProvingSystemId::Risc0,
             ProvingSystemArg::Mina => ProvingSystemId::Mina,
+            ProvingSystemArg::MinaAccount => ProvingSystemId::MinaAccount,
         }
     }
 }
@@ -577,6 +580,12 @@ fn verification_data_from_args(args: SubmitArgs) -> Result<VerificationData, Sub
                 args.pub_input_file_name,
             )?)
         }
+        ProvingSystemId::MinaAccount => {
+            pub_input = Some(read_file_option(
+                "--public_input",
+                args.pub_input_file_name,
+            )?)
+        }
     }
 
     let proof_generator_addr = Address::from_str(&args.proof_generator_addr).map_err(|e| {

batcher/aligned/test_files/mina/account_B62qrQKS9ghd91shs73TCmBJRW9GzvTJK443DPx2YbqcyoLc56g1ny9.proof

@@ -0,0 +1 @@
+������F6:|��+���!�y��(�޻[�!nV�6�z[2�5��)l�˄nP���-:]��r4�b'I������uǬ9#.h��x3b@��lv�矖@�