lint it

Author: nimarb

langfuse/model.py

@@ -321,23 +321,6 @@ def __init__(self, prompt: Prompt_Chat, is_fallback: bool = False):
                         content=p.content,
                     ),
                 )
-            # Handle plain dictionaries (fallback case)
-            elif isinstance(p, dict):
-                if p.get("type") == "placeholder" and "name" in p:
-                    self.prompt.append(
-                        ChatMessageWithPlaceholdersDict_Placeholder(
-                            type="placeholder",
-                            name=p["name"],
-                        ),
-                    )
-                elif "role" in p and "content" in p:
-                    self.prompt.append(
-                        ChatMessageWithPlaceholdersDict_Message(
-                            type="message",
-                            role=p["role"],
-                            content=p["content"],
-                        ),
-                    )
 
     def compile(
         self, **kwargs

tests/test_prompt.py

@@ -276,25 +276,30 @@ def test_get_prompt_with_placeholders():
                 "Help me with coding",
             ],  # None = placeholder
         ),
-        # 5. Placeholder with non-list value (should log warning and create invalid dict)
+        # 5. Placeholder with non-list value (should log warning and append as string)
         (
             {"role": "helpful", "task": "coding"},
             {"examples": "not a list"},
             3,
             [
                 "You are a helpful assistant",
-                "{'not a list'}",  # Invalid dict becomes string when checked
+                "not a list",  # String value appended directly
                 "Help me with coding",
             ],
         ),
         # 6. Placeholder with invalid message structure (should log warning and include both)
         (
             {"role": "helpful", "task": "coding"},
-            {"examples": ["invalid message", {"role": "user", "content": "valid message"}]},
+            {
+                "examples": [
+                    "invalid message",
+                    {"role": "user", "content": "valid message"},
+                ]
+            },
             4,
             [
                 "You are a helpful assistant",
-                "{\"['invalid message', {'role': 'user', 'content': 'valid message'}]\"}",  # Invalid structure becomes string
+                "['invalid message', {'role': 'user', 'content': 'valid message'}]",  # Invalid structure becomes string
                 "valid message",  # Valid message processed normally
                 "Help me with coding",
             ],
@@ -330,9 +335,9 @@ def test_compile_with_placeholders(
         if expected_content is None:
             # This should be an unresolved placeholder
             assert "type" in result[i] and result[i]["type"] == "placeholder"
-        elif expected_content.startswith("{") and expected_content.endswith("}"):
-            # This is an invalid dictionary that becomes a string representation
-            assert str(result[i]) == expected_content
+        elif isinstance(result[i], str):
+            # This is a string value from invalid placeholder
+            assert result[i] == expected_content
         else:
             # This should be a regular message
             assert "content" in result[i]

tests/test_prompt_compilation.py

@@ -827,7 +827,8 @@ def test_get_langchain_prompt_with_unresolved_placeholders(self):
 
         # Call get_langchain_prompt without resolving placeholder
         langchain_messages = prompt_client.get_langchain_prompt(
-            role="helpful", task="coding",
+            role="helpful",
+            task="coding",
         )
 
         # Should have 3 items: system message, MessagesPlaceholder, user message