chore: pr comments

Author: Steffen911

langfuse/_client/client.py

@@ -6,6 +6,7 @@
 import asyncio
 import logging
 import os
+import json
 import re
 import urllib.parse
 import warnings
@@ -3631,16 +3632,14 @@ def metadata(
         # Set attributes on currently active span if exists
         current_span = otel_trace_api.get_current_span()
         if current_span is not None and current_span.is_recording():
-            import json as json_module
-
             for key, value in kwargs.items():
                 attr_key = f"langfuse.metadata.{key}"
                 # Convert value to appropriate type for span attribute
                 if isinstance(value, (str, int, float, bool)):
                     attr_value = value
                 else:
                     # For complex types, convert to JSON string
-                    attr_value = json_module.dumps(value)
+                    attr_value = json.dumps(value)
                 current_span.set_attribute(attr_key, attr_value)
 
         # Set baggage if requested
@@ -3653,10 +3652,7 @@ def metadata(
             for key, value in kwargs.items():
                 # Convert value to string and truncate if needed for baggage
                 str_value = str(value)
-                if len(str_value) > 200:
-                    str_value = str_value[:200]
-
-                baggage_key = f"metadata.{key}"
+                baggage_key = f"langfuse.metadata.{key}"
                 new_baggage = otel_baggage_api.set_baggage(
                     baggage_key, str_value, new_baggage
                 )

langfuse/_client/span.py

@@ -16,6 +16,7 @@
 from datetime import datetime
 from time import time_ns
 import warnings
+import json
 from typing import (
     TYPE_CHECKING,
     Any,
@@ -1291,16 +1292,14 @@ def metadata(
         # Set attributes on currently active span if exists
         current_span = otel_trace_api.get_current_span()
         if current_span is not None and current_span.is_recording():
-            import json as json_module
-
             for key, value in kwargs.items():
                 attr_key = f"langfuse.metadata.{key}"
                 # Convert value to appropriate type for span attribute
                 if isinstance(value, (str, int, float, bool)):
                     attr_value = value
                 else:
                     # For complex types, convert to JSON string
-                    attr_value = json_module.dumps(value)
+                    attr_value = json.dumps(value)
                 current_span.set_attribute(attr_key, attr_value)
 
         # Set baggage if requested
@@ -1313,10 +1312,7 @@ def metadata(
             for key, value in kwargs.items():
                 # Convert value to string and truncate if needed for baggage
                 str_value = str(value)
-                if len(str_value) > 200:
-                    str_value = str_value[:200]
-
-                baggage_key = f"metadata.{key}"
+                baggage_key = f"langfuse.metadata.{key}"
                 new_baggage = otel_baggage_api.set_baggage(
                     baggage_key, str_value, new_baggage
                 )