@@ -309,7 +309,8 @@ def __init__(self, prompt: Prompt_Chat, is_fallback: bool = False):
309309 @property
310310 def prompt (self ) -> List [Union [ChatMessageDict , ChatMessagePlaceholderDict ]]:
311311 """Returns the prompt with placeholders substituted for their values.
312- If no placeholders are set and raw_prompt contains placeholders, returns only messages.
312+ If no placeholder fill-ins are set and raw_prompt contains placeholders, returns messages and placeholders
313+ with a warning.
313314 """
314315 compiled_messages = []
315316 has_unresolved_placeholders = False
@@ -345,8 +346,8 @@ def prompt(self) -> List[Union[ChatMessageDict, ChatMessagePlaceholderDict]]:
345346 msg ["name" ] for msg in self .raw_prompt if msg ["type" ] == "placeholder"
346347 ]
347348 err_unresolved_placeholders = f"Placeholders { unresolved } have no values set. Use update() to set placeholder values."
349+ # Warning because users might want to further process placeholders as well
348350 langfuse_logger .warning (err_unresolved_placeholders )
349- # raise ValueError(err_unresolved_placeholders)
350351 elif has_unresolved_placeholders :
351352 unresolved = [
352353 msg ["name" ]
@@ -355,8 +356,8 @@ def prompt(self) -> List[Union[ChatMessageDict, ChatMessagePlaceholderDict]]:
355356 and msg ["name" ] not in self .placeholder_fillins
356357 ]
357358 err_unresolved_placeholders = f"Placeholders { unresolved } have no values set. Use update() to set placeholder values."
359+ # Warning because users might want to further process placeholders as well
358360 langfuse_logger .warning (err_unresolved_placeholders )
359- # raise ValueError(err_unresolved_placeholders)
360361
361362 return compiled_messages
362363
@@ -374,15 +375,15 @@ def prompt(
374375 ChatMessageWithPlaceholdersDict_Placeholder (
375376 type = "placeholder" ,
376377 name = p .name ,
377- )
378+ ),
378379 )
379380 elif hasattr (p , "role" ) and hasattr (p , "content" ):
380381 self .raw_prompt .append (
381382 ChatMessageWithPlaceholdersDict_Message (
382383 type = "message" ,
383384 role = p .role ,
384385 content = p .content ,
385- )
386+ ),
386387 )
387388
388389 self .placeholder_fillins = {} # Clear because user expects old placeholders not to linger
0 commit comments