Skip to content

Commit 9c8e3bb

Browse files
hassiebphassiebp
committed
push
1 parent f6f80c3 commit 9c8e3bb

4 files changed

Lines changed: 139 additions & 84 deletions

File tree

‎langfuse/_client/observe.py‎

Lines changed: 18 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -313,13 +313,17 @@ async def async_wrapper(*args: Tuple[Any], **kwargs: Dict[str, Any]) -> Any:
313313
)
314314

315315
# handle starlette.StreamingResponse
316-
if type(result).__name__ == "StreamingResponse" and hasattr(result, "body_iterator"):
316+
if type(result).__name__ == "StreamingResponse" and hasattr(
317+
result, "body_iterator"
318+
):
317319
is_return_type_generator = True
318320

319-
result.body_iterator = self._wrap_async_generator_result(
320-
langfuse_span_or_generation,
321-
result.body_iterator,
322-
transform_to_string,
321+
result.body_iterator = (
322+
self._wrap_async_generator_result(
323+
langfuse_span_or_generation,
324+
result.body_iterator,
325+
transform_to_string,
326+
)
323327
)
324328

325329
langfuse_span_or_generation.update(output=result)
@@ -427,13 +431,17 @@ def sync_wrapper(*args: Any, **kwargs: Any) -> Any:
427431
)
428432

429433
# handle starlette.StreamingResponse
430-
if type(result).__name__ == "StreamingResponse" and hasattr(result, "body_iterator"):
434+
if type(result).__name__ == "StreamingResponse" and hasattr(
435+
result, "body_iterator"
436+
):
431437
is_return_type_generator = True
432438

433-
result.body_iterator = self._wrap_async_generator_result(
434-
langfuse_span_or_generation,
435-
result.body_iterator,
436-
transform_to_string,
439+
result.body_iterator = (
440+
self._wrap_async_generator_result(
441+
langfuse_span_or_generation,
442+
result.body_iterator,
443+
transform_to_string,
444+
)
437445
)
438446

439447
langfuse_span_or_generation.update(output=result)

‎langfuse/_client/span.py‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,9 @@ def __init__(
190190
{k: v for k, v in attributes.items() if v is not None}
191191
)
192192
# Set OTEL span status if level is ERROR
193-
self._set_otel_span_status_if_error(level=level, status_message=status_message)
193+
self._set_otel_span_status_if_error(
194+
level=level, status_message=status_message
195+
)
194196

195197
def end(self, *, end_time: Optional[int] = None) -> "LangfuseObservationWrapper":
196198
"""End the span, marking it as completed.
@@ -544,7 +546,7 @@ def _process_media_in_attribute(
544546
return data
545547

546548
def _set_otel_span_status_if_error(
547-
self, *, level: Optional[SpanLevel] = None, status_message: Optional[str] = None
549+
self, *, level: Optional[SpanLevel] = None, status_message: Optional[str] = None
548550
) -> None:
549551
"""Set OpenTelemetry span status to ERROR if level is ERROR.
550552

‎tests/test_core_sdk.py‎

Lines changed: 37 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,7 @@ def test_create_update_current_trace():
338338
user_id="test",
339339
metadata={"key": "value"},
340340
public=True,
341-
input="test_input"
341+
input="test_input",
342342
)
343343
# Get trace ID for later reference
344344
trace_id = span.trace_id
@@ -347,7 +347,9 @@ def test_create_update_current_trace():
347347
sleep(1)
348348

349349
# Update trace properties using update_current_trace
350-
langfuse.update_current_trace(metadata={"key2": "value2"}, public=False, version="1.0")
350+
langfuse.update_current_trace(
351+
metadata={"key2": "value2"}, public=False, version="1.0"
352+
)
351353

352354
# Ensure data is sent to the API
353355
langfuse.flush()
@@ -1957,9 +1959,9 @@ def test_start_as_current_observation_types():
19571959
expected_types = {obs_type.upper() for obs_type in observation_types} | {
19581960
"SPAN"
19591961
} # includes parent span
1960-
assert expected_types.issubset(found_types), (
1961-
f"Missing types: {expected_types - found_types}"
1962-
)
1962+
assert expected_types.issubset(
1963+
found_types
1964+
), f"Missing types: {expected_types - found_types}"
19631965

19641966
# Verify each specific observation exists
19651967
for obs_type in observation_types:
@@ -2003,25 +2005,25 @@ def test_that_generation_like_properties_are_actually_created():
20032005
) as obs:
20042006
# Verify the properties are accessible on the observation object
20052007
if hasattr(obs, "model"):
2006-
assert obs.model == test_model, (
2007-
f"{obs_type} should have model property"
2008-
)
2008+
assert (
2009+
obs.model == test_model
2010+
), f"{obs_type} should have model property"
20092011
if hasattr(obs, "completion_start_time"):
2010-
assert obs.completion_start_time == test_completion_start_time, (
2011-
f"{obs_type} should have completion_start_time property"
2012-
)
2012+
assert (
2013+
obs.completion_start_time == test_completion_start_time
2014+
), f"{obs_type} should have completion_start_time property"
20132015
if hasattr(obs, "model_parameters"):
2014-
assert obs.model_parameters == test_model_parameters, (
2015-
f"{obs_type} should have model_parameters property"
2016-
)
2016+
assert (
2017+
obs.model_parameters == test_model_parameters
2018+
), f"{obs_type} should have model_parameters property"
20172019
if hasattr(obs, "usage_details"):
2018-
assert obs.usage_details == test_usage_details, (
2019-
f"{obs_type} should have usage_details property"
2020-
)
2020+
assert (
2021+
obs.usage_details == test_usage_details
2022+
), f"{obs_type} should have usage_details property"
20212023
if hasattr(obs, "cost_details"):
2022-
assert obs.cost_details == test_cost_details, (
2023-
f"{obs_type} should have cost_details property"
2024-
)
2024+
assert (
2025+
obs.cost_details == test_cost_details
2026+
), f"{obs_type} should have cost_details property"
20252027

20262028
langfuse.flush()
20272029

@@ -2035,28 +2037,28 @@ def test_that_generation_like_properties_are_actually_created():
20352037
for obs in trace.observations
20362038
if obs.name == f"test-{obs_type}" and obs.type == obs_type.upper()
20372039
]
2038-
assert len(observations) == 1, (
2039-
f"Expected one {obs_type.upper()} observation, but found {len(observations)}"
2040-
)
2040+
assert (
2041+
len(observations) == 1
2042+
), f"Expected one {obs_type.upper()} observation, but found {len(observations)}"
20412043

20422044
obs = observations[0]
20432045

20442046
assert obs.model == test_model, f"{obs_type} should have model property"
2045-
assert obs.model_parameters == test_model_parameters, (
2046-
f"{obs_type} should have model_parameters property"
2047-
)
2047+
assert (
2048+
obs.model_parameters == test_model_parameters
2049+
), f"{obs_type} should have model_parameters property"
20482050

20492051
# usage_details
20502052
assert hasattr(obs, "usage_details"), f"{obs_type} should have usage_details"
2051-
assert obs.usage_details == dict(test_usage_details, total=30), (
2052-
f"{obs_type} should persist usage_details"
2053-
) # API adds total
2053+
assert obs.usage_details == dict(
2054+
test_usage_details, total=30
2055+
), f"{obs_type} should persist usage_details" # API adds total
20542056

2055-
assert obs.cost_details == test_cost_details, (
2056-
f"{obs_type} should persist cost_details"
2057-
)
2057+
assert (
2058+
obs.cost_details == test_cost_details
2059+
), f"{obs_type} should persist cost_details"
20582060

20592061
# completion_start_time, because of time skew not asserting time
2060-
assert obs.completion_start_time is not None, (
2061-
f"{obs_type} should persist completion_start_time property"
2062-
)
2062+
assert (
2063+
obs.completion_start_time is not None
2064+
), f"{obs_type} should persist completion_start_time property"

0 commit comments

Comments
 (0)