migrate test_core_sdk

Author: hassiebp

langfuse/_client/client.py

@@ -203,6 +203,7 @@ def __init__(
             )
 
         self._mask = mask
+        self.project_id = None
 
         # Initialize api and tracer if requirements are met
         self.langfuse_tracer = LangfuseTracer(
@@ -309,6 +310,7 @@ def start_span(
             metadata=metadata,
         )
 
+    # TODO: add return typing
     def start_as_current_span(
         self,
         *,

langfuse/_client/span.py

@@ -85,7 +85,7 @@ def __init__(
         self._langfuse_client = langfuse_client
 
         self.trace_id = self._langfuse_client._get_otel_trace_id(otel_span)
-        self.observation_id = self._langfuse_client._get_otel_span_id(otel_span)
+        self.id = self._langfuse_client._get_otel_span_id(otel_span)
 
         # Handle media only if span is sampled
         if self._otel_span.is_recording:
@@ -122,6 +122,8 @@ def end(self, *, end_time: Optional[int] = None):
         """
         self._otel_span.end(end_time=end_time)
 
+        return self
+
     @abstractmethod
     def update(self, **kwargs) -> Union["LangfuseSpan", "LangfuseGeneration"]:
         """Update the span with new information.
@@ -257,7 +259,7 @@ def score(
             name=name,
             value=cast(str, value),
             trace_id=self.trace_id,
-            observation_id=self.observation_id,
+            observation_id=self.id,
             score_id=score_id,
             data_type=cast(Literal["CATEGORICAL"], data_type),
             comment=comment,
@@ -462,7 +464,7 @@ def _process_media_in_attribute(
             data=data,
             field=field,
             trace_id=self.trace_id,
-            observation_id=self.observation_id,
+            observation_id=self.id,
             project_id=self._langfuse_client.langfuse_tracer.project_id,
         )
 

langfuse/_client/tracer.py

@@ -247,7 +247,7 @@ def _initialize_instance(
             f"public_key={self.public_key} | "
             f"host={host} | "
             f"environment={environment or 'default'} | "
-            f"sample_rate={sample_rate or 1.0} | "
+            f"sample_rate={sample_rate if sample_rate is not None else 1.0} | "
             f"media_threads={media_upload_thread_count or 1}"
         )
 
@@ -419,7 +419,7 @@ def _init_tracer_provider(
     if isinstance(default_provider, otel_trace_api.ProxyTracerProvider):
         provider = TracerProvider(
             resource=resource,
-            sampler=TraceIdRatioBased(sample_rate) if sample_rate else None,
+            sampler=TraceIdRatioBased(sample_rate) if sample_rate is not None else None,
         )
         otel_trace_api.set_tracer_provider(provider)