simplify

Author: nimarb

langfuse/_client/constants.py

@@ -27,21 +27,6 @@ class ObservationType(str, enum.Enum):
     EVALUATOR = "EVALUATOR"
     GUARDRAIL = "GUARDRAIL"
 
-
-# Valid observation types for the @observe decorator (lowercase user interface)
-VALID_OBSERVATION_TYPES = {
-    "span",
-    "event",
-    "generation",
-    "agent",
-    "tool",
-    "chain",
-    "retriever",
-    "evaluator",
-    "embedding",
-    "guardrail",
-}
-
 ObservationTypeLiteralNoEvent: TypeAlias = Literal[
     "span",
     "generation",

langfuse/_client/observe.py

@@ -16,6 +16,7 @@
     Union,
     cast,
     overload,
+    get_args,
 )
 
 from opentelemetry.util._decorator import _AgnosticContextManager
@@ -26,7 +27,6 @@
 )
 
 from langfuse._client.constants import (
-    VALID_OBSERVATION_TYPES,
     ObservationTypeLiteralNoEvent,
 )
 from langfuse._client.get_client import _set_current_public_key, get_client
@@ -169,9 +169,10 @@ def sub_process():
             - For async functions, the decorator returns an async function wrapper.
             - For sync functions, the decorator returns a synchronous wrapper.
         """
-        if as_type is not None and as_type not in VALID_OBSERVATION_TYPES:
+        valid_types = set(get_args(ObservationTypeLiteralNoEvent))
+        if as_type is not None and as_type not in valid_types:
             self._log.warning(
-                f"Invalid as_type '{as_type}'. Valid types are: {', '.join(sorted(VALID_OBSERVATION_TYPES))}. Defaulting to 'span'."
+                f"Invalid as_type '{as_type}'. Valid types are: {', '.join(sorted(valid_types))}. Defaulting to 'span'."
             )
             as_type = "span"