fix score sampling issue

Author: hassiebp

langfuse/_client/client.py

@@ -1348,7 +1348,15 @@ def create_score(
             }
 
             if self._resources is not None:
-                self._resources.add_score_task(event)
+                # Force the score to be in sample if it was for a legacy trace ID, i.e. non-32 hexchar
+                force_sample = (
+                    not self._is_valid_trace_id(trace_id) if trace_id else True
+                )
+
+                self._resources.add_score_task(
+                    event,
+                    force_sample=force_sample,
+                )
 
         except Exception as e:
             langfuse_logger.exception(

langfuse/_client/resource_manager.py

@@ -258,11 +258,11 @@ def _initialize_instance(
     def reset(cls):
         cls._instances.clear()
 
-    def add_score_task(self, event: dict):
+    def add_score_task(self, event: dict, *, force_sample: bool = False):
         try:
             # Sample scores with the same sampler that is used for tracing
             tracer_provider = cast(TracerProvider, otel_trace_api.get_tracer_provider())
-            should_sample = (
+            should_sample = force_sample or (
                 (
                     tracer_provider.sampler.should_sample(
                         parent_context=None,