Skip to content

Commit f5f2cac

Browse files
committed
push
1 parent 00565f6 commit f5f2cac

3 files changed

Lines changed: 11 additions & 13 deletions

File tree

langfuse/_client/client.py

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2670,15 +2670,13 @@ async def _process_experiment_item(
26702670
try:
26712671
from langfuse.model import CreateDatasetRunItemRequest
26722672

2673-
dataset_run_item = (
2674-
await self.async_api.dataset_run_items.create(
2675-
request=CreateDatasetRunItemRequest(
2676-
runName=experiment_name,
2677-
runDescription=experiment_description,
2678-
metadata=experiment_metadata,
2679-
datasetItemId=item.id, # type: ignore
2680-
traceId=trace_id,
2681-
)
2673+
dataset_run_item = self.api.dataset_run_items.create(
2674+
request=CreateDatasetRunItemRequest(
2675+
runName=experiment_name,
2676+
runDescription=experiment_description,
2677+
metadata=experiment_metadata,
2678+
datasetItemId=item.id, # type: ignore
2679+
traceId=trace_id,
26822680
)
26832681
)
26842682

langfuse/_client/experiments.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,8 @@ class LocalExperimentItem(TypedDict, total=False):
3737
metadata: Optional[Dict[str, Any]]
3838

3939

40-
ExperimentItem = Union[LocalExperimentItem, DatasetItemClient]
41-
ExperimentData = Union[List[LocalExperimentItem], List[DatasetItemClient]]
40+
ExperimentItem = Union[LocalExperimentItem, "DatasetItemClient"]
41+
ExperimentData = Union[List[LocalExperimentItem], List["DatasetItemClient"]]
4242

4343

4444
class Evaluation(TypedDict, total=False):

tests/test_experiments.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@ def test_large_dataset_with_concurrency():
281281
result = langfuse_client.run_experiment(
282282
name="Large dataset test",
283283
data=large_dataset,
284-
task=lambda **kwargs: f"Processed {kwargs['input']}",
284+
task=lambda **kwargs: f"Processed {kwargs['item']}",
285285
evaluators=[lambda **kwargs: {"name": "simple_eval", "value": 1.0}],
286286
max_concurrency=5,
287287
)
@@ -525,7 +525,7 @@ def test_format_experiment_results_basic():
525525
name="Formatting test",
526526
description="Test result formatting",
527527
data=[{"input": "Hello", "expected_output": "Hi"}],
528-
task=lambda **kwargs: f"Processed: {kwargs['input']}",
528+
task=lambda **kwargs: f"Processed: {kwargs['item']}",
529529
evaluators=[simple_evaluator],
530530
run_evaluators=[run_evaluator_average_length],
531531
)

0 commit comments

Comments
 (0)