Skip to content

Commit fbac98e

Browse files
committed
fix(tests): stabilize remaining CI failures
1 parent daaf571 commit fbac98e

2 files changed

Lines changed: 22 additions & 9 deletions

File tree

tests/e2e/test_datasets.py

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
from langfuse import Langfuse
55
from langfuse.api import DatasetStatus
6-
from tests.support.utils import create_uuid
6+
from tests.support.utils import create_uuid, wait_for_result
77

88

99
def test_create_and_get_dataset():
@@ -98,7 +98,10 @@ def test_upsert_and_get_dataset_item():
9898
)
9999

100100
# Instead, get all dataset items and find the one with matching ID
101-
dataset = langfuse.get_dataset(name)
101+
dataset = wait_for_result(
102+
lambda: langfuse.get_dataset(name),
103+
is_result_ready=lambda dataset: any(i.id == item.id for i in dataset.items),
104+
)
102105
get_item = None
103106
for i in dataset.items:
104107
if i.id == item.id:
@@ -120,7 +123,16 @@ def test_upsert_and_get_dataset_item():
120123
)
121124

122125
# Refresh dataset and find updated item
123-
dataset = langfuse.get_dataset(name)
126+
dataset = wait_for_result(
127+
lambda: langfuse.get_dataset(name),
128+
is_result_ready=lambda dataset: any(
129+
i.id == item.id
130+
and i.input == new_input
131+
and i.expected_output == new_input
132+
and i.status == DatasetStatus.ARCHIVED
133+
for i in dataset.items
134+
),
135+
)
124136
get_new_item = None
125137
for i in dataset.items:
126138
if i.id == item.id:

tests/live_provider/test_langchain.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -100,12 +100,13 @@ def test_callback_generated_from_lcel_chain():
100100

101101
assert len(trace.observations) > 0
102102

103-
langchain_generation_span = list(
104-
filter(
105-
lambda o: o.type == "GENERATION" and o.name == "ChatOpenAI",
106-
trace.observations,
107-
)
108-
)[0]
103+
generation_observations = [
104+
observation
105+
for observation in trace.observations
106+
if observation.type == "GENERATION"
107+
]
108+
assert len(generation_observations) > 0
109+
langchain_generation_span = generation_observations[0]
109110
langchain_root_spans = [
110111
observation
111112
for observation in trace.observations

0 commit comments

Comments
 (0)