fix: replace from_utf8_unchecked with from_utf8 in SQLite column name handling (#4221)

* fix: replace from_utf8_unchecked with from_utf8 in SQLite statement handle

Replace all uses of `from_utf8_unchecked` with safe `from_utf8` in the
SQLite statement handle to fix a soundness issue.

SQLite allows non-UTF-8 column names via its C API, but
`from_utf8_unchecked` assumes valid UTF-8 without checking. This can
produce invalid `&str` values through a safe public API, which is
undefined behavior in Rust.

Using `from_utf8().expect()` instead converts potential UB into a
defined panic with a clear message. There is no behavioral change for
valid UTF-8 inputs, which covers all practical usage.

Fixes #4192

* style: run rustfmt on handle.rs

Author: barry3406

sqlx-sqlite/src/statement/handle.rs

@@ -21,7 +21,7 @@ use std::os::raw::{c_char, c_int};
 use std::ptr;
 use std::ptr::NonNull;
 use std::slice::from_raw_parts;
-use std::str::{from_utf8, from_utf8_unchecked};
+use std::str::from_utf8;
 use std::sync::Arc;
 
 #[derive(Debug)]
@@ -77,7 +77,8 @@ impl StatementHandle {
             let raw = sqlite3_sql(self.0.as_ptr());
             debug_assert!(!raw.is_null());
 
-            from_utf8_unchecked(CStr::from_ptr(raw).to_bytes())
+            from_utf8(CStr::from_ptr(raw).to_bytes())
+                .expect("sqlite3_sql() returned non-UTF-8 string")
         }
     }
 
@@ -107,7 +108,8 @@ impl StatementHandle {
             let name = sqlite3_column_name(self.0.as_ptr(), check_col_idx!(index));
             debug_assert!(!name.is_null());
 
-            from_utf8_unchecked(CStr::from_ptr(name).to_bytes())
+            from_utf8(CStr::from_ptr(name).to_bytes())
+                .expect("sqlite3_column_name() returned non-UTF-8 column name")
         }
     }
 
@@ -139,7 +141,10 @@ impl StatementHandle {
             let db_name = sqlite3_column_database_name(self.0.as_ptr(), check_col_idx!(index));
 
             if !db_name.is_null() {
-                Some(from_utf8_unchecked(CStr::from_ptr(db_name).to_bytes()))
+                Some(
+                    from_utf8(CStr::from_ptr(db_name).to_bytes())
+                        .expect("sqlite3_column_database_name() returned non-UTF-8 string"),
+                )
             } else {
                 None
             }
@@ -151,7 +156,10 @@ impl StatementHandle {
             let table_name = sqlite3_column_table_name(self.0.as_ptr(), check_col_idx!(index));
 
             if !table_name.is_null() {
-                Some(from_utf8_unchecked(CStr::from_ptr(table_name).to_bytes()))
+                Some(
+                    from_utf8(CStr::from_ptr(table_name).to_bytes())
+                        .expect("sqlite3_column_table_name() returned non-UTF-8 string"),
+                )
             } else {
                 None
             }
@@ -163,7 +171,10 @@ impl StatementHandle {
             let origin_name = sqlite3_column_origin_name(self.0.as_ptr(), check_col_idx!(index));
 
             if !origin_name.is_null() {
-                Some(from_utf8_unchecked(CStr::from_ptr(origin_name).to_bytes()))
+                Some(
+                    from_utf8(CStr::from_ptr(origin_name).to_bytes())
+                        .expect("sqlite3_column_origin_name() returned non-UTF-8 string"),
+                )
             } else {
                 None
             }
@@ -191,7 +202,8 @@ impl StatementHandle {
                 return None;
             }
 
-            let decl = from_utf8_unchecked(CStr::from_ptr(decl).to_bytes());
+            let decl = from_utf8(CStr::from_ptr(decl).to_bytes())
+                .expect("sqlite3_column_decltype() returned non-UTF-8 string");
             let ty: DataType = decl.parse().ok()?;
 
             Some(SqliteTypeInfo(ty))
@@ -285,7 +297,10 @@ impl StatementHandle {
                 return None;
             }
 
-            Some(from_utf8_unchecked(CStr::from_ptr(name).to_bytes()))
+            Some(
+                from_utf8(CStr::from_ptr(name).to_bytes())
+                    .expect("sqlite3_bind_parameter_name() returned non-UTF-8 string"),
+            )
         }
     }