fix: lots more Clippy warnings

Author: abonander

sqlx-core/src/any/arguments.rs

@@ -32,7 +32,7 @@ impl<'q> Arguments<'q> for AnyArguments<'q> {
 
 pub struct AnyArgumentBuffer<'q>(#[doc(hidden)] pub Vec<AnyValueKind<'q>>);
 
-impl<'q> Default for AnyArguments<'q> {
+impl Default for AnyArguments<'_> {
     fn default() -> Self {
         AnyArguments {
             values: AnyArgumentBuffer(vec![]),

sqlx-core/src/any/row.rs

@@ -63,7 +63,7 @@ impl Row for AnyRow {
     }
 }
 
-impl<'i> ColumnIndex<AnyRow> for &'i str {
+impl ColumnIndex<AnyRow> for &'_ str {
     fn index(&self, row: &AnyRow) -> Result<usize, Error> {
         row.column_names
             .get(*self)

sqlx-core/src/any/statement.rs

@@ -51,7 +51,7 @@ impl<'q> Statement<'q> for AnyStatement<'q> {
     impl_statement_query!(AnyArguments<'_>);
 }
 
-impl<'i> ColumnIndex<AnyStatement<'_>> for &'i str {
+impl ColumnIndex<AnyStatement<'_>> for &'_ str {
     fn index(&self, statement: &AnyStatement<'_>) -> Result<usize, Error> {
         statement
             .column_names

sqlx-core/src/ext/async_stream.rs

@@ -95,7 +95,7 @@ impl<T> Yielder<T> {
     }
 }
 
-impl<'a, T> Stream for TryAsyncStream<'a, T> {
+impl<T> Stream for TryAsyncStream<'_, T> {
     type Item = Result<T, Error>;
 
     fn poll_next(mut self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Option<Self::Item>> {

sqlx-core/src/io/encode.rs

@@ -9,7 +9,7 @@ pub trait ProtocolEncode<'en, Context = ()> {
     fn encode_with(&self, buf: &mut Vec<u8>, context: Context) -> Result<(), crate::Error>;
 }
 
-impl<'en, C> ProtocolEncode<'en, C> for &'_ [u8] {
+impl<C> ProtocolEncode<'_, C> for &'_ [u8] {
     fn encode_with(&self, buf: &mut Vec<u8>, _context: C) -> Result<(), crate::Error> {
         buf.extend_from_slice(self);
         Ok(())

sqlx-core/src/logger.rs

@@ -158,7 +158,7 @@ impl<'q> QueryLogger<'q> {
     }
 }
 
-impl<'q> Drop for QueryLogger<'q> {
+impl Drop for QueryLogger<'_> {
     fn drop(&mut self) {
         self.finish();
     }

sqlx-core/src/net/socket/mod.rs

@@ -62,7 +62,7 @@ pub struct Read<'a, S: ?Sized, B> {
     buf: &'a mut B,
 }
 
-impl<'a, S: ?Sized, B> Future for Read<'a, S, B>
+impl<S: ?Sized, B> Future for Read<'_, S, B>
 where
     S: Socket,
     B: ReadBuf,
@@ -90,7 +90,7 @@ pub struct Write<'a, S: ?Sized> {
     buf: &'a [u8],
 }
 
-impl<'a, S: ?Sized> Future for Write<'a, S>
+impl<S: ?Sized> Future for Write<'_, S>
 where
     S: Socket,
 {
@@ -116,7 +116,7 @@ pub struct Flush<'a, S: ?Sized> {
     socket: &'a mut S,
 }
 
-impl<'a, S: Socket + ?Sized> Future for Flush<'a, S> {
+impl<S: Socket + ?Sized> Future for Flush<'_, S> {
     type Output = io::Result<()>;
 
     fn poll(mut self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Self::Output> {
@@ -128,7 +128,7 @@ pub struct Shutdown<'a, S: ?Sized> {
     socket: &'a mut S,
 }
 
-impl<'a, S: ?Sized> Future for Shutdown<'a, S>
+impl<S: ?Sized> Future for Shutdown<'_, S>
 where
     S: Socket,
 {

sqlx-core/src/net/tls/tls_rustls.rs

@@ -138,7 +138,7 @@ where
         }
     } else {
         #[cfg(any(feature = "_tls-rustls-aws-lc-rs", feature = "_tls-rustls-ring-webpki"))]
-        let mut cert_store = certs_from_webpki();
+        let cert_store = certs_from_webpki();
         #[cfg(feature = "_tls-rustls-ring-native-roots")]
         let mut cert_store = certs_from_native_store();
 
@@ -225,7 +225,7 @@ fn certs_from_native_store() -> RootCertStore {
         log::warn!("Error loading native certificates: {e:?}");
     }
     for cert in load_results.certs {
-        if let Err(e) = root_cert_store.add(cert.into()) {
+        if let Err(e) = root_cert_store.add(cert) {
             log::warn!("rustls failed to parse native certificate: {e:?}");
         }
     }

sqlx-core/src/pool/executor.rs

@@ -9,7 +9,7 @@ use crate::error::Error;
 use crate::executor::{Execute, Executor};
 use crate::pool::Pool;
 
-impl<'p, DB: Database> Executor<'p> for &'_ Pool<DB>
+impl<DB: Database> Executor<'_> for &'_ Pool<DB>
 where
     for<'c> &'c mut DB::Connection: Executor<'c, Database = DB>,
 {

sqlx-core/src/pool/inner.rs

@@ -451,15 +451,13 @@ pub(super) fn is_beyond_max_lifetime<DB: Database>(
     options: &PoolOptions<DB>,
 ) -> bool {
     options
-        .max_lifetime
-        .map_or(false, |max| live.created_at.elapsed() > max)
+        .max_lifetime.is_some_and(|max| live.created_at.elapsed() > max)
 }
 
 /// Returns `true` if the connection has exceeded `options.idle_timeout` if set, `false` otherwise.
 fn is_beyond_idle_timeout<DB: Database>(idle: &Idle<DB>, options: &PoolOptions<DB>) -> bool {
     options
-        .idle_timeout
-        .map_or(false, |timeout| idle.idle_since.elapsed() > timeout)
+        .idle_timeout.is_some_and(|timeout| idle.idle_since.elapsed() > timeout)
 }
 
 async fn check_idle_conn<DB: Database>(