Skip to content

Commit 53a26bc

Browse files
committed
.github: run samples workflows on every master push
Both Linux-libretro-common-samples and Linux-samples-tasks had GitHub Actions "paths:" filters that limited them to runs where the push included a change to the code they test. The filters were overly conservative -- they miss cross-cutting regressions where a change outside the filtered tree breaks the code under test through a transitive include, linker resolution, or similar non-obvious coupling. Concretely: the libretro-common samples workflow last ran on commit 0ef2531 and subsequent commits (c72a70d fix, MD5 rename, etc.) did not trigger it even though some of those changes could in principle affect libretro-common via shared headers. A later libretro-common change that happens to break in combination with those upstream shifts would surface the failure attributed to the wrong commit. Removing the filters means every master push and every PR runs both jobs. Cost: each workflow is ~40s wall-clock (libretro-common samples: Built 12 / Ran 11, samples/tasks: 3 steps). Added CI spend is a rounding error for a project with dozens of platform jobs that take minutes each; the upside is that we never misattribute a regression to a later commit just because of a filename-based filter. .github/workflows/Linux-libretro-common-samples.yml: -6 lines .github/workflows/Linux-samples-tasks.yml: -12 lines Local dry-run of both workflows under the exact GHA shell contract (bash --noprofile --norc -eo pipefail) on current master c72a70d: libretro-common: Built: 12 Ran: 11 Failed: 0 samples/tasks: [pass] database_task build [pass] database_task no-args exit=1 [pass] archive_name_safety_test
1 parent c72a70d commit 53a26bc

2 files changed

Lines changed: 0 additions & 18 deletions

File tree

.github/workflows/Linux-libretro-common-samples.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,9 @@ on:
44
push:
55
branches:
66
- master
7-
paths:
8-
- 'libretro-common/**'
9-
- '.github/workflows/Linux-libretro-common-samples.yml'
107
pull_request:
118
branches:
129
- master
13-
paths:
14-
- 'libretro-common/**'
15-
- '.github/workflows/Linux-libretro-common-samples.yml'
1610
workflow_dispatch:
1711

1812
permissions:

.github/workflows/Linux-samples-tasks.yml

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,21 +4,9 @@ on:
44
push:
55
branches:
66
- master
7-
paths:
8-
- 'samples/tasks/**'
9-
- 'tasks/task_decompress.c'
10-
- 'tasks/task_database.c'
11-
- 'tasks/task_database_cue.c'
12-
- '.github/workflows/Linux-samples-tasks.yml'
137
pull_request:
148
branches:
159
- master
16-
paths:
17-
- 'samples/tasks/**'
18-
- 'tasks/task_decompress.c'
19-
- 'tasks/task_database.c'
20-
- 'tasks/task_database_cue.c'
21-
- '.github/workflows/Linux-samples-tasks.yml'
2210
workflow_dispatch:
2311

2412
permissions:

0 commit comments

Comments
 (0)