Commit 5f0afac
committed
xmb+menu_setting: Hide History/Images/Music/Video tabs when history is disabled, refresh on toggle
Apply the same fix as ozone (bdcf692) to the XMB driver: gate the
History, Images, Music, and Video system tabs in
xmb_refresh_system_tabs_list on history_list_enable in addition to the
existing menu_content_show_* flags. Without history tracking these tabs
are permanent dead ends with no possibility of content. Favorites is
unaffected (independent setting).
Additionally, fix the live-toggle behaviour. The previous patch wired
MENU_ENUM_LABEL_HISTORY_LIST_ENABLE into the MENU_ENVIRON_RESET_HORIZONTAL_LIST
dispatch but stale state in g_defaults.{content,image,music,video}_history
meant that the gating logic in menu_displaylist.c (which checks both the
menu_content_show_* flag and the corresponding playlist pointer) read
the wrong values until the next launch. As a result, the materialui
Playlists screen did not visibly update when toggling the setting.
Split MENU_ENUM_LABEL_HISTORY_LIST_ENABLE into its own case in
general_write_handler that fires CMD_EVENT_HISTORY_INIT (which internally
deinits first, then early-returns when the new setting value is OFF),
keeping g_defaults pointers in sync with the setting. Also set
MENU_ST_FLAG_ENTRIES_NEED_REFRESH so the currently-displayed displaylist
is rebuilt - this is what makes materialui's Playlists screen update on
toggle, since materialui has no horizontal tab bar of its own to refresh.1 parent bdcf692 commit 5f0afac
2 files changed
Lines changed: 18 additions & 5 deletions
File tree
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3179 | 3179 | | |
3180 | 3180 | | |
3181 | 3181 | | |
3182 | | - | |
| 3182 | + | |
3183 | 3183 | | |
3184 | 3184 | | |
3185 | 3185 | | |
3186 | 3186 | | |
3187 | | - | |
| 3187 | + | |
3188 | 3188 | | |
3189 | 3189 | | |
3190 | 3190 | | |
3191 | 3191 | | |
3192 | 3192 | | |
3193 | 3193 | | |
3194 | | - | |
| 3194 | + | |
3195 | 3195 | | |
3196 | 3196 | | |
3197 | 3197 | | |
3198 | | - | |
| 3198 | + | |
3199 | 3199 | | |
3200 | 3200 | | |
3201 | 3201 | | |
3202 | | - | |
| 3202 | + | |
3203 | 3203 | | |
3204 | 3204 | | |
3205 | 3205 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9322 | 9322 | | |
9323 | 9323 | | |
9324 | 9324 | | |
| 9325 | + | |
| 9326 | + | |
| 9327 | + | |
| 9328 | + | |
| 9329 | + | |
| 9330 | + | |
| 9331 | + | |
9325 | 9332 | | |
9326 | 9333 | | |
9327 | 9334 | | |
| 9335 | + | |
| 9336 | + | |
| 9337 | + | |
| 9338 | + | |
9328 | 9339 | | |
9329 | 9340 | | |
9330 | 9341 | | |
| 9342 | + | |
| 9343 | + | |
9331 | 9344 | | |
9332 | 9345 | | |
9333 | 9346 | | |
| |||
0 commit comments