Skip to content

Commit fae20db

Browse files
committed
menu/rgui: don't wipe framebuffer behind info popup
rgui_render() was filling the entire framebuffer with bg_dark_color before drawing the info messagebox, which erased the menu underneath and left the popup floating against an empty background. The messagebox already paints its own opaque background, border, and drop shadow within its footprint, so the full-screen fill served no purpose other than destroying the menu render that had just been composed above it. Drop it; the popup now appears on top of the visible menu as intended.
1 parent 6fd1b13 commit fae20db

1 file changed

Lines changed: 2 additions & 7 deletions

File tree

menu/drivers/rgui.c

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5919,13 +5919,8 @@ static void rgui_render(void *data, unsigned width, unsigned height,
59195919

59205920
if (*rgui->msgbox)
59215921
{
5922-
/* Draw background */
5923-
rgui_fill_rect(rgui->frame_buf.data, fb_width, fb_height,
5924-
0, 0, fb_width, fb_height,
5925-
rgui->colors.bg_dark_color,
5926-
rgui->colors.bg_dark_color,
5927-
(rgui->flags & RGUI_FLAG_BG_THICKNESS) ? true : false);
5928-
5922+
/* Draw popup directly on top of the menu; the messagebox
5923+
* paints its own opaque background within its footprint. */
59295924
rgui_render_messagebox(rgui, rgui->msgbox, fb_width, fb_height);
59305925
rgui->msgbox[0] = '\0';
59315926
rgui->flags |= RGUI_FLAG_FORCE_REDRAW;

0 commit comments

Comments
 (0)