Fix Open Folder and update to new Deno.spawn API (#23)

Author: louislam

README.md

@@ -61,15 +61,15 @@ The same folder in Windows Explorer. AkaiGrid is better, right?
 
 Extra requirements:
 
-- Install Deno 2.3.1 or higher (https://docs.deno.com/runtime/)
+- Install Deno 2.7.1 or higher (https://docs.deno.com/runtime/)
 - Install Git (https://git-scm.com/downloads)
 
 1. Clone this repository and install dependencies:
 
    ```bash
    git clone https://github.com/louislam/akaigrid
    cd akaigrid
-   git checkout 1.0.2
+   git checkout 1.2.0
    deno task setup
    ```
 

backend/akaigrid.ts

@@ -202,19 +202,18 @@ export class AkaiGrid {
         // If player is set, use it to open the file
         if (this.config.player && this.config.player.trim() !== "") {
             log.debug(`Using player ${this.config.player} to open the file.`);
-            const command = new Deno.Command(this.config.player, {
-                args: [path],
-                stdout: "null",
-                stderr: "null",
-            });
-            command.spawn();
+            Deno.spawn(this.config.player, [path]);
         } else {
             start(path);
         }
 
         // Also update the date accessed for the parent directory
-        if (this.config.bringFolderToTop) {
-            await this.bringFolderToTop(path);
+        try {
+            if (this.config.bringFolderToTop) {
+                await this.bringFolderToTop(path);
+            }
+        } catch (e) {
+            // If it is already the top, it will throw an error, we can ignore it
         }
 
         // Update the date accessed
@@ -223,6 +222,12 @@ export class AkaiGrid {
         }
     }
 
+    async openFolder(folder: string) {
+        this.checkAllowedPath(folder);
+        log.debug(`Opening folder ${folder}`);
+        Deno.spawn("explorer.exe", [folder]);
+    }
+
     async setDone(path: string, done: boolean) {
         this.checkAllowedPath(path);
         log.debug(`Setting path ${path} to done: ${done}`);

backend/history.ts

@@ -3,17 +3,13 @@ import { ObjectAsArray } from "../common/util.ts";
 
 export async function getAllMPCHCMediaHistory(): Promise<ObjectAsArray<number>> {
     const key = "HKEY_CURRENT_USER\\Software\\MPC-HC\\MPC-HC\\MediaHistory";
-    const command = new Deno.Command("reg.exe", {
-        args: [
-            "query",
-            key,
-            "/s",
-            "/v",
-            "FilePosition",
-        ],
-    });
-
-    let { code, stdout, stderr } = await command.output();
+    const { code, stdout, stderr } = await Deno.spawnAndWait("reg.exe", [
+        "query",
+        key,
+        "/s",
+        "/v",
+        "FilePosition",
+    ]);
 
     if (code !== 0) {
         console.error("Error executing command:", code, stderr);

backend/server.ts

@@ -6,7 +6,7 @@ import * as path from "@std/path";
 import { serveDir, serveFile } from "@std/http/file-server";
 import { DirConfigSchema, EntryDisplayObject, ObjectAsArray } from "../common/util.ts";
 import { getAllMPCHCMediaHistory } from "./history.ts";
-import {kv} from "./db/kv.ts";
+import { kv } from "./db/kv.ts";
 
 export class Server {
     akaiGrid: AkaiGrid;
@@ -186,6 +186,28 @@ export class Server {
             }
         });
 
+        // Open Folder file
+        this.router.add("POST", "/api/open-folder/:path", async (_req, params) => {
+            try {
+                const path = params.path;
+                if (!path) {
+                    return this.errorResponse(new Error("No path specified"));
+                }
+                log.info("Open:", path);
+                await this.akaiGrid.openFolder(path);
+                const res = Response.json({
+                    status: true,
+                });
+                allowDevAllOrigin(res);
+                return res;
+            } catch (error) {
+                if (error instanceof Error) {
+                    log.error(error.message);
+                }
+                return this.errorResponse(error);
+            }
+        });
+
         // Set the path to done?
         // :yes = true/false
         this.router.add("POST", "/api/done/:path/:yes", async (_req, params) => {
@@ -245,7 +267,6 @@ export class Server {
                     if (file.isFile && file.name.endsWith(".jpg")) {
                         const thumbnailPath = path.join(dir, file.name);
 
-
                         // Check if there is a corresponding file in the kv store
                         const originalPath = await kv().get<string>(["thumbnail", thumbnailPath]);
                         if (originalPath.value) {

backend/util.ts

@@ -1,6 +1,5 @@
 import * as log from "@std/log";
 import process from "node:process";
-import childProcess from "node:child_process";
 import { z } from "zod";
 import * as path from "@std/path";
 import { createHash } from "node:crypto";
@@ -107,8 +106,7 @@ export function getFrontendDir(): string {
 }
 
 export function start(path: string) {
-    const escapedPath = escapeString(path);
-    childProcess.exec(`start "" ${escapedPath}`);
+    Deno.spawn("cmd", ["/c", "start", "", path]);
 }
 
 export function isDev() {
@@ -181,23 +179,19 @@ export function getShortHash(bytes: Uint8Array): string {
 }
 
 export async function getVideoInfo(videoPath: string): Promise<VideoInfo> {
-    // ffprobe -v error -select_streams v:0 -show_entries stream=codec_name,width,height,duration -of json input_video.mp4
-    const command = new Deno.Command(ffprobe, {
-        args: [
-            "-v",
-            "error",
-            "-select_streams",
-            "v:0",
-            "-show_entries",
-            "stream=codec_name,width,height",
-            "-show_entries",
-            "format=duration",
-            "-of",
-            "json",
-            videoPath,
-        ],
-    });
-    const output = await command.output();
+    const output = await Deno.spawnAndWait(ffprobe, [
+        "-v",
+        "error",
+        "-select_streams",
+        "v:0",
+        "-show_entries",
+        "stream=codec_name,width,height",
+        "-show_entries",
+        "format=duration",
+        "-of",
+        "json",
+        videoPath,
+    ]);
     if (output.code !== 0) {
         const errorMsg = new TextDecoder().decode(output.stderr);
         throw new Error(`Error executing ffprobe: ${errorMsg}, ${output.code}`);
@@ -220,18 +214,15 @@ export async function getVideoInfo(videoPath: string): Promise<VideoInfo> {
 }
 
 export async function generateThumbnail(videoPath: string, thumbnailPath: string) {
-    let command = new Deno.Command(ffprobe, {
-        args: [
-            "-v",
-            "error",
-            "-show_entries",
-            "format=duration",
-            "-of",
-            "default=noprint_wrappers=1:nokey=1",
-            videoPath,
-        ],
-    });
-    let output = await command.output();
+    let output = await Deno.spawnAndWait(ffprobe, [
+        "-v",
+        "error",
+        "-show_entries",
+        "format=duration",
+        "-of",
+        "default=noprint_wrappers=1:nokey=1",
+        videoPath,
+    ]);
 
     if (output.code !== 0) {
         const errorMsg = new TextDecoder().decode(output.stderr);
@@ -248,25 +239,23 @@ export async function generateThumbnail(videoPath: string, thumbnailPath: string
 
     const targetWidth = 512;
 
-    command = new Deno.Command(ffmpeg, {
-        args: [
-            "-ss",
-            target + "",
-            "-i",
-            videoPath,
-            "-vf",
-            // Generate thumbnail's width is always fixed
-            // SAR = Storage Aspect Ratio, some videos let's say original resolution is 1440x1080, but the video is 16:9, so the SAR is 1.3333
-            // Width: 512px
-            // Height Formula = Height * (512 / Width) * (1 / SAR)
-            `scale=${targetWidth}:ih*(1/sar)*(${targetWidth}/iw)`,
-            "-vframes",
-            "1",
-            thumbnailPath,
-        ],
+    output = await Deno.spawnAndWait(ffmpeg, [
+        "-ss",
+        target + "",
+        "-i",
+        videoPath,
+        "-vf",
+        // Generate thumbnail's width is always fixed
+        // SAR = Storage Aspect Ratio, some videos let's say original resolution is 1440x1080, but the video is 16:9, so the SAR is 1.3333
+        // Width: 512px
+        // Height Formula = Height * (512 / Width) * (1 / SAR)
+        `scale=${targetWidth}:ih*(1/sar)*(${targetWidth}/iw)`,
+        "-vframes",
+        "1",
+        thumbnailPath,
+    ], {
         stdout: "piped",
     });
-    output = await command.output();
 
     if (output.code !== 0) {
         log.error("Error executing ffmpeg:", output.stderr);

deno.jsonc

@@ -1,6 +1,6 @@
 {
     // App Version
-    "version": "1.1.0",
+    "version": "1.2.0",
 
     "unstable": [
         // So format Vue components

frontend/src/pages/List.vue

@@ -313,7 +313,7 @@ function upper() {
  * Open the current path in the file explorer
  */
 async function openExplorer() {
-    const response = await fetch(baseURL + "/api/open/" + encodeURIComponent(path.value), {
+    const response = await fetch(baseURL + "/api/open-folder/" + encodeURIComponent(path.value), {
         method: "POST",
     });
     if (!response.ok) {