Skip to content

Commit 076c80b

Browse files
authored
ember-try: Replace ember-source with ember-data scenarios (#32)
There is no need to test with multiple Ember versions, but testing with multiple Ember Data versions would be quite beneficial.
1 parent 90bbdb7 commit 076c80b

4 files changed

Lines changed: 12 additions & 44 deletions

File tree

.github/workflows/ci.yml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,12 +67,10 @@ jobs:
6767
fail-fast: false
6868
matrix:
6969
try-scenario:
70-
- ember-lts-3.28
71-
- ember-lts-4.4
72-
- ember-release
73-
- ember-beta
74-
- ember-canary
75-
- ember-classic
70+
- ember-data-3.28
71+
- ember-data-4.4
72+
- ember-data-4.7
73+
- ember-data-4.8
7674
- embroider-safe
7775
- embroider-optimized
7876

config/ember-try.js

Lines changed: 8 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1,67 +1,40 @@
11
'use strict';
22

3-
const getChannelURL = require('ember-source-channel-url');
43
const { embroiderSafe, embroiderOptimized } = require('@embroider/test-setup');
54

65
module.exports = async function () {
76
return {
87
usePnpm: true,
98
scenarios: [
109
{
11-
name: 'ember-lts-3.28',
10+
name: 'ember-data-3.28',
1211
npm: {
1312
devDependencies: {
14-
'ember-source': '~3.28.0',
13+
'ember-data': '3.28.12',
1514
},
1615
},
1716
},
1817
{
19-
name: 'ember-lts-4.4',
18+
name: 'ember-data-4.4',
2019
npm: {
2120
devDependencies: {
22-
'ember-source': '~4.4.0',
21+
'ember-data': '4.4.1',
2322
},
2423
},
2524
},
2625
{
27-
name: 'ember-release',
26+
name: 'ember-data-4.7',
2827
npm: {
2928
devDependencies: {
30-
'ember-source': await getChannelURL('release'),
29+
'ember-data': '4.7.3',
3130
},
3231
},
3332
},
3433
{
35-
name: 'ember-beta',
34+
name: 'ember-data-4.8',
3635
npm: {
3736
devDependencies: {
38-
'ember-source': await getChannelURL('beta'),
39-
},
40-
},
41-
},
42-
{
43-
name: 'ember-canary',
44-
npm: {
45-
devDependencies: {
46-
'ember-source': await getChannelURL('canary'),
47-
},
48-
},
49-
},
50-
{
51-
name: 'ember-classic',
52-
env: {
53-
EMBER_OPTIONAL_FEATURES: JSON.stringify({
54-
'application-template-wrapper': true,
55-
'default-async-observers': false,
56-
'template-only-glimmer-components': false,
57-
}),
58-
},
59-
npm: {
60-
devDependencies: {
61-
'ember-source': '~3.28.0',
62-
},
63-
ember: {
64-
edition: 'classic',
37+
'ember-data': '4.8.2',
6538
},
6639
},
6740
},

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@
5050
"ember-qunit": "6.0.0",
5151
"ember-resolver": "8.0.3",
5252
"ember-source": "4.8.2",
53-
"ember-source-channel-url": "3.0.0",
5453
"ember-template-lint": "4.17.0",
5554
"ember-try": "2.0.0",
5655
"eslint": "7.32.0",

pnpm-lock.yaml

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)