Skip to content

Commit dbb6e11

Browse files
authored
Merge pull request #320 from medema-group/release/2.0.0
Release/2.0.0
2 parents a6d5ed4 + 7956fc8 commit dbb6e11

19 files changed

Lines changed: 230 additions & 204 deletions

File tree

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
---
2+
name: Bug report
3+
about: Create a report to help us improve
4+
title: ''
5+
labels: bug
6+
assignees: ''
7+
8+
---
9+
10+
**Describe the bug**
11+
A clear and concise description of what the bug is.
12+
13+
**To Reproduce**
14+
Please describe the steps used to reproduce the issue in this section
15+
16+
**Expected behavior**
17+
A clear and concise description of what you expected to happen.
18+
19+
**Screenshots**
20+
If applicable, add screenshots to help explain your problem.
21+
22+
**System (please complete the following information):**
23+
- OS: [e.g. iOS]
24+
- Hardware [e.g. x64 or ARM, memory size]
25+
- BiG-SCAPE Version [e.g. 2.0.0-beta.3, use bigscape --version to confirm]
26+
27+
**Additional context**
28+
Add any other context about the problem here.
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
---
2+
name: Feature request
3+
about: Suggest an idea for this project
4+
title: ''
5+
labels: enhancement
6+
assignees: ''
7+
8+
---
9+
10+
**Is your feature request related to a problem? Please describe.**
11+
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
12+
13+
**Describe the solution you'd like**
14+
A clear and concise description of what you want to happen.
15+
16+
**Describe alternatives you've considered**
17+
A clear and concise description of any alternative solutions or features you've considered.
18+
19+
**Additional context**
20+
Add any other context or screenshots about the feature request here.
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
---
2+
name: Question about BiG-SCAPE process or results
3+
about: For questions about BiG-SCAPE in general
4+
title: ''
5+
labels: question
6+
assignees: ''
7+
8+
---
9+
10+

.github/workflows/deploy-docker.yml

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@ name: Publish Docker image
22

33
on:
44
release:
5-
types: [published, edited]
6-
5+
types: [published]
76

87
env:
98
REGISTRY: ghcr.io
@@ -31,8 +30,8 @@ jobs:
3130
# set latest tag for master branch
3231
with:
3332
tags: |
34-
type=semver,pattern={{version}}
35-
type=raw,value=latest,enable=${{ github.ref == format('refs/heads/{0}', 'master') }}
33+
type=semver,pattern={{GITHUB_REF}}
34+
type=raw,value=latest
3635
images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
3736

3837
- name: Login to GitHub Container Registry

CITATION.cff

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
cff-version: 1.2.0
2+
message: "If you use this software, please cite it as below"
3+
authors:
4+
- family-names: Draisma
5+
given-names: Arjan
6+
orcid: 0009-0004-0503-6261
7+
- family-names: Loureiro
8+
given-names: Catarina
9+
orcid: 0000-0002-6258-2080
10+
- family-names: Louwen
11+
given-names: Nico L.L.
12+
orcid: 0000-0002-4431-5499
13+
- family-names: Medema
14+
given-names: Marnix H.
15+
orcid: 0000-0002-2191-2821
16+
title: "BiG-SCAPE: Biosynthetic Gene Similarity Clustering and Prospecting Engine"
17+
version: 2.0.0
18+
identifiers:
19+
- type: doi
20+
value: 10.1101/2025.08.20.671210
21+
- type: doi
22+
value: 10.1038/s41589-019-0400-9
23+
date-released: 24-07-2025

CONTRIBUTING.md

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
# Contributing
2+
3+
We welcome contributions to this repository.
4+
In order to do so, please fork this repository and submit pull requests according to
5+
the section below.
6+
7+
## Submitting a pull request
8+
9+
1. Fork this repository
10+
2. Create a new branch from our dev branch, and give it a descriptive name
11+
3. Commit your work to this branch
12+
4. Submit a new PR
13+
14+
In this PR, please include the following information:
15+
16+
- What did you change?
17+
- Why did you change it? (Please link to issues if available)
18+
- How did you implement the change?
19+
20+
These points help us review your PR.
21+
22+
23+
## Submitting an issue
24+
25+
Please feel free to submit new issues.
26+
You can use the search function on GitHub to check if an issue for the problem you are
27+
experiencing already exists.
28+
But if you cannot find an issue that matches your exact problem, please feel free to
29+
submit a new issue.
30+
31+
We use a number of templates for issues that you can use, but if your issue does not fit
32+
within the templates, please feel free to submit a custom issue.
33+
34+
## Code guidelines
35+
36+
The codebase largely follows the PEP8 standards, and uses flake8 for linting.
37+
We use black for auto formatting.
38+
Please ensure you have run a formatting tool on your code.

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
![Test workflow](https://github.com/medema-group/BiG-SCAPE/actions/workflows/deploy-docker.yml/badge.svg)
55
[![fair-software.eu](https://img.shields.io/badge/fair--software.eu-%E2%97%8F%20%20%E2%97%8F%20%20%E2%97%8F%20%20%E2%97%8B%20%20%E2%97%8B-orange)](https://fair-software.eu)
66

7-
## _Notes:<br>BiG-SCAPE 2.0 is still in beta. Please submit an issue if you find anything wrong with this release!<br>BiG-SCAPE 2.0 features several updates to input validation and reference usage. We encourage both experienced BiG-SCAPE 1 users as well as new BiG-SCAPE users to read the updated [documentation](https://github.com/medema-group/BiG-SCAPE/wiki)._
7+
## _Notes:<br>BiG-SCAPE 2.0 features several updates to input validation and reference usage.<br>We encourage both experienced BiG-SCAPE 1 users as well as new BiG-SCAPE users to read the updated [documentation](https://github.com/medema-group/BiG-SCAPE/wiki)._
88

99
# BiG-SCAPE
1010

big_scape/comparison/comparable_region.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -220,15 +220,15 @@ def __repr__(self) -> str:
220220
)
221221

222222
@staticmethod
223-
def cds_range_contains_biosynthetic(
223+
def cds_range_contains_core(
224224
record: BGCRecord,
225225
cds_start: int,
226226
cds_stop: int,
227227
end_inclusive=False,
228228
reverse=False,
229229
) -> bool:
230230
"""Return true if a range of cds within this record contains a gene that is
231-
marked as biosynthetic
231+
marked as core
232232
233233
Args:
234234
record (BGCRecord): BGC record object
@@ -240,7 +240,7 @@ def cds_range_contains_biosynthetic(
240240
cds_start and cds_stop. Defaults to False.
241241
242242
Returns:
243-
bool: True if the given range contains a biosynthetic gene
243+
bool: True if the given range contains a core gene
244244
"""
245245
stop = cds_stop
246246
if end_inclusive:
@@ -252,7 +252,7 @@ def cds_range_contains_biosynthetic(
252252
if cds.gene_kind is None:
253253
continue
254254

255-
if cds.gene_kind == "biosynthetic":
255+
if cds.is_core():
256256
return True
257257

258258
return False

big_scape/comparison/extend.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,17 +53,17 @@ def len_check(pair: RecordPair, min_len_perc: float) -> bool:
5353
return False
5454

5555

56-
def biosynthetic_check(pair: RecordPair) -> bool:
57-
"""Checks if any element of a pair contains a biosynthetic domain
56+
def core_check(pair: RecordPair) -> bool:
57+
"""Checks if any element of a pair contains a rule-triggering core domain
5858
5959
returns true if
60-
- the comparable region contains a biosynthetic gene
60+
- the comparable region contains a core gene
6161
6262
Args:
6363
pair: The record pair to check
6464
"""
6565

66-
if ComparableRegion.cds_range_contains_biosynthetic(
66+
if ComparableRegion.cds_range_contains_core(
6767
pair.record_a,
6868
pair.comparable_region.a_start,
6969
pair.comparable_region.a_stop,
@@ -72,7 +72,7 @@ def biosynthetic_check(pair: RecordPair) -> bool:
7272
):
7373
return True
7474

75-
if ComparableRegion.cds_range_contains_biosynthetic(
75+
if ComparableRegion.cds_range_contains_core(
7676
pair.record_b,
7777
pair.comparable_region.b_start,
7878
pair.comparable_region.b_stop,

0 commit comments

Comments
 (0)