Skip to content

Commit 83719d7

Browse files
committed
tests: increases coverage by testing for null parameter names
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
1 parent 4b3164a commit 83719d7

File tree

1 file changed

+31
-1
lines changed

1 file changed

+31
-1
lines changed

test/Microsoft.OpenApi.Tests/Validations/OpenApiParameterValidationTests.cs

Lines changed: 31 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ public void ValidateExampleShouldNotHaveDataTypeMismatchForSimpleSchema()
7575
var validator = new OpenApiValidator(ValidationRuleSet.GetDefaultRuleSet());
7676
validator.Enter("{parameter1}");
7777
var walker = new OpenApiWalker(validator);
78-
walker.Walk(parameter);
78+
walker.Walk((IOpenApiParameter)parameter);
7979

8080
warnings = validator.Warnings;
8181
var result = !warnings.Any();
@@ -246,5 +246,35 @@ public void PathParameterInThePathShouldBeOkWithSlashInParameterName()
246246
// Assert
247247
Assert.False(result);
248248
}
249+
250+
[Fact]
251+
public void PathParameterValidationShouldNotThrowWithEmptyParameterName()
252+
{
253+
// Arrange
254+
var parameter = new OpenApiParameter
255+
{
256+
Name = string.Empty,
257+
In = ParameterLocation.Path,
258+
Required = true,
259+
Schema = new OpenApiSchema()
260+
{
261+
Type = JsonSchemaType.String,
262+
}
263+
};
264+
265+
// Act
266+
var validator = new OpenApiValidator(ValidationRuleSet.GetDefaultRuleSet());
267+
validator.Enter("paths");
268+
validator.Enter("/{}");
269+
validator.Enter("get");
270+
validator.Enter("parameters");
271+
validator.Enter("1");
272+
273+
var walker = new OpenApiWalker(validator);
274+
var exception = Record.Exception(() => walker.Walk((IOpenApiParameter)parameter));
275+
276+
// Assert
277+
Assert.Null(exception);
278+
}
249279
}
250280
}

0 commit comments

Comments
 (0)