fix: build frontend before tests to prevent Lunaria CI failures (#712)

Move the Astro production build ahead of test:all so that Lunaria's
i18n status page is generated against a pristine git working tree.

Previously, the lint step (inside test:all) ran astro sync first,
which left generated artifacts on disk. When the build ran afterward,
Lunaria detected those changes and failed with a doubled rootDir path
(src/frontend/src/frontend/…), producing the error:

  Failed to retrieve last commit data from …/src/frontend/src/frontend/
  src/content/docs/deployment/environments.mdx

By building first, Lunaria never sees a polluted working tree. The
Playwright install is also deferred until after the build since it is
only needed by the test step.

Additionally, the build artifact upload now runs before the dist
sanity-check so the artifact is always captured for debugging, even
when the check fails.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: IEvangelist

.github/workflows/frontend-build.yml

@@ -65,6 +65,45 @@ jobs:
       - name: Install deps
         run: pnpm install --frozen-lockfile
 
+      # Build BEFORE tests so that Lunaria (i18n status) runs against a
+      # pristine working tree.  The lint step inside test:all calls
+      # `astro sync` which can leave generated artifacts on disk; when
+      # the build ran second, Lunaria would see those as uncommitted
+      # changes and fail with a doubled rootDir path
+      # (src/frontend/src/frontend/…).
+      - name: Build frontend
+        env:
+          MODE: production
+          ASTRO_TELEMETRY_DISABLED: 1
+        run: pnpm build:production
+
+      # Upload before the dist sanity-check so the artifact is always
+      # available for debugging, even when the check step fails.
+      # Note: `uses` actions ignore the job-level working-directory,
+      # so the path is repo-root-relative (src/frontend/dist).
+      - name: Upload build artifact
+        if: ${{ always() }}
+        uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0
+        with:
+          name: frontend-dist
+          path: src/frontend/dist
+          if-no-files-found: warn
+          retention-days: 7
+
+      - name: Check dist
+        run: |
+          if [ ! -d "dist" ]; then
+            echo "Frontend build failed - dist directory not found"
+            exit 1
+          fi
+
+          if [ ! -f "dist/index.html" ]; then
+            echo "Frontend build incomplete - index.html not found"
+            exit 1
+          fi
+
+          ls -la dist
+
       - name: Install Playwright Chromium
         run: pnpm exec playwright install --with-deps chromium
 
@@ -109,32 +148,3 @@ jobs:
             echo '- `frontend-playwright-report`'
             echo '- `frontend-test-results`'
           } >> "$GITHUB_STEP_SUMMARY"
-
-      - name: Build frontend
-        env:
-          MODE: production
-          ASTRO_TELEMETRY_DISABLED: 1
-        run: pnpm build:production
-
-      - name: Check dist
-        run: |
-          if [ ! -d "dist" ]; then
-            echo "Frontend build failed - dist directory not found"
-            exit 1
-          fi
-
-          if [ ! -f "dist/index.html" ]; then
-            echo "Frontend build incomplete - index.html not found"
-            exit 1
-          fi
-
-          ls -la dist
-
-      - name: Upload artifact
-        if: ${{ always() }}
-        uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0
-        with:
-          name: frontend-dist
-          path: src/frontend/dist
-          if-no-files-found: warn
-          retention-days: 7