Skip to content

Commit b7804b0

Browse files
Copilotskottmckay
andauthored
Update global-agent comments to use version-agnostic GitHub URL (#28061)
### Description Updates the `global-agent` reference in code comments across three files to use a version-agnostic GitHub repository URL, so the comments won't need updating on future version bumps. - **`js/scripts/utils.ts`** — replace version-specific blob URL with `// See the https://github.com/gajus/global-agent ReadMe.md regarding environment variables.` - **`js/node/script/install.js`** — same update - **`js/web/script/pull-prebuilt-wasm-artifacts.ts`** — same update ### Motivation and Context The actual `global-agent` dependency version bump (from `^3.0.0` to `^4.1.3`) was done in #27838. The accompanying comments referenced a version-specific blob URL (`/blob/v4.1.3/README.md#environment-variables`) which would need updating on every future version bump. Switching to the top-level repository URL keeps the comments accurate regardless of which version is installed. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: skottmckay <979079+skottmckay@users.noreply.github.com>
1 parent eb7a1bf commit b7804b0

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

js/node/script/install.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ const INSTALL_METADATA = require('./install-metadata.js');
2525

2626
// Bootstrap global-agent to honor the proxy settings in
2727
// environment variables, e.g. GLOBAL_AGENT_HTTPS_PROXY.
28-
// See https://github.com/gajus/global-agent/blob/v3.0.0/README.md#environment-variables for details.
28+
// See the https://github.com/gajus/global-agent ReadMe.md regarding environment variables.
2929
globalAgentBootstrap();
3030

3131
// commandline flag:

js/scripts/utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import { JSZipObject } from 'jszip';
88

99
// Bootstrap global-agent to honor the proxy settings in
1010
// environment variables, e.g. GLOBAL_AGENT_HTTPS_PROXY.
11-
// See https://github.com/gajus/global-agent/blob/v3.0.0/README.md#environment-variables for details.
11+
// See the https://github.com/gajus/global-agent ReadMe.md regarding environment variables.
1212
globalAgentBootstrap();
1313

1414
export const downloadZip = async (url: string, maxRetryTimes = 3): Promise<Buffer> => {

js/web/script/pull-prebuilt-wasm-artifacts.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ async function downloadArtifactsForRun(run: any): Promise<void> {
181181
async function main() {
182182
// Bootstrap global-agent to honor the proxy settings in
183183
// environment variables, e.g. GLOBAL_AGENT_HTTPS_PROXY.
184-
// See https://github.com/gajus/global-agent/blob/v3.0.0/README.md#environment-variables for details.
184+
// See the https://github.com/gajus/global-agent ReadMe.md regarding environment variables.
185185
globalAgentBootstrap();
186186

187187
console.log(

0 commit comments

Comments
 (0)